T10812: KDE Applications

[Nathaniel Graham]

ngraham closed this task as "Resolved".
ngraham added a comment.


  We renamed it the "release service" and no longer use "KDE Applications" as a 
brand name, in favor of using individual apps' names whenever possible.

TASK DETAIL
  https://phabricator.kde.org/T10812

To: ngraham
Cc: fusitter, valorie, rahulch, lydia, adrianchavesfernandez, aspotashev, apol, 
jriddell, xyquadrat, jtamate, vkrause, lbeltrame, ltoscano, cfeck, aacid, 
#yakuake, #okular, #dolphin, #kate, #spectacle, #konsole, #gwenview, #kde_pim, 
#kde_games, #kde_applications, ngraham

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  You have a long history with Breeze icons and care a great deal about design. 
Maybe **you** should be reviewing icon patches and suggesting improvements and 
working on new versions of problematic icons.
  
  Be the change you wish to see in the world. :)

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: churaev, tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, 
cullmann, IlyaBizyaev, arrowd, abetts, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  I get it, you think that there is or should be a meaningful difference 
between an application's icon and its logo, and that the breeze icon theme 
should be full of icons, not logos. But there doesn't seem to be much agreement 
with this idea: not among the current generation of VDG people; not even among 
some of the prior VDG people, who have complained about this to me; not among 
the developers of the apps in question who have complained about their current 
Breeze icons; not among users who file bug reports and complain about it. 
Furthermore, this proposed icon/logo split does not match the state of reality 
for most of the app ecosystem in the wider world; most apps use their icon as a 
logo, and design it accordingly to be able to serve both roles. And I'm not 
sure your counter-example of Firefox is something we want to emulate. For 
example, if I go to https://www.mozilla.org/en-US/firefox/mobile/, I see the 
following:
  
  F8729164: Screenshot_20200719_153303.jpeg 

  
  To me, this is weird: the same brand name ("Firefox") is displayed with two 
different icons on the same page (fine, one is an icon and one is a logo). If I 
saw this on https://kde.org/applications/, I would file a bug report. Mozilla's 
choice is not something I would call self-evidently better design. To me it 
looks weird and inconsistent. And I think the app icon looks much better than 
the logo, which is bland, indistinct, and bears no relation to the name 
(there's no fox, not even a stylized abstract one).
  
  I think you're a great designer and I would love for KDE to be able to 
continue benefiting from your expertise. But I think this will be difficult if 
it means that you're going to constantly try to push this idea of an app's icon 
not being its logo which does not seem to be very popular, because the conflict 
that it generates strains relationships, drives away conflict-averse people (as 
evidenced by people unsubscribing themselves from this Task), and makes you 
feel marginalized and unappreciated. That would be quite a shame and I hope we 
can figure out a way to continue working together.
  
  Regardless, let's do the design review for proposed new icons in the 
applicable merge requests themselves, not here.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: churaev, tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, 
cullmann, IlyaBizyaev, arrowd, abetts, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  @alex-l nobody shares your opinion that app icons are different from logos 
and that therefore they should have a minimal, understated style and do not 
need to mimic the original version. This isn't a self-evident design truth, 
it's  just your opinion on icon design, and nobody else seems to agree with you.
  
  Breeze icons are a theme among many themes, and not the canonical source of 
truth regarding apps' icons; changing an icon radically requires the consent of 
the app's author for them to change not only the Breeze icon, but also to 
change the original icon, potentially adopting the Breeze icon as the new 
original icon.
  
  You keep decrying that no real designers are reviewing icons yet you don't 
want to step up and do this, other than complaining that everyone else's work 
is crap. You should help guide new designers rather than just telling them to 
stop doing anything because the status quo is perfect.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  Cool stuff. Could you start submitting your icons are merge requests to the 
breeze-icons repo?
  
  https://invent.kde.org/frameworks/breeze-icons/-/merge_requests

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  I have a feeling they will, with some polish. :)

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  With Okular, I'm interested in being more faithful to the original if we're 
going to redo the icon. See up-thread: T10243#201368 
.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  I like those!

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

D29246: D361740 - Disable warning "The document requested to be launched in presentation mode" on document reload

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! Okular uses GitLab now. Can you re-submit this as a 
Merge Request at https://invent.kde.org/kde/okular/-/merge_requests/?
  
  Documentation can be found at https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D29246

To: ictwod, aacid
Cc: ngraham, aacid, ictwod, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a revision: D25123: New yakuake logo/icon.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  See also https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, 
cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, 
johnzh, andisa, siddharthmanthan, maguirre, gennad, fbampaloukas, joaonetto, 
kezik, tfella, skadinna, darcyshen

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, 
cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, 
johnzh, andisa, siddharthmanthan, maguirre, gennad, fbampaloukas, joaonetto, 
kezik, tfella, skadinna, darcyshen

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Looks like the dependent patch has landed, so we can more forward with this.
  
  Still LGTM.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, 
cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, 
johnzh, andisa, siddharthmanthan, maguirre, gennad, fbampaloukas, joaonetto, 
kezik, tfella, skadinna, darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  We should probably discuss this somewhere else so as to avoid derailing this 
poor task too much. :)

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  I see it in the about window: F7931541: Screenshot_20200124_082434.PNG 

  
  But not in the window's titlebar, or the window switcher, or Kate's task 
manager icon. Basically anything outside of Kate's direct control is using the 
old icon.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  Meanwhile I'm not actually seeing the new icon after updating the app from 
current git master. It should really be added to the Breeze icon theme.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  It's quite lovely! Much more aesthetically attractive than the current icon. 
However I fear that the recognizability as being a text editor has been lost; 
nothing about the icon connotes that it's for a text editor, which is 
compounded by the fact that the name "Kate" doesn't suggest that either. 
"KWrite" does though.
  
  This is not a huge deal as many other apps have the same thing going on. But 
it's something to consider.
  
  The icon should be submitted to the Breeze icon theme rather than renaming it 
in the code and changing the name you refer to it with. That breaks all 
3rd-party icon themes (which I guess was the point, but is not so nice :) ).

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

D21971: Replace ToolAction by ToggleActionMenu

[Nathaniel Graham]

ngraham added a comment.


  @davidhurka friendly ping. :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka, simgunz
Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D21971: Replace ToolAction by ToggleActionMenu

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase for sure

REPOSITORY
  R223 Okular

BRANCH
  create-configurable-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka, simgunz
Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

T12254: Create new icons for KPhotoAlbum

[Nathaniel Graham]

ngraham added a comment.


  That's not too bad! Needs a bit of work, but I think it's a solid foundation. 
I'll hand this over to #VDG 's icon 
design pros now. :)

TASK DETAIL
  https://phabricator.kde.org/T12254

To: ngraham
Cc: genkiginchan, ngraham, #vdg, #kde_applications, #konsole, #gwenview, 
#okular, #kate, #yakuake, #discover_software_store, #kde_pim, #ark, #kde_games, 
yurchor, ndavis, trickyricky26, kossebau, elvisangelaccio, lesliezhai, aacid, 
mludwig, filipf, mglb, knauss, stikonas, abetts, arrowd, IlyaBizyaev, cullmann, 
starbuck, alex-l, IohannesPetros, Leon0402, johanneszarl, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, GB_2, rkrawitz, crozbo, firef, alexeymin, skadinna, genaxxx, tleupold, 
aaronhoneycutt, jriddell, mbohlender

D21971: Replace ToolAction by ToggleActionMenu

[Nathaniel Graham]

ngraham added a comment.


  Sorry, this technical discussion is beyond me. :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D22118: Shifts focus to the document when collapsing a sidebar view

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  This was moved to invent at 
https://invent.kde.org/kde/okular/merge_requests/22

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22118

To: mayankchoudhary, #okular, aacid, sander, ngraham
Cc: ngraham, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  Since you've moved it over there, you can Abandon this from the Add Action... 
menu.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, 
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen

D21759: Hold zoom center below center/mouse position

[Nathaniel Graham]

ngraham added a comment.


  Behaviorally this works great, but visually there's now a big regression: the 
content itself is no longer visible during the zoom operation; the view blanks 
out and displays the default white background.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21759

To: steffenh, #okular, ngraham, aacid, kezik
Cc: ngraham, davidhurka, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D25647: Set the default font family for EPub's according to the user preference

[Nathaniel Graham]

ngraham added a comment.


  Can you put this on invent instead?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25647

To: yurchor, #okular
Cc: ngraham, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  Thanks, this looks great. It works just fine and the UI seems sane to me. I 
have some code comments:

INLINE COMMENTS

> shell.cpp:660
> +m_undoCloseTab->setEnabled( true );
> +m_closedTabUrls.push_back( url );
>  

prefer `append()`

> shell.cpp:778
> +{
> +if ( m_closedTabUrls.size() == 0 )
> +return;

coding style: always use braces

> shell.cpp:778
> +{
> +if ( m_closedTabUrls.size() == 0 )
> +return;

`m_closedTabUrls.isEmpty()`

> shell.cpp:783
> +
> +if ( m_closedTabUrls.size() == 0 )
> +m_undoCloseTab->setEnabled(false);

ditto

> shell.h:175
>QList m_tabs;
> +  QLinkedList m_closedTabUrls;
>QAction* m_nextTabAction;

A regular old QList of QUrls would seem to do just fine as it doesn't seem that 
you're using any functionality present in QLinkedList not in QList.

> shell.rc:8
> 
> +   
>

Need to bump the version number at the top of this file anything you change 
anything

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, 
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  I think we can assume that, but check in the code. I don't think we 
necessarily need to save anything in memory except the URL for the document 
shown in the closed tab.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, 
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  In D25484#567112 , @bdbai wrote:
  
  > In D25484#566490 , @pino wrote:
  >
  > > ...
  > >
  > > In D25484#566483 , @romangg 
wrote:
  > >
  > > > The solution to accidentally clicks is not disabling it by default and 
making it configurable, but providing the functionality to "restore" a tab 
after closing it accidentally. Dolphin and Chrome allow me to restore the last 
closed tab with Ctrl+Shift+T.
  > >
  > >
  > > And this "solution" does not always work, for example when a page was the 
result of a form submission, redirection, or other kind of interactivity.
  >
  >
  > @ngraham In Okular, when a tab with unsaved changes is about to close, the 
user will be prompted first. Does this help?
  
  
  Yes this helps the case that @pino brings up, but it handles a different use 
case. Most of the time a tab won't have unsaved changes because Okular is 
primarily a reading app. An "Undo last closed tab" feature is for these other 
cases.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, 
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  The KDE Community is transitioning away from Phabricator and towards GitLab. 
The transition is not yet complete, which is why the documentation still points 
you towards Phab. Individual apps--such as Okular--have already made the jump 
as "early adopters", so to speak.
  
  Probably it's fine to keep this here since there's already been some 
discussion that it would be good not to lose, but please use 
https://invent.kde.org/kde/okular/merge_requests for future Okular 
contributions. Thanks!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, 
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  Sure, go ahead and edit the task. If you're dissatisfied with KPhotoAlbum's 
icon, VDG is happy to help.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, 
jriddell, mbohlender

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  Undoable tab closing seems totally uncontroversial to me. Web browsers have 
it, Dolphin has it... It's really just a matter of consistency. On that 
subject, here's how Dolphin does it: F7782117: Screenshot_20191124_111840.png 

  
  So it would have a menu item + the standard keyboard shortcut. Seems like a 
pretty decent UI to me.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, 
aacid

D21759: Hold zoom center below center/mouse position

[Nathaniel Graham]

ngraham added a reviewer: kezik.
ngraham added a comment.


  Oops, sorry I lost track of this patch. Can you rebase it please so we can 
continue the review?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21759

To: steffenh, #okular, ngraham, aacid, kezik
Cc: ngraham, davidhurka, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  @bdbai, to move this forward, do you think you could also make tab closing 
undoable?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, 
aacid

D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  In D25484#566477 , @pino wrote:
  
  > > Do people frequently misclick with the middle mouse button?
  >
  > It can happen, and more often with a touchpad.
  
  
  I assume you're talking about Libinput's virtual middle mouse button for 
buttonless touchpads when using the default "areas" click mode. IMO this is a 
library problem that we should not work around in apps. You can tell Libinput 
to use "fingers" rather than "areas" mode and then middle-clicking requires 
three fingers which is much more difficult to do accidentally. Our touchpad KCM 
allows configuring this, though we don't make it the default because we respect 
upstream defaults. We could consider overriding that and using the "fingers" 
click method by default the way we currently override upstream defaults to 
force better font hinting in the Fonts KCM.
  
  In D25484#566483 , @romangg wrote:
  
  > The solution to accidentally clicks is not disabling it by default and 
making it configurable, but providing the functionality to "restore" a tab 
after closing it accidentally. Dolphin and Chrome allow me to restore the last 
closed tab with Ctrl+Shift+T. Does Okular the same?
  
  
  Exactly. If tab closing is undoable, then closing accidentally is no big deal 
at all.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, 
aacid

D21971: Replace ToolAction by ToggleActionMenu

[Nathaniel Graham]

ngraham added a comment.


  Sorry, what is it that you'd like my input on? This conversation is rather 
long and I'd like to be 100% sure I understand what you're asking about.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a dependent revision: D25229: Update docs to the new annotation 
toolbar.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, 
cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, 
johnzh, andisa, siddharthmanthan, maguirre, gennad, fbampaloukas, joaonetto, 
kezik, tfella, skadinna, darcyshen

D25229: Update docs to the new annotation toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D15580: New annotation toolbar.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25229

To: yurchor, #okular
Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, 
maguirre, gennad, fbampaloukas, joaonetto, kezik, tfella, skadinna, darcyshen, 
aacid

D25229: Update docs to the new annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Wow, this must have been a huge amount of work. Very nice.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25229

To: yurchor, #okular
Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, 
maguirre, gennad, fbampaloukas, joaonetto, kezik, tfella, skadinna, darcyshen, 
aacid

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of D21971 .

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21635

To: ngraham, #okular, #vdg, ndavis, aacid
Cc: davidhurka, aacid, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, 
davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#206539 , @alex-l wrote:
  
  > Thank you for your replies. As I said I discussed a new icon for Activities 
time ago but Ivan decided to stay with the 3-dots one. I can't always be around 
to check that previous decisions aren't overwritten by others. Isn't up to 
others to check if there were previous discussions on an icon?
  
  
  In any project, every single change can be seen as overriding a previous 
decision. Like I said, if you want previous decisions to have more weight, you 
or someone else needs to be around to provide the context, remember the 
discussion, bring up alternatives, etc. Previous decisions are not self-evident 
and self-enforcing, especially when the result is something that is problematic 
or accumulates complaints from users or developers. The hardest decisions to 
enforce in absentia are those that resulted in an imperfect compromise.
  
  > The one on the Activities icon is somewhere here on Phabricator. Found: 
https://phabricator.kde.org/M90
  
  Unfortunately Phab search is so horrible that if you hadn't linked to it 
directly, there's no chance I would have ever found it even if I was 
specifically looking for it. :(
  
  > The most important rule in my opinion in VDG was: don't change things just 
for the sake of changing.
  
  This is a strong pet peeve of mine and I agree 100%. As a result, we never do 
this; every change is because we think the change is a positive improvement.
  
  For example we changed the activities icon because otherwise the icon it was 
using before was 1) used in other contexts, 2) nondescript and meaningless, and 
3) monochrome when we were trying to consistently use colorful icons for System 
Settings KCMs. This are not "chang[ing] things just for the sake of changing"; 
those are three good reasons. Maybe the result isn't amazing. I wouldn't say 
it's my favorite icon either. But doing something for good reasons and failing 
is not the same thing as doing thing for no good reason, such as because we're 
bored and restless, because we like changing things around to justify our 
existence, or because we feel the need to chase design trends. I constantly 
push back on proposals that I believe originate from one of these reasons.
  
  > In fact the current Dolphin, Gwenview, System Settings and other icons were 
designed for personal use by me but other VDG members noticed them from my 
screenshots and asked to submit them, despite the rule of not changing things. 
It is a matter of attitude: if there is broad agreement to update an icon then 
proceed. If you are not sure, keep everything as it is, trusting the previous 
designers who probably took that decision for reasons.
  
  When it comes to app icons, the VDG has in fact settled on a fairly strict 
guideline for apps that already have icons: don't erode the app's pre-existing 
branding; just make a Breeze-ey version of the icon. If you do want to make a 
Breeze icon that's substantially different from the app's existing icon, you 
need to have a conversation with the app's maintainer and/or developers to 
formally change the app's official icon to your new icon.
  
  Various Breeze icons violate this guideline, to the point where the apps' 
developers reject them in favor of the old ones (for example, Okular and Kile). 
That's ultimately the point of this task: to improve the breeze icons for 
various apps of ours so that they 1) look better, 2) match the branding 
guidelines we've set out, and 3) become accepted by the apps' developers.
  
  > One single person who gives the OK to update the icon for a core KDE app? 
It's the opposite of our previous attitude...
  
  That's a fair point. In general we should probably be more conservative when 
it comes to approvals. This requires more people with the time and willingness 
to review patches, of course. :). And node that for the two app icons we have 
changed so far--Kolf and Kile--we did seek and receive the approval of the 
apps' maintainers.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#206510 , @ndavis wrote:
  
  > These things are what happens when the experienced people with all the 
unwritten knowledge go away. The redesigning of icons is a direct result of 
that. People redesign when they don't understand the system they are working 
with.
  >
  > This post might sound a bit hostile, but please understand that it's just 
so frustrating to work with so little from the beginning and have someone who 
is a capable designer and who seems to have some old forgotten knowledge 
complain about the state of things. Maybe you and everyone else had other 
things in your life, maybe you and everyone else got bored (I know I am getting 
bored with icon work). That's fair, but try to understand what the rest of us 
have to deal with and maybe help out.
  
  
  Yeah.
  
  I don't know what happened in the past, but I've heard some vague stories 
about some split in the VDG and how all the designers left in 2016 or 
something. I know Uri went off to do his own thing, Jens is gone, Andy is gone, 
Hugo is mostly gone, you're mostly gone, and so on. When I joined KDE in early 
2017, the perception of the VDG seemed to have hit rock-bottom among 
developers, and it seemed to have no leadership or direction.
  
  This is the world we were left with, and without a real maintainership 
hand-off, we've basically had to rebuild things ourselves without--as Noah 
points out--documentation, experience, or a deep understanding of why things 
came to be. As a result, in our enthusiasm, we've made some mistakes and had to 
revert changes that weren't popular. We were learning as we went, because we 
had to build up the knowledge and experience ourselves.
  
  But this is a common fate for open-source projects where the maintainership 
duties are not handed off properly. Open-source projects are public. Without 
solid direction provided by a maintainer or leader, they drift randomly in 
different directions until either they die, or new leadership appears, at which 
point they might start to drift *consistently* in a different direction. :). 
The only way to ensure that a project goes in the direction you want it to go 
in is to continue being active in that project, or ensure that the leadership 
or maintainer positions are handed off to someone who shares your vision. You 
can't just say, "Hands off, we did things for a reason, please don't touch it," 
and then disappear, or else some weirdo internet randos like us may find it and 
decide that it's awesome but needs some changes, and you might not like those 
changes. :)
  
  So come on back! :) Teach us your knowledge. Help us make icons that are 
beautiful and meaningful and also win the support of the developers of the apps 
they're going to be branding. We want to learn from you!

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#557314 , @andreashurka 
wrote:
  
  > - stamps won't get printed (both to pdf and paper)
  
  
  This is a pre-existing issue: https://bugs.kde.org/show_bug.cgi?id=383651
  
  Definitely needs to be fixed eventually of course. :) From what I understand 
it's rather challenging.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, 
davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'm happy with the UI now. :) Subsequent improvements and polish can be 
delivered in follow-up patches.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, 
knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  `window-close-symbolic` is black instead of red FWIW. Maybe we should just 
use that for now
  
  @trickyricky26  and #vdg , I do agree 
that our red close buttons draw too much attention to themselves for 
non-destructive close actions. We might want to consider adding a version 
that's gray.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#554079 , @simgunz wrote:
  
  > I have never seen a close button on a standard toolbar. Are you sure it is 
a correct design pattern?
  
  
  This isn't a standard toolbar; it's a toolbar that can be shown and hidden. 
Once it's shown, it's not obvious how to hide it--especially now that it shows 
itself after using a quick annotation tool. That'll make it appear, but it 
won't be obvious how to make it go away again if it doesn't have an integrated 
close button.
  
  Even though the HIG recommends against it, I think it's fine to change the 
button style here since we're quite space-constrained.
  
  Expanding spacers were added in 4357ef235ecb8b8b71ca0867d6cfc02acf292fae 
.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  All right, that works!
  
  I think there's only one remaining thing I noticed, then I'm ready to give it 
a UI stamp of approval: the toolbar should have a close button on the far-right 
side (you can use an expanding spacer to position it there) so people don't 
have to go up to the menubar to close the toolbar once they're done using it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#552455 , @simgunz wrote:
  
  > When an annotation is selected its annotation toolbar button is checked and 
Browse Mode is checked, exactly as in the current Okular version. 
  >  When you select a quick annotation tool what happens is that the 
corresponding annotation action gets checked. In a sense a quick annotation is 
just an alias for an effective annotation with a specified set of settings 
(color, etc.). For this reason the quick annotation cannot have a checked 
state. 
  >  This however has a quirkiness in the case the annotation toolbar is 
hidden. In that case we are in Browse Mode and an annotation tool is active but 
we do not see the corresponding checked action in the hidden toolbar. This can 
be "solved" by showing the annotation toolbar when a quick annotation is 
selected, but I think it is going to become frustrating very soon.
  
  
  Yeah, I don't think that's ideal.
  
  > Regarding browse mode, we can also uncheck it when an annotation is 
selected, if there are no side effects.
  
  That's mostly what I think should happen. Not just browse mode though, but 
rather any tool that's currently active should become unchecked when you're 
using an annotation. Okular has a set of mutually-exclusive tools; annotations 
are just additional tools added to this list. For example you can't be both 
using an annotation and also in Browse mode. Rather, Okular would go back to 
Browse mode after you're done using an annotation tool.
  
  > Yes, but I do not know how to do it. See 
https://phabricator.kde.org/D15580#544534 for the details of the problem.
  
  For now maybe we should just have an action rather than a toggle that's in 
sync with the toggle action in the menubar?
  
  > I thought about this, but I decided to leave "Configure Annotations" given 
that in the same KCM module the user can configure the "annotation identity", 
which is not related to "Quick Annotations" but to "Annotations" in general. 
  >  Changing it to "Configure" won't work either. This is a standard action 
that will appear in the "Configure Toolbar" and "Configure Shortcuts" dialog. 
If you call it "Configure" it will become ambiguous for the user.
  
  Okay, let's drop it.
  
  > Currently the action name and thus the text is "Pin". You mean I should 
change "Pin" to "Keep Active"?
  
  Yeah.
  
  > I agree with @davidhurka here regarding having it on by default. I cannot 
figure out a use case where a user wants to add a single annotation or keep 
reselecting it each time.
  >  My typical use case is: I am reading a paper/book and I check the 
highlighter to highlight the text multiple times while I read, so I want it 
always active. The highlighter is a common use case, think at e-readers which 
have only highlighters and notes.
  >  Another one is to fill in multiple forms with the typewriter.
  >  What real-world use cases do you have in mind where you do not need it 
always active?
  
  All right, you've convinced me! Never mind on this.
  
  > Where would you show it? In the action tooltip? e.g "Approved - Stamps are 
an experimental feature"
  
  Maybe in a KMessageWidget that goes across the top of the view, like other 
notes that are presented like this.
  
  > 
  > 
  >  ---
  > 
  > The things from here and below are very interesting but also quite 
complicated to implement and time-consuming. I would implement them in 
following revisions, or we won't ever terminate this one while trying to make 
the toolbar perfect. Release early, release often.
  
  OK, fair enough. :-)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#552381 , @davidhurka 
wrote:
  
  > Yeah, but [_] Annotation Toolbar would be more natural, I think. At least 
for users who figured out the meaning of “toolbar”.
  
  
  That's a good idea. It would be: `[ ] Show Annotation Toolbar` (menu items 
need to start with action verbs). And then the menu item in the Tools menu 
would be the same. probably the same QAction would just used for both; then 
they would both keep track of state properly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  This is super fantastic.
  
  I have a few more observations from use:
  
  - When using one of the quick annotations, the Quick Annotations button 
should have a checked state so you can tell that one of its tools is active 
(otherwise the previously-active toolbar button still looks checked despite not 
being active)
  - Maybe add a new menu item at the bottom of the Quick Annotations menu 
saying "Show all" that will open the full toolbar
  - The menu item that says, "Configure annotations..." should probably say 
"Configure quick annotations..." since it applies to the annotations in the 
quick annotations list, not all annotations more generally. Or even just 
"Configure..."
  - I would add text to the Keep the active annotation button active after use 
toolbutton, since otherwise it's a bit hard to tell what it does. Maybe "Keep 
active" or "Keep active after use" (maybe that's too long)?
  - Maybe don't have the Keep Active button checked by default. In testing, it 
feels more natural to have to click on an annotation's button after each use.
  - When an existing annotation is selected, it would be really nice if the 
controls for choosing the color, line thickness, opacity, font details etc. 
became active again and allowed you to change that annotation's appearance 
after the fact. You can already edit it by right-clicking and going to 
Properties, but it would be even nicer to be able to do this in a more direct 
manner IMO
  - It would be nice if highlight, underline, squiggle, and strikethrough 
annotations were mouse-selectable while the annotations toolbar is open. That 
way it would be more obvious how to delete them, and you could change their 
properties using the above method
  - It might be nice if hitting the [9] key multiple times cycled through the 
items in the shape annotation menu
  - The [0] key could do the same for the stamp annotation
  - Now that we have a way to add stamp annotations using this new method, we 
need to show the message that stamp annotations are an experimental feature so 
that users know that they can't necessarily rely on it. Currently they only see 
this in the annotation settings window
  
  Overall this is feeling really good and I think it's quite close to being 
ready for prime time.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Those color pickers are great. Can we get the tool buttons moved back to 
being icons-only so they'll fit in one row for an un-maximized window?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, 
ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Typically the color chooser includes a "transparent" item.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen

D24606: Prevent user changing the stamp opacity

[Nathaniel Graham]

ngraham added a comment.


  Do we know why it's rendered incorrectly when not opaque? Is this a bug in 
Okular or Poppler?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D24606

To: simgunz, #okular, #vdg
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  @mglb would you be interesting in submitting patches with those new icons?

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Yeah. `draw-highlight` is coming too in D24493 
.
  
  With the better icons, maybe we can move the inviditual tools back to being 
icons-only to save a ton of space, and then everything will fit into a toolbar 
when the window isn't super wide.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  Those are amazing and I love them! Especially the Yakuake icon where you've 
made the > character look like a subtle Y. That's just genius.
  
  The Konsole icon with the K in it might be a bit too complicated, but the 
simple version is top-notch. I would strongly encourage you to submit them in 
patch form. :)

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#202038 , @mglb wrote:
  
  > We already explicitly suggest to make 48px application icons only 
 (only few have more sizes). 
Titlebar and taskbar use ~22px icons, so you can either get bad looking small 
icons, or give up with nice details on 48px ones.
  
  
  Potentially bad-looking small app icons is an acceptable price to pay IMO.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  If you don't like the proposed vertical toolbar, that's okay, but then we're 
going to need to sort out a lot of tricky UI issues for the horizontal toolbar 
and have perfect icons.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, darcyshen

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#201370 , @alex-l wrote:
  
  > I don't think glasses will ever look good at small sizes, can't we use 
something else for Okular? A clip? A highlighter?
  
  
  Looks okay to me at 32px: F7379054: Screenshot_20190918_145934.png 

  
  But again, if we want to actually change the icon rather than creating a 
Breeze version of it, that requires the consultation and permission of the 
developers (i.e. #okular  people).

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  That's not a bad icon, but again, I think we owe it to the app developers to 
be as true to the original icon as possible. That text-origami-bird icon is 
cool, but it has nothing to do with Kate's original icon. The HIG specifically 
recommends against this:
  
  > https://hig.kde.org/style/icons/application.html
  >  When creating a Breeze theme version of an existing app’s icon, is 
critically important that the icon’s existing brand and visual style be 
preserved. The goal is to create a Breeze version of the icon, not something 
completely new and different.
  
  For example, here's Okular's original icon: F6517594: okular.png 

  
  Here's the Deepin icon theme version of it, as @filipf pointed out up-thread:
  F7378824: Okular-deepin.png 
  
  IMO this version of the icon is both much better than the Breeze icon 
version, and also more true to the original. That's the kind of thing we should 
strive for with Breeze icons. If we want to make a totally new icon, it needs 
to be done in coordination with the app's developers and have their approval.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#201332 , @alex-l wrote:
  
  > @ngraham I don't know about macOS, but ElementaryOS icons look so good 
because they are designed for each size and I don't think we have the manpower 
to do that to Breeze icons.
  
  
  But we already do this. Despite the fact that we use arbitrarily scalable SVG 
icons, we generally provide several sizes for each one so they look 
pixel-perfect at the common sizes that they're intended to be viewed at.
  
  > The diagonal thing in Konsole icon is to add some identity, without it we 
would have a classic terminal icon. Any ideas on how to add identity in general?
  
  Maybe we could play with the KDE logo and render it or parts of it in ASCII 
on the screen? We probably need to keep the `>_` symbolism though because we 
use this all over the place to mean "terminal stuff"

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  In T10243#201329 , @alex-l wrote:
  
  > EDIT: I have already said this here and there but please don't run any 
automated script to SVG icons, because when opening them back in Inkscape they 
are corrupted and everytime I edit a Breeze icon I have to do additional work 
to fix shapes and gradients corrupted by the scripts.
  
  
  This is something you should bring up in the VDG chatroom and discuss with 
@ndavis in particular as we currently make heavy use of these scripts for 
optimization purposes. Hopefully we can come up with a solution together.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  I have a problem with //extreme// minimalism in same the way that I have a 
problem with extreme ornamentation. I don't like either one, when taken too 
far. The problem with doing this is that it irritates people who really dislike 
that style, and they push you to go in the opposite direction, and then the 
people who dislike that style object and push you back, and so on forever.
  
  This is by no means limited to icons; it's part of a global aesthetic cycle 
that has played out across the centuries. The way the excessively ornamented 
romantic style gave way to modernism in art and architecture is a great example.
  
  In my opinion, the best way out of this seemingly endless cycle is balance: 
you strive for simplicity, but with reasonable ornamentation. In the same way 
that artists and architects are re-discovering the value of targeted 
ornamentation in their designs, so too can we--but in a reasonable, focused 
way. You can't go too simple, or else it looks cold, barren, and excessively 
harsh and masculine. But you also don't go overboard on ornamentation or else 
it feels smothering, claustrophobic, and excessively feminine. A pleasing 
mixture is needed.
  
  In my opinion, macOS and ElementaryOS icons do a great job of this. They're 
simple, but not too simple. That have visual flourishes, but they don't go 
overboard. And they just look rich and beautiful. IMO. :)
  
  Regarding the Konsole icon, I like the idea of drawing a frame around the 
dark part to make it look more like an old-fashioned terminal and provide 
better visual continuity with the original Konsole icon (which after all we are 
trying to be faithful to). I'm not sure I like the diagonal swooshy bit that 
appears to overlap the central display though. It looks sort of weird and out 
of place. IMO it would look better without that. I also don't think the symbols 
in the middle need soft shadows. That makes then seem like they're popping out 
of the display when in fact the opposite is true: they're embedded within it. 
An embossed effect might be better, if anything at all is needed.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  The problem I have with Gwenview's icon is that it just feels inferior to the 
Oxygen one.
  
  The Oxygen icon has presence and communicates a style and brand, but doesn't 
really do a good job indicating what the app does. The Breeze icon feels like 
it tries to fix that problem by putting a monochrome image inside the eyeball, 
but I don't think it really works because the symbol is small and it's only 
part of the original image symbol, and in the process the icon loses the 
presence of the Oxygen icon. It doesn't really look much like an eyeball 
anymore, and the pink color is so pale and unappealing (IMO) compared to the 
original.
  
  In general it's a good idea to make the icon more obviously an image viewer 
but I don't think the current approach works. I think just making a Breezey 
version of the original icon would be more respectful to it. If it's deemed 
absolutely necessary to reinforce the "Hey, I'm an image viewer" information, 
maybe put the breeze-style eyeball inside a picture frame or something.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Nathaniel Graham]

ngraham added a comment.


  Yeah, an app's icon is a part of its branding. It //should// look 
distinctive, not generic. Ideally it communicates both its purpose ("I'm a text 
editor!") as well as its identity ("I'm Kate!"). I think the problem with some 
of these icons is that they on;y do the former, not the latter.
  
  The fact that we have a consistent visual style for Breeze icons is already 
something that builds the KDE brand. But that doesn't require that individual 
app icons are generic-looking and lack identity for the apps themselves.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added a comment.


  It's possible the #Okular  people 
are all looking only at GitLab merge requests since Okular has migrated to 
GitLab.. It's possible you'll get more eyeballs on it if you re-submit this at 
https://invent.kde.org/kde/okular/merge_requests

REPOSITORY
  R223 Okular

BRANCH
  search_withing_document (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular, ngraham
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

D11051: Remembering side navigation panel state

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  This is on GitLab now: https://invent.kde.org/kde/okular/merge_requests/22

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: ngraham, #okular, aacid, dileepsankhla
Cc: okular-devel, tobiasdeiminger, aacid, sander, #okular, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen

D11051: Remembering side navigation panel state

[Nathaniel Graham]

ngraham commandeered this revision.
ngraham added a reviewer: dileepsankhla.
Herald added a subscriber: okular-devel.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: ngraham, #okular, aacid, dileepsankhla
Cc: okular-devel, tobiasdeiminger, aacid, sander, #okular, andisa, 
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. #Okular  people, any comments?

REPOSITORY
  R223 Okular

BRANCH
  search_withing_document (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular, ngraham
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> part.cpp:526
>  connect( m_pageView.data(), ::rightClick, this, 
> ::slotShowMenu );
> +connect( m_pageView, ::triggerSearch, this, 
> ::slotShowFindBarWithInitialText );
>  connect( m_document, ::error, this, ::errorMessage );

You could probably use a lambda here too, to avoid creating a single-use 
function

> part.cpp:2250
>  
> +void Part::slotShowFindBarWithInitialText(const QString )
> +{

ditto

> part.h:227
>  void slotShowFindBar();
> +void slotShowFindBarWithInitialText(const QString& serchText);
>  void slotHideFindBar();

Typo: `serchText` -> `searchText`

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added a comment.


  Works great. I have some UI suggestions below:

INLINE COMMENTS

> pageview.cpp:4371
>  const QString squeezedText = KStringHandler::rsqueeze( 
> searchText, 21 );
> -webShortcutsMenu->setTitle( i18n( "Search for '%1' with", 
> squeezedText ) );
> +webShortcutsMenu->setTitle( i18n( "Search for '%1' in", 
> squeezedText ) );
>  

This grammar change makes it wrong for all the other entries.

Maybe the new "Search for  in open document" menu item should be in the 
base level of the context menu, and not inside the sub-menu.

> pageview.cpp:4374
> +QAction *action = new QAction(i18n("Opened Document"), 
> webShortcutsMenu);
> +action->setIcon( QIcon::fromTheme( 
> QStringLiteral("document-open") ) );
> +connect(action, ::triggered, [searchText, this]() { 
> Q_EMIT this->triggerSearch(searchText);});

The icon should be `document-preview` (`document-open` is used for actions that 
open documents)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, 
kezik, tfella, ngraham, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham retitled this revision from "Fixing: Bug 408355 - Selection context 
menu missing find in this document" to "Add "find in this document" to 
selection context menu".
ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa
Cc: okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, 
kezik, tfella, ngraham, darcyshen, aacid

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#515250 , @davidhurka 
wrote:
  
  > In D15580#514707 , @ngraham 
wrote:
  >
  > > In D15580#513826 , @simgunz 
wrote:
  > >
  > > > - How would you fit the annotation actions in the Reviews tab?
  > > > - Would you create a sub-tab in it (as in Gwenview where the tabs are 
at the bottom)? -
  > > > - Can you provide a minimal mockup of this?
  > >
  > >
  > > Having it tabbed like Gwenview was what I was envisioning, yeah. 
Basically copy the UX of Gwenview's sidebar, but inside Okular's Reviews tab.
  >
  >
  > I’m not sure whether I understand you. This is a screenshot of the sidebar 
in Gwenview “Operations”. Additionally to the sidebar tab Reviews, you want a 
tab “Add Annotations”, looking like this?
  >  F7264576: image.png 
  >  Or you want to add a tab bar to the bottom of the Reviews tab, containing 
Annotations and Add Annotations?
  >  I would simply put the annotation toolbar on top of the Reviews tab, on 
top of the search box. Probably it would cover multiple lines, if that is 
possible with Qt.
  
  
  Yeah, that might make more sense that having a tabbed view inside the review 
tab. But yes, I was envisioning a vertical toolbar like the above screenshot.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#513826 , @simgunz wrote:
  
  > - How would you fit the annotation actions in the Reviews tab?
  > - Would you create a sub-tab in it (as in Gwenview where the tabs are at 
the bottom)? -
  > - Can you provide a minimal mockup of this?
  
  
  Having it tabbed like Gwenview was what I was envisioning, yeah. Basically 
copy the UX of Gwenview's sidebar, but inside Okular's Reviews tab.
  
  In D15580#513826 , @simgunz wrote:
  
  > I would rather not cram the "Quick annotations" by populating it with all 
the basic annotations. The user will end up with the same set of tools in two 
different places, which is not the point of "Quick annotations". I would 
instead populate it with 3-4 example custom annotations to illustrate the 
purpose of that list, putting the likely most used annotations. For example: 
yellow and green highlighter (to demonstrate we can have two highlighter 
colors), inline note, popup note, and typewriter.
  
  
  Cool, that makes sense to me.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#513395 , @davidhurka 
wrote:
  
  > In D15580#513253 , @ngraham 
wrote:
  >
  > > Some thoughts:
  >
  >
  > These thoughts sound good to me.
  >
  > > - Show a button on the toolbar by default that holds the list of favorite 
annotations, [...] "Quick annotations". At the bottom of the list, add an entry 
that says something like, "Show advanced annotation settings" that will display 
the full vertical toolbar in the Reviews tab.
  >
  > You mean a menu button in the main toolbar, with an entry that simply opens 
the Reviews tab? Or can the annotation toolbar itself be shown/hidden in the 
Reviews tab?
  
  
  Sort of. The proposed button in the toolbar would show a menu of 
pre-configured favorite annotations when clicked on, with a menu item at the 
bottom that opens the Reviews tab, which under my proposal also holds the full 
annotations toolbar.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Some thoughts:
  
  - Instead of using a horizontal toolbar below the main toolbar, instead I 
might experiment with a vertical toolbar like the one shown in Gwenview's View 
mode. We could make the toolbar live inside the Reviews tab, which appears to 
be somewhat mis-named and already shows a list of all annotations. REASON: 
cramming everything into a horizontal toolbar seems impossible for a feature 
this rich; using a vertical toolbar provides us enough horizontal space to show 
labels for everything, and enough vertical space to easily hold everything. 
Also we re-use an existing UI element that's currently rather bare.
  
  - Show a button on the toolbar by default that holds the list of favorite 
annotations, and pre-populate it with the current set of default annotations. 
Label the button "Quick annotations". At the bottom of the list, add an entry 
that says something like, "Show advanced annotation settings" that will display 
the full vertical toolbar in the Reviews tab. REASON: This will make the whole 
annotations UI much more discoverable.
  
  - Remove "Favorites" button from the annotation toolbar (since it'll be on 
the main toolbar instead)
  
  - Rename "Add to favorites" to say "Add to quick annotations"
  
  - Given Okular's conservative Frameworks dependency policy, I need to 
marshall VDG resources ASAP for the icons. Do you have a full list of the icons 
we need?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  Thanks, I was indeed not seeing the latest version. After deleting the 
necessary config files, I see the latest version in its own toolbar below the 
main one. This is a lot better than the current one already, but I think we can 
polish it even more. I have a lot of thoughts percolating and it may take me a 
few days to get them all written down. But I will do so soon!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D23037: Add support for cb7 comic book archives

[Nathaniel Graham]

ngraham added a reviewer: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Nathaniel Graham]

ngraham added a comment.


  I agree, yeah.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Thanks @simgunz, this is really excellent work. Adding @VDG for more UI 
review comments.
  
  For my own UI review, I must continue to push for putting the annotation 
tools on a second toolbar that appears below the main one when needed. Adding 
them to the main toolbar is only feasible when the window is really really 
wide; otherwise most or all of the buttons get elided. Once they're in their 
own toolbar, there should be enough horizontal space to give most or all of the 
buttons text on the side, which should resolve the confusion regarding what 
they are and which ones are actions vs settings for other tools.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D22903: Improve search field

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R223 Okular

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> Thumbnails.qml:33
>  id: searchField
> -anchors.fill: parent
> +placeholderText: i18n("Search in document…")
>  enabled: documentItem ? documentItem.supportsSearching : false

Placeholder text should just be "Search..."

Use three dots instead of the ellipsis character

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

[Nathaniel Graham]

ngraham added a comment.


  Sigh, I guess so

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Use `Kirigami.SearchField` instead; it takes care of everything for you. 
You'll need to import Kirigami 2.8 or later for this.
  
  Also the changes to `ThumbnailsBase.qml` are unrelated to the subject; please 
do them in another patch (or just commit directly since it's so minor).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22904: Fix bookmark action

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  fix-bookmark

REVISION DETAIL
  https://phabricator.kde.org/D22904

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22904: Fix bookmark action

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> MainView.qml:36
> +onCheckedChanged: pageArea.page.bookmarked = checked
> +text: pageArea.page.bookmarked ? i18n("remove bookmark") : 
> i18n("bookmark this page")
>  }

Capitalize the first letters of each tooltip; tooltips use sentence-style 
capitalization

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22904

To: jbbgameich, #okular, #plasma:_mobile
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D21196: [RFC] Move Continuous option to View Mode submenu

[Nathaniel Graham]

ngraham added a comment.


  The new icons will land in KDE Frameworks 5.61. If you request icons that 
don't exist, nothing bad happens, they just don't get displayed. So you should 
be able to add your `setIcon()` calls anyway, and users with frameworks 5.61 
will get them, and everyone else simply won't. So there's no need to bump the 
frameworks dependency version for Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21196

To: davidhurka, #okular, #vdg
Cc: ngraham, okular-devel, kde-doc-english, maguirre, gennad, fbampaloukas, 
joaonetto, kezik, tfella, skadinna, darcyshen, aacid

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7069d6f0cb3d: Add view-pages-* icons, as needed in Okular 
for page layout selection (authored by davidhurka, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62603=62608

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis, ngraham
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[Nathaniel Graham]

ngraham added a comment.


  Thanks very much! So now we can expect to see an Okular patch, right? :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis, ngraham
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22064: General improvements to stamp annotation

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular, ngraham
Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen

D22064: General improvements to stamp annotation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1, I say shipit!

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular, ngraham
Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen

D22064: General improvements to stamp annotation

[Nathaniel Graham]

ngraham added a comment.


  In D22064#501601 , @simgunz wrote:
  
  > In D22064#501557 , @ngraham 
wrote:
  >
  > > Exactly what I was imagining!I might also add at the beginning something 
like: "Warning:  feature is considered experimental."
  >
  >
  > Is it ok like this?
  >  F7091319: Screenshot_20190724_182254.png 

  >
  > The longer sentence would wrap given the dialog default size
  >  F7091324: Screenshot_20190724_182457.png 

  >
  > Should  'Experimental' after the column be capitalzed or lowercase?
  >
  > In the k18n guide ( tag), it is capitalized, but maybe it is just 
an example. Does the HIG say anything about this?
  >  https://api.kde.org/frameworks/ki18n/html/prg_guide.html
  
  
  The HIG doesn't have specifically anything to say about this, but the "W" in 
"Warning" should definitely be capizalized. As for the other question, the 
rules of American English grammar dictate that you only capitalize the first 
letter of the first word after a colon if it's a full sentence, and even then 
it's optional. So in the first image, the "E" in "Experimental sould definitely 
be un-capitalized. In the second image, the "T" in "This" could be capitalized 
only if you feel like it.
  
  I think the shorter version is better.

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular, ngraham
Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen

D22064: General improvements to stamp annotation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Looks good to go from my perspective. My vote goes to shipping it after you 
tweak the string in the way I suggested. Nice work! 

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular, ngraham
Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, darcyshen