Re: [Okular-devel] Problems in rendering some PDF files with form buttons.
On 19 October 2015 at 23:48, Albert Astals Cid <aa...@kde.org> wrote: > El Monday 19 October 2015, a les 17:03:38, saheb preet singh va escriure: > > Hi, > > Hi > > Hi, > Some of the files in okular with form buttons do not open correctly. > > > > For example, in this > > < > https://drive.google.com/file/d/0BwD5OKoszBXoYmU0dDRrc2VpeHM/view?usp=shari > > ng> file, > > when forms are enabled the content of the file is hidden where buttons > are > > shown. > > > > Also, when there is some image on the button, instead of text the content > > is hidden behind the button. > > > > Can we have transparent buttons as shown in adobe reader, or some > > translucent effect as in pdf reader embedded with chrome. > > Have you checked if the PDF contains some rendering hints that say how the > buttons should be rendered and maybe we're not obeying those? > > I don't have much idea about how to find the rendering hints in a document, but from what I can see I guess its specified that forms alpha value should be 0.5. This <http://ctrlv.in/657475> screenshot shows the object tree of the document. In the type form xobject ( fm1 ) of the page, the ca value is shown to be 0.5, which represents the alpha value. Thanks, Saheb Preet Singh. > Cheers, > Albert > > > > > I tried making buttons transparent and it works fine. > > > > Best, > > Saheb Preet Singh > > ___ > Okular-devel mailing list > Okular-devel@kde.org > https://mail.kde.org/mailman/listinfo/okular-devel > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 125623: This patch fix the searching of root items in the table of content treeview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125623/ --- (Updated oct. 14, 2015, 7:06 a.m.) Status -- This change has been discarded. Review request for Okular and Albert Astals Cid. Bugs: 350366 http://bugs.kde.org/show_bug.cgi?id=350366 Repository: okular Description --- This patch fix the searching of root items in the ktreeviewsearchline. Hence, filtering root items in table of content, reviews, bookmarks section. Diffs - ui/ktreeviewsearchline.cpp 4a987ec Diff: https://git.reviewboard.kde.org/r/125623/diff/ Testing --- Manually tested for some files. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 125623: This patch fix the searching of root items in the table of content treeview
> On Oct. 13, 2015, 9:20 p.m., Albert Astals Cid wrote: > > Hmmm, you sure this is needed? I thought i had fixed this problem with > > commit 5b62bc71d4b30b8d780dcc998fb78657081bf928 > > > > Which file are you using that doesn't work with current master and needs > > this patch? > > Saheb Preet Singh wrote: > I am sorry for this, I didn't noticed. Actually I fixed it some time back > and forgot to put on reviewboard. > > Albert Astals Cid wrote: > Can you confirm it works without the patch? yes, it works fine. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125623/#review86812 ------- On Oct. 13, 2015, 9 p.m., Saheb Preet Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125623/ > --- > > (Updated Oct. 13, 2015, 9 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 350366 > http://bugs.kde.org/show_bug.cgi?id=350366 > > > Repository: okular > > > Description > --- > > This patch fix the searching of root items in the ktreeviewsearchline. Hence, > filtering root items in table of content, reviews, bookmarks section. > > > Diffs > - > > ui/ktreeviewsearchline.cpp 4a987ec > > Diff: https://git.reviewboard.kde.org/r/125623/diff/ > > > Testing > --- > > Manually tested for some files. > > > Thanks, > > Saheb Preet Singh > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 125623: This patch fix the searching of root items in the table of content treeview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125623/ --- Review request for Okular and Albert Astals Cid. Bugs: 350366 http://bugs.kde.org/show_bug.cgi?id=350366 Repository: okular Description --- This patch fix the searching of root items in the ktreeviewsearchline. Hence, filtering root items in table of content, reviews, bookmarks section. Diffs - ui/ktreeviewsearchline.cpp 4a987ec Diff: https://git.reviewboard.kde.org/r/125623/diff/ Testing --- Manually tested for some files. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 125623: This patch fix the searching of root items in the table of content treeview
> On Oct. 13, 2015, 9:20 p.m., Albert Astals Cid wrote: > > Hmmm, you sure this is needed? I thought i had fixed this problem with > > commit 5b62bc71d4b30b8d780dcc998fb78657081bf928 > > > > Which file are you using that doesn't work with current master and needs > > this patch? I am sorry for this, I didn't noticed. Actually I fixed it some time back and forgot to put on reviewboard. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125623/#review86812 --- On Oct. 13, 2015, 9 p.m., Saheb Preet Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125623/ > --- > > (Updated Oct. 13, 2015, 9 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 350366 > http://bugs.kde.org/show_bug.cgi?id=350366 > > > Repository: okular > > > Description > --- > > This patch fix the searching of root items in the ktreeviewsearchline. Hence, > filtering root items in table of content, reviews, bookmarks section. > > > Diffs > - > > ui/ktreeviewsearchline.cpp 4a987ec > > Diff: https://git.reviewboard.kde.org/r/125623/diff/ > > > Testing > --- > > Manually tested for some files. > > > Thanks, > > Saheb Preet Singh > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 350366] New: Tree view search bar in left side bar is not searching root items of the tree view.
https://bugs.kde.org/show_bug.cgi?id=350366 Bug ID: 350366 Summary: Tree view search bar in left side bar is not searching root items of the tree view. Product: okular Version: unspecified Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: saheb.pr...@gmail.com The search bar on tree views( for table of contents, annotations etc ) on the left sidebar is not short lisiting the root items in the tree view on searching. For example, in this file http://www.publishers.org.uk/_resources/assets/attachment/full/0/2091.pdf if I search for Introduction, it doesn't show up. Ideally, it should shortlist it. Reproducible: Always Steps to Reproduce: 1. open http://www.publishers.org.uk/_resources/assets/attachment/full/0/2091.pdf 2. search for Introduction in the table of contents. Actual Results: Nothing shows up in table of content tree view. Expected Results: It should shortlist introduction in the table of content tree view. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated July 16, 2015, 11:03 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Changes --- Submitted with commit 48905cf16b3186ce813d766a77905c8260493480 by Albert Astals Cid on behalf of Saheb Preet Singh to branch master. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp d676069 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] GSOC 2015
Hi, Today, I added a search bar on the layers list. The searchbar is not searching appropriate results. I was stuck at this. I hope I will figure it out by tomorrow. Best, Saheb Preet Singh On 5/10/15, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 9 de maig de 2015, a les 21:48:32, saheb preet singh va escriure: Hi, Previously, I had done a small proof of concept for implementing the layers list in the left side bar. Okular was crashing on closing the document, for some reasons. Today, I was restructuring and properly implementing the list. I was able to populate the list in a list view and enable or disable the layers button depending on if they are present in the document. Also, I fixed the crashing of the okular in my previous code on closing document. Here is a screen shot of the work so far:- http://ctrlv.in/572212 Note:- Layers icon and some styling is still to be done. Check in oxygen/breeze icon sets, probably someone needed a layer-y icon at some point Now, I have some doubts. Firstly, where should I show my code. Should I post it on review board as a diff or should I wait for the contributor account on kde and commit push my code at regular intervals? As said, push to your own branch in the okular repo. Ideally it'd even make sense to have various branches per feature, since they seem to be quite isolated and probably won't need much dependencies between themselves. Secondly, I have implemented the layers view directly through subclass of QAbstractItemModel ( OptionalContentModel ) provided by the backend to render the view. Should I create a layers model as done in case of table of content model( TOCModel ) for abstraction between different backends or should I assume that each backend or its generator would return me some subclass of QAbstractItemModel? Assuming we'll have an QAbstractItemModel is ok, just make sure you document clearly the roles, etc. we expect from the model. Actually the Okular::DocumentSynopsis is a QDomDocument, it happens to be that XML was all the rage back when we wrote this in early 2000, not really the best of the ideas i'd say :D Cheers, Albert Best, Saheb Preet Singh On Fri, May 8, 2015 at 11:02 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 8 de maig de 2015, a les 13:46:52, saheb preet singh va escriure: Hello Everyone, I have just started writing my blog for my working experience with kde this summer. You can find the blog at http://sahebpreet-kde.blogspot.in/ Cool, you should add yourself to planetkde. Cheers, Albert Thanks, Saheb Preet Singh On Tue, May 5, 2015 at 12:04 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 4 de maig de 2015, a les 16:42:33, saheb preet singh va escriure: On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh va escriure: Hello Everyone, Hi! Thank you for accepting my proposal in GSOC 2015. Congrats, now let's make us both proud of the result :) I am really excited to contribute in kde and okular in the summer vacation this time. This is my first time participation in GSOC. My project is about adding tags, layers and linearization support in okular. My development environment is ready and I have been working on the okular code. Great :) I would like to know how should I proceed further and what should be my first steps in GSOC program? Choose one of the things and start working on it, on a branch in the repo and blog about it :) Should I create a new branch or use any existing? Create a new one. I will start blogging soon. I think layers is probably the easiest so i'd suggest starting there. I just tried to implement layers feature and was able to list the layers present in document in the left side bar. Although, I did it in a very adhoc way. We can discuss further on code structure and proper implementation. We should find a time to do an IRC meeting to kickstart on this. Does 18:00 UTC work for you? Any specific day of the week? Yes, 18:00 UTC is ok for me. Is thursday or friday ok for you? Friday is good :) Anyone else is obviously welcome. #okular channel on irc.freenode.net Cheers, Albert Thanks, Saheb Preet Singh Cheers, Albert Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman
Re: [Okular-devel] GSOC 2015
Hi, Previously, I had done a small proof of concept for implementing the layers list in the left side bar. Okular was crashing on closing the document, for some reasons. Today, I was restructuring and properly implementing the list. I was able to populate the list in a list view and enable or disable the layers button depending on if they are present in the document. Also, I fixed the crashing of the okular in my previous code on closing document. Here is a screen shot of the work so far:- http://ctrlv.in/572212 Note:- Layers icon and some styling is still to be done. Now, I have some doubts. Firstly, where should I show my code. Should I post it on review board as a diff or should I wait for the contributor account on kde and commit push my code at regular intervals? Secondly, I have implemented the layers view directly through subclass of QAbstractItemModel ( OptionalContentModel ) provided by the backend to render the view. Should I create a layers model as done in case of table of content model( TOCModel ) for abstraction between different backends or should I assume that each backend or its generator would return me some subclass of QAbstractItemModel? Best, Saheb Preet Singh On Fri, May 8, 2015 at 11:02 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 8 de maig de 2015, a les 13:46:52, saheb preet singh va escriure: Hello Everyone, I have just started writing my blog for my working experience with kde this summer. You can find the blog at http://sahebpreet-kde.blogspot.in/ Cool, you should add yourself to planetkde. Cheers, Albert Thanks, Saheb Preet Singh On Tue, May 5, 2015 at 12:04 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 4 de maig de 2015, a les 16:42:33, saheb preet singh va escriure: On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh va escriure: Hello Everyone, Hi! Thank you for accepting my proposal in GSOC 2015. Congrats, now let's make us both proud of the result :) I am really excited to contribute in kde and okular in the summer vacation this time. This is my first time participation in GSOC. My project is about adding tags, layers and linearization support in okular. My development environment is ready and I have been working on the okular code. Great :) I would like to know how should I proceed further and what should be my first steps in GSOC program? Choose one of the things and start working on it, on a branch in the repo and blog about it :) Should I create a new branch or use any existing? Create a new one. I will start blogging soon. I think layers is probably the easiest so i'd suggest starting there. I just tried to implement layers feature and was able to list the layers present in document in the left side bar. Although, I did it in a very adhoc way. We can discuss further on code structure and proper implementation. We should find a time to do an IRC meeting to kickstart on this. Does 18:00 UTC work for you? Any specific day of the week? Yes, 18:00 UTC is ok for me. Is thursday or friday ok for you? Friday is good :) Anyone else is obviously welcome. #okular channel on irc.freenode.net Cheers, Albert Thanks, Saheb Preet Singh Cheers, Albert Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] GSOC 2015
Hello Everyone, I have just started writing my blog for my working experience with kde this summer. You can find the blog at http://sahebpreet-kde.blogspot.in/ Thanks, Saheb Preet Singh On Tue, May 5, 2015 at 12:04 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 4 de maig de 2015, a les 16:42:33, saheb preet singh va escriure: On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh va escriure: Hello Everyone, Hi! Thank you for accepting my proposal in GSOC 2015. Congrats, now let's make us both proud of the result :) I am really excited to contribute in kde and okular in the summer vacation this time. This is my first time participation in GSOC. My project is about adding tags, layers and linearization support in okular. My development environment is ready and I have been working on the okular code. Great :) I would like to know how should I proceed further and what should be my first steps in GSOC program? Choose one of the things and start working on it, on a branch in the repo and blog about it :) Should I create a new branch or use any existing? Create a new one. I will start blogging soon. I think layers is probably the easiest so i'd suggest starting there. I just tried to implement layers feature and was able to list the layers present in document in the left side bar. Although, I did it in a very adhoc way. We can discuss further on code structure and proper implementation. We should find a time to do an IRC meeting to kickstart on this. Does 18:00 UTC work for you? Any specific day of the week? Yes, 18:00 UTC is ok for me. Is thursday or friday ok for you? Friday is good :) Anyone else is obviously welcome. #okular channel on irc.freenode.net Cheers, Albert Thanks, Saheb Preet Singh Cheers, Albert Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] GSOC 2015
On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh va escriure: Hello Everyone, Hi! Thank you for accepting my proposal in GSOC 2015. Congrats, now let's make us both proud of the result :) I am really excited to contribute in kde and okular in the summer vacation this time. This is my first time participation in GSOC. My project is about adding tags, layers and linearization support in okular. My development environment is ready and I have been working on the okular code. Great :) I would like to know how should I proceed further and what should be my first steps in GSOC program? Choose one of the things and start working on it, on a branch in the repo and blog about it :) Should I create a new branch or use any existing? I will start blogging soon. I think layers is probably the easiest so i'd suggest starting there. I just tried to implement layers feature and was able to list the layers present in document in the left side bar. Although, I did it in a very adhoc way. We can discuss further on code structure and proper implementation. We should find a time to do an IRC meeting to kickstart on this. Does 18:00 UTC work for you? Any specific day of the week? Yes, 18:00 UTC is ok for me. Is thursday or friday ok for you? Thanks, Saheb Preet Singh Cheers, Albert Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] GSOC 2015
On Fri, May 1, 2015 at 8:52 PM, Sahil Sehgal sahilsehgal1...@gmail.com wrote: Congratulations Saheb, Good luck for your Gsoc. Thanks Can you please share your Gsoc proposal. I am unable to share my proposal publicly on google melange site. Soon I will start writing a blog and will try to include my proposal there. I will post the link of the blog in this thread. Thanks, Saheb Best Wishes Sahil On Thu, Apr 30, 2015 at 3:11 PM, saheb preet singh saheb.pr...@gmail.com wrote: Hello Everyone, Thank you for accepting my proposal in GSOC 2015. I am really excited to contribute in kde and okular in the summer vacation this time. This is my first time participation in GSOC. My project is about adding tags, layers and linearization support in okular. My development environment is ready and I have been working on the okular code. I would like to know how should I proceed further and what should be my first steps in GSOC program? Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317073] Request to add fade transition to presentation mode
https://bugs.kde.org/show_bug.cgi?id=317073 --- Comment #14 from Saheb Preet Singh saheb.pr...@gmail.com --- (In reply to sahil from comment #13) Hi, I reviewed your review-board patch and it was really cool. Can you please tell if there is something left in this bug so that i can also contribute? The patch is near its commit. You can test the patch and find out if anything is not working properly or breaking some thing or if anything is missing in the transition. You can also re-implement the patch, if you can implement it in a better way. Moreover if this fade transition is successfully applied shall i move towards other transitions which are still to be implemented? Hmm, the transition is not patched successfully, yes you can implement the missing transitions. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated March 26, 2015, 12:31 p.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp d676069 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated March 16, 2015, 11:21 p.m.) Status -- This change has been marked as submitted. Review request for Okular and Albert Astals Cid. Changes --- Submitted with commit 1eafe4feb151c713e8f7747164348c25886480bf by Albert Astals Cid on behalf of Saheb Preet Singh to branch master. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - doc/index.docbook 3237849 part.h 594eb44 part.cpp 36438af shell/shell.h 224acfe shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 2dd8cf1 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated March 1, 2015, 2:36 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - doc/index.docbook 3237849 part.h 594eb44 part.cpp 36438af shell/shell.h 224acfe shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 2dd8cf1 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Dec. 15, 2014, 2:28 a.m., Albert Astals Cid wrote: This looks pretty solid now :) Two minor things: * You should add it to the manual, i.e. add something to doc/index.docbook * I'm not convinced of it's position on the menus. At the moment it's close to other fit things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty advanced/notcommon option) B) Put it at the end of the View menu in it's own group (i.e. with a separator). What do you think? Saheb Preet Singh wrote: Before deciding its position on menus I have a doubt. I reviewed the bug description and found this 'Zoom in fit window to page mode causes the whole window to magnify or shrink accordingly.' Should I work on implementing the movement of window on zoom in and zoom out ? Albert Astals Cid wrote: I honestly think that it's not needed. Saheb Preet Singh wrote: i think keeping it as a shortcut would be a good idea Albert Astals Cid wrote: Now we need to think of a default shortcut. Any suggestion? Saheb Preet Singh wrote: ctrl + E or ctrl + shift + F Albert Astals Cid wrote: ctrl + shift + F is obviously out of question since it's already used What's the rationale behind Ctrl+E? Saheb Preet Singh wrote: oh I am sorry for suggesting ctrl + shift + F. We can use something like ctrl + alt + F. I suggested ctrl + E as it is already being used in gimp for shrink wrap. Albert Astals Cid wrote: Hmmm, my gimp uses Ctrl+J ? Which gimp version do you use? Saheb Preet Singh wrote: oops sorry, it works with ctrl + j only. So can we use ctrl + j ? Albert Astals Cid wrote: Ctrl+J seems good, can you make it the patch before this wednesday that is the Feature Freeze for the next release? If not please tell and i'll try to find time to do it myself. i am really very sorry for the late reply. I tried my best to do it till wednesday but couldn't do it. It will take me two to three days more to create the final patch. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review72005 --- On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Dec. 15, 2014, 2:28 a.m., Albert Astals Cid wrote: This looks pretty solid now :) Two minor things: * You should add it to the manual, i.e. add something to doc/index.docbook * I'm not convinced of it's position on the menus. At the moment it's close to other fit things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty advanced/notcommon option) B) Put it at the end of the View menu in it's own group (i.e. with a separator). What do you think? Saheb Preet Singh wrote: Before deciding its position on menus I have a doubt. I reviewed the bug description and found this 'Zoom in fit window to page mode causes the whole window to magnify or shrink accordingly.' Should I work on implementing the movement of window on zoom in and zoom out ? Albert Astals Cid wrote: I honestly think that it's not needed. Saheb Preet Singh wrote: i think keeping it as a shortcut would be a good idea Albert Astals Cid wrote: Now we need to think of a default shortcut. Any suggestion? Saheb Preet Singh wrote: ctrl + E or ctrl + shift + F Albert Astals Cid wrote: ctrl + shift + F is obviously out of question since it's already used What's the rationale behind Ctrl+E? Saheb Preet Singh wrote: oh I am sorry for suggesting ctrl + shift + F. We can use something like ctrl + alt + F. I suggested ctrl + E as it is already being used in gimp for shrink wrap. Albert Astals Cid wrote: Hmmm, my gimp uses Ctrl+J ? Which gimp version do you use? oops sorry, it works with ctrl + j only. So can we use ctrl + j ? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review72005 --- On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Feb. 9, 2015, 11:42 a.m.) Review request for Okular. Changes --- Tried to implement it in the way discussed. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp d676069 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Dec. 15, 2014, 2:28 a.m., Albert Astals Cid wrote: This looks pretty solid now :) Two minor things: * You should add it to the manual, i.e. add something to doc/index.docbook * I'm not convinced of it's position on the menus. At the moment it's close to other fit things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty advanced/notcommon option) B) Put it at the end of the View menu in it's own group (i.e. with a separator). What do you think? Saheb Preet Singh wrote: Before deciding its position on menus I have a doubt. I reviewed the bug description and found this 'Zoom in fit window to page mode causes the whole window to magnify or shrink accordingly.' Should I work on implementing the movement of window on zoom in and zoom out ? Albert Astals Cid wrote: I honestly think that it's not needed. Saheb Preet Singh wrote: i think keeping it as a shortcut would be a good idea Albert Astals Cid wrote: Now we need to think of a default shortcut. Any suggestion? Saheb Preet Singh wrote: ctrl + E or ctrl + shift + F Albert Astals Cid wrote: ctrl + shift + F is obviously out of question since it's already used What's the rationale behind Ctrl+E? oh I am sorry for suggesting ctrl + shift + F. We can use something like ctrl + alt + F. I suggested ctrl + E as it is already being used in gimp for shrink wrap. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review72005 --- On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Dec. 15, 2014, 2:28 a.m., Albert Astals Cid wrote: This looks pretty solid now :) Two minor things: * You should add it to the manual, i.e. add something to doc/index.docbook * I'm not convinced of it's position on the menus. At the moment it's close to other fit things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty advanced/notcommon option) B) Put it at the end of the View menu in it's own group (i.e. with a separator). What do you think? Saheb Preet Singh wrote: Before deciding its position on menus I have a doubt. I reviewed the bug description and found this 'Zoom in fit window to page mode causes the whole window to magnify or shrink accordingly.' Should I work on implementing the movement of window on zoom in and zoom out ? Albert Astals Cid wrote: I honestly think that it's not needed. i think keeping it as a shortcut would be a good idea - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review72005 --- On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Dec. 15, 2014, 2:28 a.m., Albert Astals Cid wrote: This looks pretty solid now :) Two minor things: * You should add it to the manual, i.e. add something to doc/index.docbook * I'm not convinced of it's position on the menus. At the moment it's close to other fit things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty advanced/notcommon option) B) Put it at the end of the View menu in it's own group (i.e. with a separator). What do you think? Before deciding its position on menus I have a doubt. I reviewed the bug description and found this 'Zoom in fit window to page mode causes the whole window to magnify or shrink accordingly.' Should I work on implementing the movement of window on zoom in and zoom out ? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review72005 --- On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Dec. 26, 2014, 11:16 a.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp d676069 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Nov. 25, 2014, 12:47 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - shell/shell.cpp f7675fd ui/pageview.h a8adb2c ui/pageview.cpp 17e66f4 ui/sidebar.h cf5dfc6 ui/sidebar.cpp 0c722a9 part.h 594eb44 part.cpp 50a1b20 part.rc 60f86e5 shell/shell.h 224acfe Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Oct. 10, 2014, 4:54 p.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp d994647 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Sept. 22, 2014, 2 p.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Aug. 10, 2014, 2:54 a.m., Albert Astals Cid wrote: It still doesn't seem to work 100%, see the before and after images. Before: http://i.imgur.com/IhdXPe6.png After: http://i.imgur.com/tf0TMCS.png Can you reproduce this behaviour? Albert Astals Cid wrote: Saheb? Saheb Preet Singh wrote: Sorry for late reply. The previous mail got bounced somewhere. Yes I can reproduce the same thing. I tried to fix it initially but couldn't get it. I will try to fix it again though. Hi, I tried to figure out the problem and I found that the width of the left side list for table of contents, bookmarks etc. is resizing when I resize the main window. That is why the resizing is not doing perfect. I have tried to figure out if I could know in what ratios or how this left side panel resize with respect to the main window but couldn't make it work perfect. Any suggestions for making it work?? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review64131 --- On June 9, 2014, 3:50 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated June 9, 2014, 3:50 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - part.h 19c0d3e part.cpp d9f1682 part.rc 60f86e5 shell/shell.h f25b3d8 shell/shell.cpp 9ee422a ui/pageview.h a8adb2c ui/pageview.cpp 9073139 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Sept. 13, 2014, 11:49 a.m.) Review request for Okular. Changes --- I am really very sorry for the late reply. Now the transition is working smoother than before. Is it ok now? Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Aug. 10, 2014, 2:54 a.m., Albert Astals Cid wrote: It still doesn't seem to work 100%, see the before and after images. Before: http://i.imgur.com/IhdXPe6.png After: http://i.imgur.com/tf0TMCS.png Can you reproduce this behaviour? Albert Astals Cid wrote: Saheb? Sorry for late reply. The previous mail got bounced somewhere. Yes I can reproduce the same thing. I tried to fix it initially but couldn't get it. I will try to fix it again though. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review64131 --- On June 9, 2014, 3:50 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated June 9, 2014, 3:50 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - part.h 19c0d3e part.cpp d9f1682 part.rc 60f86e5 shell/shell.h f25b3d8 shell/shell.cpp 9ee422a ui/pageview.h a8adb2c ui/pageview.cpp 9073139 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated July 16, 2014, 1:12 p.m.) Review request for Okular. Changes --- Now the patch works fine. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing (updated) --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated July 16, 2014, 1:23 p.m.) Review request for Okular. Changes --- bug fix : No memory leaks now, added a variable instead of pointer. changed the pixmap back to the original one when changing the page, to render the correct pixmap in fade out transition when on first or last page. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
On July 15, 2014, 4:27 a.m., Albert Astals Cid wrote:
I'd say we're still leaking m_currentTransition sometimes, like for example
PresentationWidget::slotPrevPage has
if ( m_transitionTimer-isActive() )
{
m_transitionTimer-stop();
update();
}
so the transition step won't be called and m_currentTransition won't be
deleted. Isn't it easier if you just make it a member variable instead of a
pointer so we don't have to worry about it?
Fixed the above said issues.
Sir I also wanted to ask you something,
its commented in the code // implement missing transitions (a binary raster
engine needed here)
Am I implementing the feature in a right way ?? Is there any other better way
of doing it??
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
---
On July 16, 2014, 1:23 p.m., Saheb Preet Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/
---
(Updated July 16, 2014, 1:23 p.m.)
Review request for Okular.
Bugs: 317073
http://bugs.kde.org/show_bug.cgi?id=317073
Repository: okular
Description
---
implemented fade in and fade out transition for presentation mode in okular.
Diffs
-
conf/dlgpresentationbase.ui 31db693
conf/okular.kcfg f980989
ui/presentationwidget.h a99b8ce
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated June 20, 2014, 5:06 a.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - conf/dlgpresentationbase.ui 31db693 conf/okular.kcfg f980989 ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- It works fine on my system accept for the first time in case of fade out transition. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated June 9, 2014, 10:20 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - part.h 19c0d3e part.cpp d9f1682 part.rc 60f86e5 shell/shell.h f25b3d8 shell/shell.cpp 9ee422a ui/pageview.h a8adb2c ui/pageview.cpp 9073139 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated March 20, 2014, 9:55 a.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- It works fine on my system accept for the first time in case of fade out transition. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated March 18, 2014, 5:59 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - part.h 010e9de part.cpp 4ce7e28 part.rc 60f86e5 shell/shell.h 3b9aae0 shell/shell.cpp 01a9f1b ui/pageview.h 577b908 ui/pageview.cpp dd41994 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On March 12, 2014, 9:42 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 4925 https://git.reviewboard.kde.org/r/115283/diff/5/?file=245959#file245959line4925 please move the declaration inside the foreach If I would move pageItem inside foreach declaration then i might not be able to use it outside the foreach loop for getting the uncropped width and height. How should I go about that??? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review52845 --- On Feb. 25, 2014, 7:02 a.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Feb. 25, 2014, 7:02 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - part.h 6df835b part.cpp 283e91a part.rc 0b9cee5 shell/shell.h 3b9aae0 shell/shell.cpp 8226153 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Feb. 27, 2014, 9:02 a.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs (updated) - ui/presentationwidget.h a99b8ce ui/presentationwidget.cpp 4aaec2a Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- It works fine on my system accept for the first time in case of fade out transition. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Feb. 24, 2014, 10:30 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs - part.cpp 283e91a ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
On Feb. 9, 2014, 12:04 a.m., Albert Astals Cid wrote: ui/presentationwidget.cpp, line 2120 https://git.reviewboard.kde.org/r/115532/diff/1/?file=242327#file242327line2120 Do you think you could use m_transitionTimer instead of your own timer? m_transitionTimer is connected to the slot slotTransitionStep() which only updates some given rects over the screen. Fade transition requires the transparency of m_lastrendered pixmap to be changed instead. How should m_transitiontimer be used ?? We could get transition type in some class variable and can switch for the transition type in slottransitionstep for fade in, fade out or default. In default case the slot will behave as before. Should I go in this way?? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/#review49311 --- On Feb. 7, 2014, 8:55 a.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- (Updated Feb. 7, 2014, 8:55 a.m.) Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs - ui/presentationwidget.cpp 1b63e2f ui/presentationwidget.h c63e119 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- It works fine on my system accept for the first time in case of fade out transition. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Feb. 11, 2014, 10:51 a.m.) Review request for Okular. Changes --- The play/pause button does not depend on global settings now. The patch disables the button when advance slide is set in global settings. It disables the button as user should not be allowed to change the global settings from the widget. Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs (updated) - part.cpp 283e91a ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Feb. 11, 2014, 10:53 a.m.) Review request for Okular and Albert Astals Cid. Changes --- rebased the patch with current code. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - part.h 6df835b part.cpp 283e91a part.rc 0b9cee5 shell/shell.h 3b9aae0 shell/shell.cpp 8226153 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/ --- Review request for Okular. Bugs: 317073 http://bugs.kde.org/show_bug.cgi?id=317073 Repository: okular Description --- implemented fade in and fade out transition for presentation mode in okular. Diffs - ui/presentationwidget.cpp 1b63e2f ui/presentationwidget.h c63e119 Diff: https://git.reviewboard.kde.org/r/115532/diff/ Testing --- It works fine on my system accept for the first time in case of fade out transition. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 29, 2014, 8:29 a.m.) Review request for Okular. Changes --- I think playpause action should be declared in part.cpp as it is required to be added to action collection as with erase drawing action. The previous diff is crashing okular as the action was not added to the action collection previously. corrected the above stated issues. Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs (updated) - part.cpp 88e2c41 ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 28, 2014, 3:09 p.m.) Review request for Okular and Albert Astals Cid. Changes --- eliminated spaces from signals and slots. chained signal flow in part.cpp. disabled fit page to view when continuous mode is checked. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - part.h 4b3aafd part.cpp 88e2c41 part.rc 6b1f44e shell/shell.h c065c56 shell/shell.cpp 1708501 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 27, 2014, 8:21 a.m.) Review request for Okular and Albert Astals Cid. Changes --- fixed above stated issues. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - ui/pageview.cpp 65967bf shell/shell.cpp 1708501 ui/pageview.h 9c15af6 shell/shell.h c065c56 part.rc 6b1f44e part.h 4b3aafd part.cpp 88e2c41 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
On Jan. 24, 2014, 7:24 p.m., Albert Astals Cid wrote: I don't think there's any problem with resizing, i'd say it's only your math that is wrong int xOffset = pageViewSize.width() - pageSize.width(); int yOffset = pageViewSize.height() - pageSize.height(); resize( width() - xOffset, height() - yOffset ); seems to be what you should really be doing, it doesn't perfectly work, but it may just be because the sizes you're using are not the correct. Also I think this feature only makes sense when you're in non continuous view. Probably the arguments of resize function would be same in both cases ( in yours as well as mine ). width() - xOffset = width() - pageViewSize.width() + pageSize.width(), when xOffset = pageViewSize.width() - pageSize.width(); pageSize.width() + xOffset = width() - pageViewSize.width() + pageSize.width(), when xOffset = width() - pageViewSize.width(); same in the case of height. I changed the implementation as you have stated above. The feature is not working perfectly because the xOffset (width other than pageViewSize) is changing with window's size whereas here xOffset and yOffsets are assumed to be constant. This mostly happens when thumbnails or toc etc. are open. I can't find out a way in which I can get the final size of these side widgets when the window will be resized or some porportionality factor with which there width is changing with respect to the whole window. But the problem that I have stated above persists on my laptop. Steps to reproduce the problem :- == open okular and maximize the window. == change the zoom level, preferably very large from the current zoom level or very small. == select fit window to page option. Window will be restored but will not be resized. == If nothing happens then move the window and then again select fit window to page. Now the window will be resized, even if size of window is changed or the window is maximized. - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review48238 --- On Jan. 27, 2014, 8:21 a.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 27, 2014, 8:21 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - ui/pageview.cpp 65967bf shell/shell.cpp 1708501 ui/pageview.h 9c15af6 shell/shell.h c065c56 part.rc 6b1f44e part.h 4b3aafd part.cpp 88e2c41 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 27, 2014, 8:24 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - ui/pageview.cpp 65967bf shell/shell.cpp 1708501 ui/pageview.h 9c15af6 shell/shell.h c065c56 part.rc 6b1f44e part.h 4b3aafd part.cpp 88e2c41 Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 27, 2014, 9:41 a.m.) Review request for Okular. Changes --- updated the above issue Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs (updated) - ui/presentationwidget.cpp 1b63e2f ui/presentationwidget.h c63e119 Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
On Jan. 26, 2014, 4:42 p.m., Albert Astals Cid wrote: part.cpp, line 829 https://git.reviewboard.kde.org/r/115072/diff/2/?file=234778#file234778line829 What's this for? sorry i didn't noticed that - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/#review48302 --- On Jan. 27, 2014, 9:41 a.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 27, 2014, 9:41 a.m.) Review request for Okular. Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs - ui/presentationwidget.cpp 1b63e2f ui/presentationwidget.h c63e119 Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] About bug 326844
ok i uploaded the diff to review board :- https://git.reviewboard.kde.org/r/115283/ On Fri, Jan 24, 2014 at 5:10 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 22 de gener de 2014, a les 19:04:40, saheb preet singh va escriure: hi, Hi I was working on bug number 326844. https://bugs.kde.org/show_bug.cgi?id=326844 It was a feature request to resize the window to fit the current page size. I solved this bug up to some extent and was stuck in a small problem from last two three days. Here are some screenshot of what is happening. Maybe you can upload your diff to reviewboard so we can see it and try it ourselves? For me it's always easier to understand the problems someone are having if i can run the software and experience them myself. Cheers, Albert Before selecting resize window to fit page:- [image: Inline image 3] After selecting resize to fit page:- [image: Inline image 4] I am using the resize method for resizing the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when i change the zoom level of the current page, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Please guide me how should I solve this problem. Should I use such methods which don't appear to be clean. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317073] Request to add fade transition to presentation mode
https://bugs.kde.org/show_bug.cgi?id=317073 Saheb Preet Singh saheb.pr...@gmail.com changed: What|Removed |Added CC||saheb.pr...@gmail.com --- Comment #8 from Saheb Preet Singh saheb.pr...@gmail.com --- can I also try to solve this bug??? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- Review request for Okular and Albert Astals Cid. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs - part.h 4b3aafd part.cpp 88e2c41 part.rc 6b1f44e shell/shell.h c065c56 shell/shell.cpp 1708501 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 20, 2014, 8:11 a.m.) Review request for Okular. Changes --- There was a problem with the previous implementation, whenever a running presentation was exited the pause button was not changed back to play button, next time presentation was started. corrected the above issue Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs (updated) - part.cpp 88e2c41 ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 19, 2014, 7:15 p.m.) Review request for Okular. Changes --- Add the Okular group, remove Albert Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs - part.cpp 88e2c41 ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326844] Feature request: Include option to resize window to fit page
https://bugs.kde.org/show_bug.cgi?id=326844 --- Comment #11 from Saheb Preet Singh saheb.pr...@gmail.com --- (In reply to comment #10) The shell knows the current size of the part and also knows the total size of the window, so knowing the size the part wants to have should be able to determine what's the delta that has to add to account for menubar, etc, no? Yes, shell knows the current size of the part, but i think part also includes the width of the thumbnails, table of content etc. I used the viewport size of the pageview instead in part.cpp and it is working fine now window is resizing as desired. But now another problem, the page size i am using is retrieved from allpagesize() in document class, which returns the size of the pages when they are at 100% zoom level. Now, when the page is not zoomed to 100%, how should i adjust size ?? Is there any way of knowing the current zoom level??? (As per my research the current zoom level is stored in pageviewprivate class, which is private to pageview class). -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328125] Add play/pause button in Presentation Mode
https://bugs.kde.org/show_bug.cgi?id=328125 Saheb Preet Singh saheb.pr...@gmail.com changed: What|Removed |Added CC||saheb.pr...@gmail.com --- Comment #3 from Saheb Preet Singh saheb.pr...@gmail.com --- hi, i just tried to implement the button and its working now. Here is a short explanation of what i did :- Added a new action in part.cpp for play pause button. Enabled the action in presentationwidget.cpp and added it to the topBar. Finally connected the toggled signal to a new slot. In that new slot when the signal is toggled on m_nextPageTimer is started and its singleShot is set to false, so that it starts playing the page. when the signal is toggled off m_nextPageTimer is stopped and the singleShot is set to true. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328125] Add play/pause button in Presentation Mode
https://bugs.kde.org/show_bug.cgi?id=328125 --- Comment #4 from Saheb Preet Singh saheb.pr...@gmail.com --- (In reply to comment #3) hi, i just tried to implement the button and its working now. Here is a short explanation of what i did :- Added a new action in part.cpp for play pause button. Enabled the action in presentationwidget.cpp and added it to the topBar. Finally connected the toggled signal to a new slot. In that new slot when the signal is toggled on m_nextPageTimer is started and its singleShot is set to false, so that it starts playing the page. when the signal is toggled off m_nextPageTimer is stopped and the singleShot is set to true. Is it the correct way of implementation??? Also how will i get the play and pause button icon?? Sorry for the previous message, was posted incomplete by mistake. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 12:30 p.m.) Review request for Okular, Albert Astals Cid and Kevin Funk. Changes --- changed the detection of shift modifier by using == instead of Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs (updated) - ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
On Jan. 11, 2014, 3:03 p.m., Albert Astals Cid wrote: ui/searchlineedit.cpp, line 194 https://git.reviewboard.kde.org/r/114754/diff/2/?file=229019#file229019line194 I was wondering if we should use == here instead of , i.e. should Ctrol+Shift+Enter do a prev or next search? Thanks for replying. sorry for the silly mistake corrected the implementation - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review47191 --- On Jan. 12, 2014, 12:30 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 12:30 p.m.) Review request for Okular, Albert Astals Cid and Kevin Funk. Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs - ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 5:29 p.m.) Status -- This change has been marked as submitted. Review request for Okular, Albert Astals Cid and Kevin Funk. Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs - ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
On Jan. 12, 2014, 5:28 p.m., Albert Astals Cid wrote: Ok, this looks good, i'll commit it. Note the spacing is totally wrong and i'll fix it before committing, please in the future make sure that patches conform to the spacing styling used in the file you are editing. ok i will take care of the spacing in future. Thanks for guiding me - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review47260 --- On Jan. 12, 2014, 5:29 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 5:29 p.m.) Review request for Okular, Albert Astals Cid and Kevin Funk. Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs - ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326844] Feature request: Include option to resize window to fit page
https://bugs.kde.org/show_bug.cgi?id=326844 --- Comment #7 from Saheb Preet Singh saheb.pr...@gmail.com --- (In reply to comment #6) (In reply to comment #5) i need to know which files or classes are related to adjusting the size of the main window or more precisely how to resize the window? Have you done any research? Yes, as per my research shell is the main element that appears is shell which in turn loads okular part plugin to draw various other things like some menu is this research correct??? if it is correct then the main thing to be done in this bug is to insert an option in the view menu bar for resizing the window to the size of the page and to resize the window which can be done by resizing shell as it inherits KParts :: MainWindow as per the size of the page. The first part can be done in PageView::setupViewerActions method by making corresponding signal and slot in the PageView class. For the second part the slot which will catch the above signal have to resize the window. Now the question is where the slot will implement the resizing functionality??? (as the resize to page fit and page width functionality is implemented after a series of function calls) Please guide me if i am wrong somewhere -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 2, 2014, 1:58 p.m.) Review request for Okular, Albert Astals Cid and Kevin Funk. Changes --- Changed the implementation of the return + shift key event using slot return pressed Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs (updated) - ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
On Dec. 31, 2013, 2:53 p.m., Albert Astals Cid wrote: any reason you've implemented the custom key event handler instead of implementing it in slotReturnPressed (as it seems to me that shit+return also invokes it?) yes slotReturnPressed tracks shift+return but is there any way of checking whether the shift is pressed at that time or not??? - Saheb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review46501 --- On Dec. 31, 2013, 2:19 p.m., Saheb Preet Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Dec. 31, 2013, 2:19 p.m.) Review request for Okular, Albert Astals Cid and Kevin Funk. Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs - ui/searchlineedit.h 63ff496 ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326844] Feature request: Include option to resize window to fit page
https://bugs.kde.org/show_bug.cgi?id=326844 Saheb Preet Singh saheb.pr...@gmail.com changed: What|Removed |Added CC||saheb.pr...@gmail.com --- Comment #5 from Saheb Preet Singh saheb.pr...@gmail.com --- hi, i am also new to kde. Can any body help me in solving this bug?? i need to know which files or classes are related to adjusting the size of the main window or more precisely how to resize the window? since the code also contains qml and i am new to it so i am not getting the main class which controls the view of the application -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- Review request for Okular, Albert Astals Cid and Kevin Funk. Bugs: 328576 http://bugs.kde.org/show_bug.cgi?id=328576 Repository: okular Description --- okular do not have a shortcut for searching previous word using shift + enter Added a key event listener to the SearchLineEdit class for shift+return. Diffs - ui/searchlineedit.h 63ff496 ui/searchlineedit.cpp 31be8fb Diff: https://git.reviewboard.kde.org/r/114754/diff/ Testing --- Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328576] Add keyboard shortcut for 'search previous' action: Shift+Enter
https://bugs.kde.org/show_bug.cgi?id=328576 --- Comment #2 from Saheb Preet Singh saheb.pr...@gmail.com --- Created attachment 84341 -- https://bugs.kde.org/attachment.cgi?id=84341action=edit proposed patch The attached patch applies to the file ui/searchlineedit.cpp and ui/searchlineedit.h Added a key event listener to the SearchLineEdit for shift+return. i am new to kde please guide me if something is wrong -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327376] Create straight freehand line by holding shift key
https://bugs.kde.org/show_bug.cgi?id=327376 Saheb Preet Singh saheb.pr...@gmail.com changed: What|Removed |Added CC||saheb.pr...@gmail.com --- Comment #1 from Saheb Preet Singh saheb.pr...@gmail.com --- hi, i am new to kde and want some help in solving this bug. i am not clear about creating a freehand line by holding the shift key. I tried in scribus and unable to create a freehand line by holding shift key. Please guide me -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
