This revision was automatically updated to reflect the committed changes.
Closed by commit R223:600e72100b13: Remove the internal file navigation from
the global drawer (authored by apol).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12884?vs=34335=34371
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12884
To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid
apol updated this revision to Diff 34335.
apol added a comment.
Remove hardcoded path
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12884?vs=34297=34335
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12884
AFFECTED FILES
aacid added inline comments.
INLINE COMMENTS
> main.qml:33
> +titleIcon: "okular"
> +bannerImageSource:
> "file:///home/apol/devel/kde5/share/wallpapers/Next/contents/images/1920x1080.png"
> +
That path is WHAAAT
REPOSITORY
R223 Okular
REVISION DETAIL
apol marked an inline comment as done.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D12884
To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid
apol updated this revision to Diff 34297.
apol added a comment.
Don't add logic in core/ just in case
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12884?vs=34168=34297
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12884
AFFECTED FILES
apol added inline comments.
INLINE COMMENTS
> aacid wrote in document.cpp:2362
> I don't think it's a good idea changing the behaviour, can't you fix the
> mobile app to do the right thing?
Sure, I did it because it feels like broken API. It just complains and doesn't
do anything when you
aacid added inline comments.
INLINE COMMENTS
> document.cpp:2362
> {
> +if (d->m_generator)
> +closeDocument();
I don't think it's a good idea changing the behaviour, can't you fix the mobile
app to do the right thing?
REPOSITORY
R223 Okular
REVISION DETAIL
apol created this revision.
apol added reviewers: Okular, mart, aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
apol requested review of this revision.
REVISION SUMMARY
Instead include an "open" item.
TEST PLAN
opened a file
