D15205: Support setting font color for typewriter annotation

tobiasdeiminger marked 2 inline comments as done. tobiasdeiminger added a comment. Should be ready to land. I'll push tomorrow, time frame for last objections is open now ;-) REPOSITORY R223 Okular BRANCH typewriter_td_fontcolor (branched from master) REVISION DETAIL

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 42798. tobiasdeiminger added a comment. More review fixes - Refine doxygen comments on TextAnnotation::textColor and TextAnnotation::setTextColor - Colorize toolbar icon in with text color instead of black - Remove accidential whitespace

D15205: Support setting font color for typewriter annotation

tobiasdeiminger added a comment. In D15205#335752 , @sander wrote: > I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue. Thanks for reviewing. > I'd

D15205: Support setting font color for typewriter annotation

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH typewriter_td_fontcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger, sander Cc: kde-doc-english, sander, okular-devel, ngraham,

D15205: Support setting font color for typewriter annotation

tobiasdeiminger added inline comments. INLINE COMMENTS > sander wrote in annotationwidgets.cpp:315 > I think these whitespace changes should be in a separate patch (if they are > desired at all). Desired, because I did them wrong in the first typewriter commit. To be honest, I'd find an extra

D15205: Support setting font color for typewriter annotation

sander added inline comments. INLINE COMMENTS > annotationwidgets.cpp:223 > } > - > QWidget * styleWidget = createStyleWidget(); Why this whitespace change? > annotationwidgets.cpp:315 > -addTextAlignComboBox(widget, innerlay); > -addWidthSpinBox(widget, innerlay); > } I

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 42687. tobiasdeiminger marked an inline comment as done. tobiasdeiminger added a comment. Really rebase on master REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15205?vs=42457=42687 BRANCH

D15205: Support setting font color for typewriter annotation

sander added a comment. Are you sure you rebased this on the current master? The diff still seems to contain D15204 , which has already been pushed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc:

D15205: Support setting font color for typewriter annotation

tobiasdeiminger edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc: kde-doc-english, sander, okular-devel, ngraham, skadinna, aacid

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 42457. tobiasdeiminger added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Rebase on master. Some review fixes. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D15205: Support setting font color for typewriter annotation

tobiasdeiminger added inline comments. INLINE COMMENTS > editannottooldialog.cpp:275 > engineElement.setAttribute( QStringLiteral("type"), > QStringLiteral("PickPoint") ); > -engineElement.setAttribute( QStringLiteral("color"), > QStringLiteral("#00") ); > +

D15205: Support setting font color for typewriter annotation

tobiasdeiminger added a dependent revision: D15347: Modify CloseDialogHelper in parttest. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc: sander, okular-devel, ngraham, aacid

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 41199. tobiasdeiminger added a comment. No real changes, just follow rebase of parent revision D15204 . REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15205?vs=41028=41199

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 41028. tobiasdeiminger added a comment. Remove reintroduced whitespace change. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15205?vs=41025=41028 BRANCH typewriter_td_fontcolor (branched from master)

D15205: Support setting font color for typewriter annotation

tobiasdeiminger marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc: sander, okular-devel, ngraham, aacid

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 41025. tobiasdeiminger added a comment. Rebase on D15204 . Check for poppler 0.69. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15205?vs=40821=41025 BRANCH

D15205: Support setting font color for typewriter annotation

sander added inline comments. INLINE COMMENTS > CMakeLists.txt:108 > +} > +" HAVE_POPPLER_0_67) > + This will have to be at least 0.69... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc: sander, okular-devel, ngraham, aacid

D15205: Support setting font color for typewriter annotation

tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY 2nd part of Dileep Sankhlas GSoC 18 project. The original work is in D13203 ,