D18730: Use breeze icons for search providers

2019-02-05 Thread Shubham 
shubham abandoned this revision.
shubham added a comment.


  Abandoned in favour of D18761 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Check out D18730 
  
  Then you can put `Icon=foo` in the respective search provider desktop file

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Shubham 
shubham added a comment.


  @broulik Adding icons to the .desktop files does not work, I tried.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a 
proper icon.
  
  https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps 
needs to have icons added

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Nathaniel Graham 
ngraham added a comment.


  In D18730#405089 , @shubham wrote:
  
  > @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.
  
  
  That's probably where we should fix this, then.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham added a comment.


  @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Nathaniel Graham 
ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, while this is a visual improvement for those particular search providers 
in Okular, it feels like the data model itself should be responsible for 
knowing its own icon, or a Breeze-friendly version of it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham added a reviewer: VDG.
shubham added a project: VDG.
shubham added a subscriber: VDG.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham updated this revision to Diff 50864.
shubham added a comment.


  Add new line

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18730?vs=50863=50864

BRANCH
  clipboard

REVISION DETAIL
  https://phabricator.kde.org/D18730

AFFECTED FILES
  ui/pageview.cpp

To: shubham, ngraham
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham updated this revision to Diff 50863.
shubham added a comment.


  Remove comment

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18730?vs=50862=50863

BRANCH
  clipboard

REVISION DETAIL
  https://phabricator.kde.org/D18730

AFFECTED FILES
  ui/pageview.cpp

To: shubham, ngraham
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18730: Use breeze icons for search providers

2019-02-04 Thread Shubham 
shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Previously all the search providers had same default icon, now all have their 
own Breeze icon

TEST PLAN
  1. Open any document
  2. Choose Selection and select some area of the document
  3. Context menu appears. Go on search for ...
  4. New icons

REPOSITORY
  R223 Okular

BRANCH
  clipboard

REVISION DETAIL
  https://phabricator.kde.org/D18730

AFFECTED FILES
  ui/pageview.cpp

To: shubham, ngraham
Cc: okular-devel, tfella, ngraham, darcyshen, aacid