D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Albert Astals Cid 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:a738c98c2082: Add information about substituting font 
into properties dialog (authored by jgrulich, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23027?vs=63395=63454#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63395=63454

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Albert Astals Cid 
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks, good, i'll commit a slightly modified version that checks 
substituteName != fontname too, wanted to save us all the roundtrip

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Jan Grulich 
jgrulich updated this revision to Diff 63395.
jgrulich added a comment.


  Better use of i18nc API

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63393=63395

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Jan Grulich 
jgrulich updated this revision to Diff 63393.
jgrulich added a comment.


  Use translatable string

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63387=63393

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-09 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> propertiesdialog.cpp:361
> +if (m_fonts.at( index.row() ).embedType() == 
> Okular::FontInfo::NotEmbedded && !substituteName.isEmpty() && 
> !fontname.isEmpty()) {
> +return QString("%1 (substituting with 
> %2)").arg(fontname).arg(substituteName);
> +}

i18n please, with a context explaining the message

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-08 Thread Jan Grulich 
jgrulich updated this revision to Diff 63387.
jgrulich added a comment.


  Move information about substituting fonto into the first column

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63347=63387

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-08 Thread Nathaniel Graham 
ngraham added a comment.


  I agree, yeah.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-08 Thread Albert Astals Cid 
aacid added a comment.


  I don't think it makes sense to have it in the third column, personally i 
think it'd make more sense in the first
  
  F7179370: imatge.png 
  
  I.e. first column is about names, third column is about paths.
  
  So "Arial (subsituting with NimbusSans-Regular)" makes more sense to me than 
"/path/to/nimsussansregular (subsituting with NimbusSans-Regular)"
  
  What do you think?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23027: Add information about substituting font into properties dialog

2019-08-08 Thread Jan Grulich 
jgrulich created this revision.
jgrulich added a reviewer: aacid.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
jgrulich requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid