D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga added a comment.


  In D23037#509685 , @aacid wrote:
  
  > Got it. You could have used my non expired key 
http://hkps.pool.sks-keyservers.net/pks/lookup?op=get=0xCA262C6C83DE4D2FB28A332A3A6A4DB839EAA6D7
  
  
  Strange, GPG still marks the key as expired (on 2019-07-31). From this 
keyserver , I see that the key should expire on 
2019-09-04, and I tried the following commands, but it still does not work:
  `gpg --keyserver hkp://pool.sks-keyservers.net --recv-keys 3A6A4DB839EAA6D7`
  `gpg --import /tmp/aacid_new.asc` (I manually copied the PGP PUBLIC KEY BLOCK 
from the link you provided and saved it as a file)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Albert Astals Cid]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:5a8d21d597e0: Add support for cb7 comic book archives 
(authored by Natsumi Higa c822c4f23bca1ea6faac79e2@mail.在线, committed 
by aacid).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23037?vs=63394=63465

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Albert Astals Cid]

aacid added a comment.


  Git it. You could have used my non expired key 
http://hkps.pool.sks-keyservers.net/pks/lookup?op=get=0xCA262C6C83DE4D2FB28A332A3A6A4DB839EAA6D7

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga added a comment.


  @aacid Please check your email. I noticed that your public key 
(0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my 
message anyway.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Albert Astals Cid]

aacid added a comment.


  In D23037#509088 , @broulik wrote:
  
  > Works well, thanks a lot! Let's wait for Okular maintainer approval.
  
  
  If by maintainer you mean me, the code looks sane.
  
  Now nhiga, can you give us your full name and email for git history?

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga added a subscriber: broulik.
nhiga added a comment.


  Sorry for the mess, I accidentally changed the status and subscriber list.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga reclaimed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Pino Toscano]

pino added a comment.


  why did you abandon this?

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga removed subscribers: broulik, pino.
nhiga abandoned this revision.
nhiga marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid, broulik, pino

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga updated this revision to Diff 63394.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23037?vs=63392=63394

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Kai Uwe Broulik]

broulik added a comment.


  Works well, thanks a lot! Let's wait for Okular maintainer approval.

INLINE COMMENTS

> okularApplication_comicbook.desktop:168
>  NoDisplay=true
> -X-KDE-Keywords=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ar]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bg]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bs]=cbr, cbz, cbt, Comic Book,stripovi
> -X-KDE-Keywords[ca]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ca@valencia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[cs]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[da]=cbr,cbz,cbt,Comic Book
> -X-KDE-Keywords[de]=cbr, cbz, cbt, Comic-Book
> -X-KDE-Keywords[el]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[en_GB]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[es]=cbr, cbz, cbt, libro de cómic
> -X-KDE-Keywords[et]=cbr, cbz, cbt, Comic Book, koomiks
> -X-KDE-Keywords[eu]=cbr, cbz, cbt, komiki-liburua
> -X-KDE-Keywords[fi]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[fr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ga]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[gl]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[hu]=cbr, cbz, cbt, Képregény
> -X-KDE-Keywords[ia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[is]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[it]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ja]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[kk]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[km]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ko]=cbr, cbz, cbt, Comic Book,만화책
> -X-KDE-Keywords[lt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[lv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[mr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[nb]=cbr, cbz, cbt, tegneserie
> -X-KDE-Keywords[nds]=cbr, cbz, cbt, Comicbook
> -X-KDE-Keywords[nl]=cbr, cbz, cbt, Stripverhaal
> -X-KDE-Keywords[nn]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pa]=cbr, cbz, cbt, ਕਾਮਿਕ ਬੁੱਕ
> -X-KDE-Keywords[pl]=cbr, cbz, cbt, Komiks
> -X-KDE-Keywords[pt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pt_BR]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ro]=cbr, cbz, cbt, benzi desenate, comic
> -X-KDE-Keywords[ru]=cbr, cbz, cbt, Comic Book, комикс
> -X-KDE-Keywords[sk]=cbr, cbz, cbt, Comic Book, Kniha komiksov
> -X-KDE-Keywords[sl]=cbr, cbz, cbt, strip
> -X-KDE-Keywords[sr]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavian]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavianlatin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sr@latin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[tr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[uk]=cbr,cbz,cbt,Comic Book,комікс
> -X-KDE-Keywords[x-test]=xxcbrxx,xx cbzxx,xx cbtxx,xx Comic Bookxx
> -X-KDE-Keywords[zh_CN]=cbr, cbz, cbt, Comic Book,漫画书,漫画,连环画
> -X-KDE-Keywords[zh_TW]=cbr, cbz, cbt, Comic Book
> +X-KDE-Keywords=cbr, cbz, cbt, cb7, Comic Book
> +X-KDE-Keywords[ar]=cbr, cbz, cbt, cb7, Comic Book

Yes, please only change the untranslated key (the ones without `[language]`), 
the rest is taken care by a script :)

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga updated this revision to Diff 63392.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23037?vs=63385=63392

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular, aacid
Cc: pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Pino Toscano]

pino added a comment.


  Please do **not** manually change translated keys in desktop files: there is 
an automatic system that takes care of them.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Nathaniel Graham]

ngraham added a reviewer: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: Okular.
nhiga added a project: Okular.
nhiga requested review of this revision.

TEST PLAN
  Open a cb7 file (e.g. Attachment 122002 
 from Bug 410696 
) using Okular and see if it works.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid