emateli abandoned this revision.
emateli added a comment.
Resolved by author
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular, aacid
Cc: aacid
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
Please close this, i fixed it correctly in
https://cgit.kde.org/okular.git/commit/?h=Applications/17.04=3b5f19fd9d67b49a7009b5810c5dd4ecb1a7cede
REPOSITORY
R223 Okular
REVISION
aacid added a comment.
the bug is actually in Shell::showEvent
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular
Cc: aacid
emateli changed the visibility from "All Users" to "Public (No Login Required)".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular
Cc: aacid
emateli changed the visibility from "Public (No Login Required)" to "All Users".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular
Cc: aacid
emateli added a comment.
I can see that the source you linked explicitly makes it checked, but If you
inspect the state just before the `if` execution you'd see that it actually is
not checked. Anyhow, if KStandartAction is supposed to handle this, then I
guess the bug(if any) might be
aacid added a comment.
Hmmm, now you're saying something that doesn't make sense to me.
I wrote the code that hides the Show Menu Bar action and it explicitily sets
the action as checked
https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n122
Which frameworks
emateli added a comment.
As far as I can tell from the source it's not Okular that it's doing the
hiding of that specific action, but rather the underlying framework apparently.
The action is visible again if you explicitly call `setVisible(true)` but as
expected, it does nothing when
aacid added a comment.
In https://phabricator.kde.org/D6185#116491, @emateli wrote:
> In https://phabricator.kde.org/D6185#116489, @aacid wrote:
>
> > I don't agree with this patch, the global menu bar should not be setting
actions to invisible, why is it doing that?
> >
> > I
emateli added a comment.
In https://phabricator.kde.org/D6185#116489, @aacid wrote:
> I don't agree with this patch, the global menu bar should not be setting
actions to invisible, why is it doing that?
>
> I think the bug is on their side not in Okular side
It kind of makes
aacid added a comment.
I don't agree with this patch, the global menu bar should not be setting
actions to invisible, why is it doing that?
I think the bug is on their side not in Okular side
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli,
emateli created this revision.
emateli added a project: Okular.
REVISION SUMMARY
Okular currently has a minor bug when using menubar style in the title bar or
application menu widget.
The bug: If you right click on Okular's document UI you will be shown an
empty "Tools" separator entry.
12 matches
Mail list logo