aacid abandoned this revision.
aacid added a comment.
Got in as
https://commits.kde.org/okular/a6aea956081e8faac2484ab2283a5ab50f9e0bbe
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7495
To: aacid
Cc: rkflx, #okular, aacid
rkflx added a comment.
Yay for reviews finding problems before users do \o/
> majorly unchanged for years, and if someone breaks it, well it'll break and
we'll fix it.
If we can choose between a good and an improved solution, I'd say we should
always pick the latter. Maybe I should
aacid added a comment.
I shouldn't have really posted this for review, that's why i get for trying
to get people to review my code
Yes, the early return is a bit of a problem. But the slotDoFileDirty function
has been majorly unchanged for years, and if someone breaks it, well it'll
rkflx added a comment.
Good catch, I stumbled upon this bug before. This even prevents segfaults on
exit.
However, I think there's a potentially costly maintainability risk: When
someone wants to change some code in slotDoFileDirty(), it's quite easy to
forget resetting your new bool,
aacid created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
If you press and hold https://phabricator.kde.org/F5 we try to reload
multiple times, which isn't a nice idea, let's finish one before starting the
