simgunz added a comment.
Just tested again with my solution on top of sander one and the bottom border
disappears, but not the upper one. Strange, I didn't remember this effect when
I tested it months ago.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To:
simgunz added a comment.
I arrive a little late, but testing Okular today I noticed a minor bug with
your solution. If you slowly scroll the page by dragging it with the browse
tool the upper/lower dark border are not drawn sometimes when the word is at
the border of the page. See bug
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:004efa70e4a7: Draw a dark rectangle around highlighted
search results (authored by sander, committed by aacid).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7662?vs=21180=34440#toc
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
That is a fix, not the ideal fix, now that i've had time to look at the
problem, the problem is.
Basically that we're writting in the "buffered" area of the painter, which
means we
simgunz added a comment.
Ok, thanks for testing again. I re-tried your patch with the latest master
(just to check that there weren't modifications that solved the problem) and I
still can reproduce the error. With my modification it goes away. So let's
wait for aacid to review the diff.
sander added a comment.
I tried, but I still cannot reproduce it. I do see the spurious lines very
very briefly when scrolling the hightlighted area into the viewport, but they
are always removed.
Still, I like your modification from Feb 25, because I don't think that the
border
simgunz added a comment.
Have you tried also what I suggested to reproduce it? i.e. Position an
highlighted word that match the search at the top boundary of the view so that
it is half visible and then scroll to show it completely. (Just to confirm this
is not reproducible)
REPOSITORY
sander added a comment.
@simgunz , I can't. Remember that I could never reproduce the artifacts that
Albert is seeing. Therefore I cannot test whether your idea fixes them.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: okular-devel,
simgunz added a comment.
Restricted Application added a subscriber: okular-devel.
@sander Have you had the time to try the fix I suggested?
I would like to complete this feature, but we first need to figure out if
what I propose does not break something else (possible).
REPOSITORY
simgunz added a comment.
Changing line 406
`QRect highlightRect = r.geometry( scaledWidth, scaledHeight ).translated(
-scaledCrop.topLeft() ).intersected( limits );`
to
`QRect highlightRect = r.geometry( scaledWidth, scaledHeight ).translated(
-scaledCrop.topLeft() );`
simgunz added a comment.
The artifacts are caused by the fact that the highlight rectangle is drawn
"inside the 'limits' paint region". When an highlight is only partially shown
because it is at the top/bottom edges of the window, the border rectangle is
drawn across the highlight
aacid added a comment.
leave it around i'll try to have a look somewhen/sometime or maybe someone
else picks it up.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: cfeck, aacid, ngraham
sander added a comment.
Thanks for testing. However, I don't really know what do to now. Given that
I am not very attached to this patch I might simply abandon it.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: cfeck, aacid, ngraham
aacid added a comment.
Doesn't help, i'd even say it makes it a bit worse?
https://i.imgur.com/z1uJ1Jf.png
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: cfeck, aacid, ngraham
sander added a comment.
I still cannot reproduce Albert's problems locally, but after reading
Christoph's link (thanks!) I found out that I can move the upper left corner of
the border one pixel towards the lower right without uncovering the yellow
rectangle. Please somebody test whether
sander updated this revision to Diff 21180.
sander added a comment.
Move the top left corner of the dark border one pixel towards the lower right.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7662?vs=19101=21180
REVISION DETAIL
ngraham added a comment.
Any progress on this?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: cfeck, aacid, ngraham
cfeck added a comment.
See http://doc.qt.io/qt-5/coordsys.html for differences in coordinate system
between aliased rectangles and anti-aliased rectangles.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: cfeck, aacid, ngraham
aacid added a comment.
In https://phabricator.kde.org/D7662#143055, @sander wrote:
> > This applies to all highlights, i.e. text selection too, are you sure we
want that?
>
> Are you sure we don't have that anyway? I get a darker-blue rectangle
around text selections even without
ngraham edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: aacid, ngraham
aacid added a comment.
This applies to all highlights, i.e. text selection too, are you sure we want
that?
There's something weird going on with the drawing, i can easily get a bad
state, see http://i.imgur.com/wDAQlcP.png which is
https://ev.kde.org/reports/2017-en.pdf having searched
ngraham edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7662
To: sander, #okular
Cc: ngraham, aacid
sander created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
This makes it easier to distinguish them from text with a 'highlight'
annotation.
This fixes
https://bugs.kde.org/show_bug.cgi?id=355043
REPOSITORY
R223 Okular
REVISION DETAIL
23 matches
Mail list logo
