Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103593 --- generators/poppler/generator_pdf.cpp (line 1086)

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/ --- (Updated Aug. 10, 2017, 3:32 p.m.) Status -- This change has been

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
> On Aug. 9, 2017, 9:19 p.m., Albert Astals Cid wrote: > > Ok, you're the printing maintainer now ;) > > > > Good luck! > > > > P.S: I can still try to review your patches if you want :) Thanks. I still need lots of help. - Oliver

D7241: Search for Kirigami

2017-08-10 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Okular. REVISION SUMMARY Makes it a bit more obvious that Kirigami is needed at runtime. TEST PLAN Show a nice status message REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL

D7241: Search for Kirigami

2017-08-10 Thread Albert Astals Cid
aacid resigned from this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7241 To: heikobecker, #okular, aacid Cc: aacid

D7241: Search for Kirigami

2017-08-10 Thread Albert Astals Cid
aacid edited reviewers, added: mart; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7241 To: heikobecker, #okular, mart Cc: aacid

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
> On Aug. 10, 2017, 3:53 p.m., Christoph Feck wrote: > > generators/poppler/generator_pdf.cpp, line 1086 > > > > > > Coding style issues: > > - there is a space after '(' but no space before ')' > > -

[okular] [Bug 383386] New: Show progress bar while printing to pdf

2017-08-10 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=383386 Bug ID: 383386 Summary: Show progress bar while printing to pdf Product: okular Version: 1.1.3 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED

Re: Review Request 130219: Enable background color to be changed from settings

2017-08-10 Thread Albert Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/ --- (Updated Aug. 11, 2017, 2:50 a.m.) Review request for Okular.

Re: Review Request 130219: Enable background color to be changed from settings

2017-08-10 Thread Albert Freeman
> On Aug. 9, 2017, 6:24 p.m., Albert Astals Cid wrote: > > Thanks for contributing to Okular :) > > > > Why would you need a different background color? I personally much prefer black as a background color. - Albert --- This is an