Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
> On Aug. 10, 2017, 3:53 p.m., Christoph Feck wrote: > > generators/poppler/generator_pdf.cpp, line 1086 > > > > > > Coding style issues: > > - there is a space after '(' but no space before ')' > > -

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103593 --- generators/poppler/generator_pdf.cpp (line 1086)

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/ --- (Updated Aug. 10, 2017, 3:32 p.m.) Status -- This change has been

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-10 Thread Oliver Sander
> On Aug. 9, 2017, 9:19 p.m., Albert Astals Cid wrote: > > Ok, you're the printing maintainer now ;) > > > > Good luck! > > > > P.S: I can still try to review your patches if you want :) Thanks. I still need lots of help. - Oliver

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103584 --- Ship it! Ok, you're the printing maintainer now ;) Good

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/ --- (Updated Aug. 9, 2017, 8:58 p.m.) Review request for Okular. Changes

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Albert Astals Cid
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-08 Thread Albert Astals Cid
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-08 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-07 Thread Albert Astals Cid
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-06 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? Yes I tried that, and it looks very good. It looks so good I wasn't even able

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103569 --- Rasterizing usually makes stuff look quite bad (because the