dileepsankhla marked an inline comment as done. dileepsankhla added a comment.
In D11051#222205 <https://phabricator.kde.org/D11051#222205>, @aacid wrote: > Also i'm not convinced it's a good idea to save the settings in sidebar.cpp but read them in part.cpp, seems a bit asymmetrical, can you explain your reasoning for it? Initially, I thought of reading and saving the settings in `part.cpp` but I can't access `m_sidebar` as to save its last state inside the destructor `Part::~Part` and it gives me segfault. Hence I am saving them in `Sidebar::~Sidebar`. > Do you think you can give it a try at adding an auto test for this? Sure, let me know your thoughts on where to save the settings and then I will try to write the auto test for this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular Cc: aacid, sander, #okular, michaelweghorn, ngraham
