D11597: Add test for visibility changes

2018-04-23 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:7eb72911f8f1: Add test for visibility changes (authored by aheinecke, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11597?vs=32469=32923#toc REPOSITORY R223 Okular

D11597: Add test for visibility changes

2018-04-23 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11597 To: aheinecke, #okular, aacid Cc: aacid, ngraham

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

2018-04-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=381328 --- Comment #11 from Albert Astals Cid --- (In reply to Henrik Fehlauer from comment #10) > (OT) > > > since Henrik didn't seem to want to answer my question > What? I always try to answer questions in the best way possible. In fact, I

D12049: Obey umask rules when saving new file

2018-04-23 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. I'll land it REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12049 To: chinmoyr, #okular, aacid Cc: ngraham, aacid

D11596: Add support for dynamic visibility

2018-04-23 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok, i guess REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11596 To: aheinecke, #okular, aacid Cc: aacid, ngraham

D10932: [Okular] Option to reset forms

2018-04-23 Thread Albert Astals Cid
aacid added a comment. In D10932#248786 , @ngraham wrote: > +1 for keeping this open and refining the behavior rather than abandoning it. How do you refine the behaviour in the case i mentioned where there are javascript actions

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 58 - Still Unstable!

2018-04-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/58/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 21:22:58 + Build duration: 12 min and counting JUnit

D11596: Add support for dynamic visibility

2018-04-23 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:bf90867c13ed: Add support for dynamic visibility (authored by aheinecke, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11596?vs=31736=32922

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 57 - Still Unstable!

2018-04-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/57/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 21:09:28 + Build duration: 13 min and counting JUnit

D12049: Obey umask rules when saving new file

2018-04-23 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:c5592689874f: Obey umask rules when saving new file (authored by chinmoyr, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12049?vs=31692=32915

[okular] [Bug 392682] Okular ignores umask on save file as

2018-04-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=392682 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 79 - Unstable!

2018-04-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/79/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 21:55:53 + Build duration: 12 min and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 78 - Fixed!

2018-04-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/78/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 21:09:43 + Build duration: 7 min 1 sec and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 80 - Fixed!

2018-04-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/80/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 22:08:35 + Build duration: 8 min 26 sec and counting JUnit Tests

D11609: Add support for chained / next actions

2018-04-23 Thread Albert Astals Cid
aacid added a comment. Are you sure you need s_doNotDeleteLinks ? I mean the links where deleting in resolveMediaLinks doesn't look like they can be nextActions, since it's the Opening/Closing/Activation actions we're resolving on void PDFGenerator::resolveMediaLinkReferences(

D10932: [Okular] Option to reset forms

2018-04-23 Thread Albert Astals Cid
aacid added a comment. In D10932#248618 , @rkflx wrote: > FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This option will reset all form fields to their default values. You may lose some data. Are

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.10 - Build # 37 - Failure!

2018-04-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.10/37/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 23 Apr 2018 22:24:54 + Build duration: 7 min 4 sec and counting