D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 37521. sander added a comment. Restricted Application added a subscriber: okular-devel. Applied Henrik's suggestions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=37025=37521 REVISION DETAIL

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 37522. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=37521=37522 REVISION DETAIL https://phabricator.kde.org/D7949 AFFECTED FILES generators/poppler/generator_pdf.cpp To: sander, #okular Cc: okular-devel,

D10974: Add option to ignore print margins

ngraham added a comment. In D10974#290127 , @rkflx wrote: > - `Scale to:` `Printable area` | `Paper size` +1, I would be fine with this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn,

D7949: Allow to print pdf doc directly into a QPrinter

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, accepting the Diff from my side (obviously I cannot speak for the Okular project). In D7949#290074 , @sander wrote: > That is

D10974: Add option to ignore print margins

rkflx added a comment. FWIW, earlier in D7962 there was this suggestion: In D7962#150260 , @rkflx wrote: > > Scale mode: fit-to-page vs. shrink-to-page vs. none > > Scale to: printable area vs. full

D7949: Allow to print pdf doc directly into a QPrinter

sander marked 3 inline comments as done. sander added a comment. >>Unlike for CUPS printing, Qt printing prints on the entire page and does not scale to the printable area yet. This is only because it is the easiest way. I > >plan to implement a few standard scaling methods in a subsequent