[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 Ahmad Osama changed: What|Removed |Added CC||ahmad.osama@gmail.com --- Comment #5 from

D10504: Bug 288042 - Option to reset forms

ahmadosama created this revision. ahmadosama added a project: Okular. Restricted Application added a subscriber: Okular. ahmadosama requested review of this revision. REVISION SUMMARY These changes are done to add a button to Reset pdf forms when clicked. Changes are to the following files:

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 --- Comment #7 from Ahmad Osama --- I have posted it here: https://phabricator.kde.org/D10504 I saw the comment now, it sounds that I have implemented almost the same idea! -- You are receiving this mail because: You are the assignee for the bug.

D10504: Bug 288042 - Option to reset forms

ahmadosama updated this revision to Diff 27427. ahmadosama added a comment. Removing unnecessary comments, add clear widget function for other widgets. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10504?vs=27143&id=27427 REVISION DETAIL https://phabrica

D10504: Bug 288042 - Option to reset forms

ahmadosama added a comment. I have not created an auto test before, I am currently going through current auto tests to understand how it works, then I will try creating an auto test for this bug. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10504 To: ahmadosama,

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama created this revision. ahmadosama added a project: Okular. ahmadosama requested review of this revision. REVISION SUMMARY Similar to how the autotest (editformtext.cpp) tests the form contents, I implemented the reset form option in a similar way by creating a function to reset each

D10504: Bug 288042 - Option to reset forms

ahmadosama added a comment. I implemented the reset option using Okular::FormFields inspired by the comments here: https://git.reviewboard.kde.org/r/130057/ I submitted another patch for this new implementation here: https://phabricator.kde.org/D10932 I am currently working on th

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama updated this revision to Diff 28622. ahmadosama added a comment. I have created an auto test but it is not working, in the test class I created a page view class that takes a document pointer in its constructor then it calls the reset function in the pageview class. I am thin

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 --- Comment #8 from Ahmad Osama --- Created attachment 83 --> https://bugs.kde.org/attachment.cgi?id=83&action=edit Implement the reset forms option using Okular::FormFields in a way similar to editformstest.cpp I uploaded the pa

GSoC Project: Verifying signatures of pdf files (Requirements)

through poppler's APIs. I would like to know if there are other requirements that I need to know to get more familiar with the project. Regards, Ahmad Osama

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama added a comment. I mistakenly replaced the code with the auto test. Here is the previous patch. F5741409: 0001-reimplementing-the-reset-option-using-formfields.patch REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.or

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama updated this revision to Diff 28717. ahmadosama added a comment. I mistakenly replaced the code with the auto test. I edited the patch now. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=28622&id=28717 REVISION DETAIL https://phabric

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10932 To: ahmadosama, #okular Cc: ngraham, aacid, #okular, michaelweghorn

GSoC Project: Verifying signatures of pdf files (Draft Proposal)

Okular and Poppler's source code to get a better understanding and develop a better implementation plan. Any feedback or suggestions are highly appreciated. Regards, Ahmad Osama

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama updated this revision to Diff 29263. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=28717&id=29263 REVISION DETAIL https://phabricator.kde.org/D10932 AFFECTED FILES autotests/CMakeLists.txt autotests/resetformstest.cpp part.cpp pa

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

ahmadosama updated this revision to Diff 29292. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=29263&id=29292 REVISION DETAIL https://phabricator.kde.org/D10932 AFFECTED FILES autotests/CMakeLists.txt autotests/resetformstest.cpp part.cpp pa

D10932: [Okular] Option to reset forms

ahmadosama retitled this revision from "Bug 288042 - Option to reset forms (Implemented using FormFields)" to "[Okular] Option to reset forms". ahmadosama edited the summary of this revision. ahmadosama edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://ph

D10932: [Okular] Option to reset forms

ahmadosama updated this revision to Diff 29396. ahmadosama edited the test plan for this revision. ahmadosama added a comment. I added an auto-test for this option, the test is working fine on all the created test cases. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricato

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 --- Comment #9 from Ahmad Osama --- I created an auto-test for this option that is working fine on the created test cases, the new test along with the implementation for this option are in this patch: https://phabricator.kde.org/D10932 -- You are

Re: D10504: Bug 288042 - Option to reset forms

yes I am going to cancel this revision. On Wed, Mar 14, 2018 at 12:49 AM, Albert Astals Cid < nore...@phabricator.kde.org> wrote: > aacid added a comment. View Revision > > So will you cancel this one in favor of the other one? > > *REPOSITORY* > R223 Okular >

D10932: [Okular] Option to reset forms

ahmadosama added inline comments. INLINE COMMENTS > aacid wrote in resetformstest.cpp:182 > what does this test do? This test is to make sure that the reset button is working correctly. > aacid wrote in part.cpp:3359 > Why did you add this? I added it to show the "reset forms" button in the di

D10932: [Okular] Option to reset forms

ahmadosama added a comment. Regarding the undo/redo stacks, the undo/redo command will not undo the whole reset, it will undo widgets somehow randomly. RadioButtons in the same page will be in the same undo command, as for TextLineEdit each single widget will be added separately to the undo

D10932: [Okular] Option to reset forms

ahmadosama added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:3359 > I don't think that's a good idea, do you think resetting the forms is as > common as showing/hiding them? I am going to remove it, the user will be able to trigger the reset action from the "view" drop down menu

D10932: [Okular] Option to reset forms

ahmadosama updated this revision to Diff 29771. ahmadosama added a comment. I have done the required changes. I created the EditWidgetsCommand class to undo/redo the reset action of all widgets by a single click, also I moved the core implementation of the reset function to the Document cla

Re: GSoC Project: Verifying signatures of pdf files (Draft Proposal)

I edited my proposal after researching how Adobe Acrobat implements the UI and made some modifications to my plan. I would appreciate any feedback regarding my proposal. Regards, On Fri, Mar 9, 2018 at 6:55 PM, Ahmad Osama wrote: > Dear All; > > I am interested to participate with

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. ahmadosama requested review of this revision. REVISION SUMMARY The highlights were removed when rotating the page, also the RotaionJob::rotationMatrix function wa

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11901 To: ahmadosama, #okular Cc: #okular, michaelweghorn, ngraham, aacid

D10932: [Okular] Option to reset forms

ahmadosama updated this revision to Diff 31204. ahmadosama added a comment. Removing white spaces. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=29771&id=31204 REVISION DETAIL https://phabricator.kde.org/D10932 AFFECTED FILES autotests/CMakeL

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. Oh yes this may break it, I am thinking of adding another Boolean parameter to the RotationJob::rotationMatrix function with a default value of false to either translate or not The function can be: RotationJob::rotationMatrix( Rotation from, Rotation to, bool t

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama updated this revision to Diff 31291. ahmadosama added a comment. I added the boolean parameter to either translate or not. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11901?vs=31202&id=31291 BRANCH HighlightTextBug (branched from master) RE

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating fro

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. I have not tested it, I do not know what on the page should be rotated when rotating m_page->m_rects, I still trying to find out. What I did is that I replaced: (*hlIt)->transform( RotationJob::rotationMatrix( oldRotation, m_rotation ) ); with: (*hlIt)->tra

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. As far as I know rotating m_page->m_rects should rotate annotations on the page, the annotations seem to work well when rotating them. When rotating the highlights I tried to replace: (*hlIt)->transform( RotationJob::rotationMatrix( oldRotation, m_rotation )

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama updated this revision to Diff 31856. ahmadosama added a comment. I used Okular::buildRotationMatrix to rotate the highlights, the rotation angle is specified in the rotateAt function REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11901?vs=31291&i

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. I will investigate more to find out why m_rects and m_highlights need different transformation matrices. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11901 To: ahmadosama, #okular, aacid Cc: aacid, ngraham, #okular, michaelweghorn

D10932: [Okular] Option to reset forms

ahmadosama added a comment. I agree with what you have said, and I was thinking about some of it. Closing the feature will not upset me, I have learned a lot from working on it. I hope that I could make better contributions to Okular later. REPOSITORY R223 Okular REVISION DETAIL http

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. ahmadosama requested review of this revision. REPOSITORY R223 Okular BRANCH returning_to_contents_when_saving_bug (branched from master) REVISION DETAIL

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: okular-devel, ngraham, aacid

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: okular-devel, ngraham, aacid

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama updated this revision to Diff 39543. ahmadosama added a comment. - Adding a unit test to check that document doesnot go back to contents view after saving REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14740?vs=39438&id=39543 BRANCH returning_

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama updated this revision to Diff 39544. ahmadosama added a comment. - Adding a unit test to check that document doesnot go back to contents view after saving REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14740?vs=39543&id=39544 BRANCH returning_

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

ahmadosama added a comment. I updated the parttest.cpp, the tocreload.pdf file in the data directory reproduced this bug so I used it for the unit test. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham

D16285: Allow saving loading the printing option and range, missing to get data from the print dialog to save

ahmadosama created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ahmadosama requested review of this revision. REVISION SUMMARY Allowing document to remember print range option, and remember from/to print range REPOSITORY R223 Okular BRANCH rememb

D16285: Remember printing option and print range in the print dialog

ahmadosama retitled this revision from "Allow saving loading the printing option and range, missing to get data from the print dialog to save" to "Remember printing option and print range in the print dialog". ahmadosama edited the summary of this revision. ahmadosama added a reviewer: Okular. R

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44036. ahmadosama added a comment. - Resetting the printing option to the default options when closing document REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=43825&id=44036 BRANCH remember_print_range RE

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#344990 , @ngraham wrote: > This new information is saved/remembered per-document and not globally, right? The new information was saved for all documents if Okular was not closed, closing the documen

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#346864 , @aacid wrote: > If you're not going to save the data, why are you adding it to the docinfo xml? > > If this is only for remembering the options while okular is open i don't even think it makes

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44041. ahmadosama added a comment. - Reformatting the code to be consistent with other parts REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=44036&id=44041 BRANCH remember_print_range REVISION DETAIL htt

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44043. ahmadosama added a comment. - Reformat other parts of the code REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=44041&id=44043 BRANCH remember_print_range REVISION DETAIL https://phabricator.kde.or

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. @yurchor I have reformatted the code to be consistent, sorry for this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16285 To: ahmadosama, #okular Cc: aacid, yurchor, broulik, ngraham, okular-devel

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#346944 , @aacid wrote: > In D16285#346879 , @ahmadosama wrote: > > > In D16285#346864 , @aacid wrote: > > > > > I

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44260. ahmadosama added a comment. - Changing variables, function names and comments to be more meaningful REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=44043&id=44260 BRANCH remember_print_range REVISIO

[GSoC Draft Proposal] Support animated PDF

/1yaDVRMMenL_Ju1iiK05vWUwi6uR64JOtbFsVadd35cc/edit?usp=sharing This proposal is still being edited as I am still investigating, so I would appreciate your suggestions and comments. Best Regards, Ahmad Osama