[Okular-devel] [Bug 267522] Crash when opening Okular with the following file

2011-03-03 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=267522 --- Comment #2 from Aleix Pol aleixpol kde org 2011-03-03 21:28:06 --- Created an attachment (id=57656) -- (http://bugs.kde.org/attachment.cgi?id=57656) Crashy file -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You

[Okular-devel] [Bug 271301] New: There's not an option to disable the selection when in selection mode

2011-04-19 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=271301 Summary: There's not an option to disable the selection when in selection mode Product: okular Version: 0.10.5 Platform: Ubuntu Packages OS/Version: Linux Status: NEW

[Okular-devel] [Bug 271816] I want the cursor to change in browsing/selection mode

2011-08-05 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=271816 Aleix Pol aleix...@kde.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution

[Okular-devel] [Bug 284406] New: Zoom combo box is broken

2011-10-18 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=284406 Summary: Zoom combo box is broken Product: okular Version: unspecified Platform: Unlisted Binaries OS/Version: Linux Status: NEW Severity: normal Priority: NOR

[Okular-devel] [Bug 284406] Zoom combo box is broken

2011-10-18 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=284406 --- Comment #1 from Aleix Pol aleixpol kde org 2011-10-18 20:27:03 --- BTW, I'm using KDE master, maybe that helps. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You

[Okular-devel] [okular] [Bug 319491] New: Crash while closing Okular

2013-05-07 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=319491 Bug ID: 319491 Summary: Crash while closing Okular Classification: Unclassified Product: okular Version: 0.16.60 Platform: Compiled Sources OS: Linux Status:

[Okular-devel] [okular] [Bug 324241] Files generated with QTextDocument can't be opened with okular

2013-08-29 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=324241 --- Comment #1 from Aleix Pol aleix...@kde.org --- Created attachment 82020 -- https://bugs.kde.org/attachment.cgi?id=82020action=edit here's a file to reproduce the problem LibreOffice can open it -- You are receiving this mail because: You

Re: [Okular-devel] Taking a break and an Okular sprint in October

2016-07-25 Thread Aleix Pol
On Mon, Jul 25, 2016 at 12:40 AM, Albert Astals Cid wrote: > Hi guys, I have come to the obvious realization, at the moment I do not have > enough stamina to review and take care of what needs to be done for Okular, i > have 162 unread emails in the Okular mail folder, an order of

[okular] [Bug 371828] New: Wrong aspect ratio when rendering tiff file

2016-10-29 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=371828 Bug ID: 371828 Summary: Wrong aspect ratio when rendering tiff file Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

2016-10-29 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=362856 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1

[okular] [Bug 373855] Forward search/named_destination feature not working anymore

2017-01-13 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=373855 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confi

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

2017-01-12 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=374358 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Reso

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

2017-01-02 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=374358 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confi

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

2017-01-02 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=374358 --- Comment #1 from Aleix Pol <aleix...@kde.org> --- Note that Flatpak doesn't run the packages on your file system, you need to check on the contained environment. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

2017-01-02 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=374358 --- Comment #2 from Aleix Pol <aleix...@kde.org> --- I've investigated a bit, this library seems to be part of the sdk exclusively, need to investigate how it happens and how to fix it. -- You are receiving this mail because: You are the as

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

2017-01-08 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=374358 --- Comment #3 from Aleix Pol <aleix...@kde.org> --- Dependency coming from KJS. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389224] Build failure with latest purpose changes

2018-01-21 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=389224 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added CC||aleix...@k

Poppler on Android builds

2018-09-04 Thread Aleix Pol
Hey, I guess you knew there are Okular Android builds: https://binary-factory.kde.org/view/Android/job/Okular_android/ Build is broken now because the Android NDK doesn't have std::stoi. https://binary-factory.kde.org/view/Android/job/Okular_android/146/console I'll change it to build the

[okular] [Bug 393119] No way to disable okularkirigami building

2018-04-19 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=393119 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added CC||aleix...@kde.org --- Comm

[okular] [Bug 393119] No way to disable okularkirigami building

2018-04-22 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=393119 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest

Re: Idea: Failing the build unless you explicitely chose which Okular UI you want to build

2020-01-27 Thread Aleix Pol
Hi Albert, I'm unsure it's necessary to be this radical. IMHO, it's fine to just not build okularkirigami if the dependencies don't match. And viceversa. Aleix On Sat, Jan 25, 2020 at 11:25 PM Albert Astals Cid wrote: > > Right now we build by default both the Desktop UI and the Mobile UI. > >

Re: Idea: Failing the build unless you explicitely chose which Okular UI you want to build

2020-01-28 Thread Aleix Pol
Right, then go with your approach. I'd default to the desktop one which is the one most people are after I guess. It's annoying when projects don't build by default. Aleix On Mon, Jan 27, 2020 at 11:53 PM Albert Astals Cid wrote: > > El dilluns, 27 de gener de 2020, a les 1:10:08 CET, Ale

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-05-19 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=421780 Aleix Pol changed: What|Removed |Added CC||aleix...@kde.org --- Comment #1 from Aleix Pol

Re:

2020-12-29 Thread Aleix Pol
On Sat, Dec 26, 2020 at 11:21 AM Bhumit Attarde wrote: > > Hey guys, > > I'm a second year engineering student interested in GSOC '21. > > I've gone through https://community.kde.org/GSoC/2021/Ideas and have zeroed > in on an app I like and know a little about (Okular). I plan to get myself >

[okular] [Bug 437334] New: Okular crashes when wrapping cursor on wayland

2021-05-18 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=437334 Bug ID: 437334 Summary: Okular crashes when wrapping cursor on wayland Product: okular Version: unspecified Platform: Compiled Sources OS: Linux Status: REPORTED

[okular] [Bug 437334] Okular crashes in CursorWrapHelper::getScreen() when wrapping cursor on wayland

2021-05-20 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=437334 --- Comment #3 from Aleix Pol --- Here is some information. https://wayland-book.com/ In general terms, you need to understand that in Wayland you cannot move the cursor. So in general this part should be just skipped on wayland. The crash itself

[okular] [Bug 271815] I want a better icon in the browse mode

2022-11-28 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=271815 Aleix Pol changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[okular] [Bug 468152] New: Crash on exit after signing with a smart card

2023-04-04 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=468152 Bug ID: 468152 Summary: Crash on exit after signing with a smart card Classification: Applications Product: okular Version: unspecified Platform: Other OS: Linux

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

2011-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/ --- (Updated Aug. 5, 2011, 7:52 a.m.) Review request for Okular. Summary

[Okular-devel] Review Request: Change mouse cursor when changing the current tool.

2011-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/ --- Review request for Okular. Summary --- Update the cursors when

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

2011-08-06 Thread Aleix Pol Gonzalez
--- On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220

Re: [Okular-devel] Review Request 126379: Windows string fixes

2015-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126379/#review90208 --- +1 - Aleix Pol Gonzalez On Dec. 27, 2015, 1:28 a.m

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-05-30 Thread Aleix Pol Gonzalez
marked as submitted. Review request for Okular. Changes --- Submitted with commit 32b62e919a6493cca9d5d2b272872b53f9b5e41d by Aleix Pol to branch frameworks. Repository: okular Description --- Drops KDELibs4Support usage, mostly it wasn't actually used, except for that KFileDialog

[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-09 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/127021/diff/ Testing --- Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-09 Thread Aleix Pol Gonzalez
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127021/#review92202 --- On Feb. 9, 2016, 3:51 p.m., Aleix Pol Gonzalez wrote: > > ---

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-09 Thread Aleix Pol Gonzalez
fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 127042: Fix QUrl string encoding

2016-02-11 Thread Aleix Pol Gonzalez
- shell/okular_main.cpp 9bdc1fe Diff: https://git.reviewboard.kde.org/r/127042/diff/ Testing --- Now I can open files with a space in it. Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

2016-02-11 Thread Aleix Pol Gonzalez
oded. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127042/#review92284 --- On Feb. 11, 2016, 8:50 p.m., Aleix Pol

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

2016-01-30 Thread Aleix Pol Gonzalez
> On Dec. 16, 2015, 5:42 p.m., Alex Richardson wrote: > > ui/guiutils.cpp, line 207 > > > > > > Not really related but it would be nice to handle remote URLs here as > > well, QFileDialog::getSaveFileUrl() and

Re: [Okular-devel] Review Request 126913: use QScreen unconditionally instead of libkscreen

2016-01-30 Thread Aleix Pol Gonzalez
> On Jan. 30, 2016, 4:15 p.m., Albert Astals Cid wrote: > > Hold an A4 paper against your screen at 100% zoom, is the page of proper > > size? I just tested it, looks good. - Aleix --- This is an automatically generated e-mail. To

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

2016-01-30 Thread Aleix Pol Gonzalez
t; Patrick Spendrin wrote: > Yes, I only saw that after the review was opened, I'll adapt this to the > way the other generators handle it. > > Aleix Pol Gonzalez wrote: > I'll fix it and commit the patch.

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

2016-02-24 Thread Aleix Pol Gonzalez
https://git.reviewboard.kde.org/r/127042/diff/ Testing --- Now I can open files with a space in it. Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

2016-02-26 Thread Aleix Pol Gonzalez
marked as submitted. Review request for Okular and Alex Richardson. Changes --- Submitted with commit 154c98fdaab2e593091fe644cfaeed96dd9fefaf by Aleix Pol to branch frameworks. Repository: okular Description --- This Url is converted in to a string to be parsed back using `QUrl

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-15 Thread Aleix Pol Gonzalez
> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-16 Thread Aleix Pol Gonzalez
> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-18 Thread Aleix Pol Gonzalez
> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

Re: [Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

2016-03-14 Thread Aleix Pol Gonzalez
xport macros at configure time. - Aleix Pol Gonzalez On March 14, 2016, 1:17 a.m., Thomas Friedrichsmeier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-13 Thread Aleix Pol Gonzalez
Use foreach or qAsConst. shell/shell.cpp (line 441) <https://git.reviewboard.kde.org/r/128435/#comment65725> I think it would make sense to move that logic upstream. It's not something specific about okular. - Aleix Pol Gonzalez On July 13, 2016, 11:57 p.m., Martin Tobias H

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-21 Thread Aleix Pol Gonzalez
> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote: > > shell/shell.cpp, line 441 > > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441> > > > > I think it would make sense to move that logic upstream. > > &g

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-17 Thread Aleix Pol Gonzalez
> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote: > > shell/shell.cpp, line 441 > > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441> > > > > I think it would make sense to move that logic upstream. > > &g

Re: Review Request 129347: add metadata for kimgio, mobipocket, ooo, plucker, poppler, spectre, txt, xps

2016-11-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129347/#review100739 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 6

D12884: Remove the internal file navigation from the global drawer

2018-05-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, mart, aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. apol requested review of this revision. REVISION SUMMARY Instead include an "open" item. TEST PLAN opened a file

D12672: Use a target in FindDiscount (modern cmake) rather than variables

2018-05-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It's actually fixing the build when discount is in its own prefix. Also I agree that it's better using targets. REPOSITORY R223 Okular BRANCH Applications/18.04 REVISION DETAIL

D12770: Android: Make it possible to associate with files

2018-05-08 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, aacid, mart. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Put the file into a file descriptor and open this file descriptor. Just application/pdf for now. TEST PLAN opened

D12770: Android: Make it possible to associate with files

2018-05-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R223:cf4bb5e3b178: Android: Make it possible to associate with files (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12770?vs=33858=33998#toc REPOSITORY R223 Okular CHANGES

D12884: Remove the internal file navigation from the global drawer

2018-05-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R223:600e72100b13: Remove the internal file navigation from the global drawer (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34335=34371

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > aacid wrote in document.cpp:2362 > I don't think it's a good idea changing the behaviour, can't you fix the > mobile app to do the right thing? Sure, I did it because it feels like broken API. It just complains and doesn't do anything when you

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 34297. apol added a comment. Don't add logic in core/ just in case REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34168=34297 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 AFFECTED FILES

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 34335. apol added a comment. Remove hardcoded path REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34297=34335 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 AFFECTED FILES

D10007: Fix Build with Purpose

2018-01-21 Thread Aleix Pol Gonzalez
apol added a comment. I changed it so KDEExperimental still works with newer Purpose. I'd say let's keep the old one and when it's released again, then just change to just KF5::Purpose. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10007 To: tcanabrava, #okular,

D10007: Fix Build with Purpose

2018-01-28 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Shouldn't be needed anymore. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10007 To: tcanabrava, #okular, apol Cc: michaelweghorn, aacid, ltoscano,

D14102: Add share action to selection context menu

2018-07-16 Thread Aleix Pol Gonzalez
apol added a comment. I'd say it would make sense to just make it possible to drag and drop this to the quick share plasmoid. Or just put it on the clipboard and paste it there. INLINE COMMENTS > pageview.cpp:60 > #include > +#include > +#include Purpose is already used in other parts

D10022: Fix annoying warning

2018-01-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Warning for every plugin was: The file includes the moc file

D12177: Make some frameworks optional so okular can be built on Android

2018-04-13 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Okular. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Disables KWallet integration if there's no KWallet, KJS if there's no KJS and KDocTools. Here's a list of frameworks that don't

D12176: Turn okularkirigami into an executable

2018-04-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R223:5f8f84d53cf8: Turn okularkirigami into an executable (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12176?vs=32070=32071 REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32303. apol added a comment. Shouldn't comment the include... REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32302=32303 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32302. apol added a comment. Typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32296=32302 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12250: Install okularpart with the rest of kparts

2018-04-16 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, aacid. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY We have a directory with all kparts, okular should integrate there TEST PLAN Uninstalled, installed with the patch

D12177: Make some frameworks optional so okular can be built on Android

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32296. apol added a comment. Address Albert's concern REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32072=32296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12250: Install okularpart with the rest of kparts

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32319. apol added a comment. Unsure why it worked for me, point to the library like katepart does REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32300=32319 BRANCH installprefix REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32317. apol added a comment. Unsure why it works on my system, adopt the same way to point to the path katepart uses REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32303=32317 BRANCH master REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32318. apol added a comment. Oops REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32317=32318 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12352: Make it possible to disable the build of okularkirigami

2018-04-19 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, mart, aacid, lbeltrame. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Some distros seem to have the option. BUG: 393119 TEST PLAN Still builds, can disable build

D12352: Make it possible to disable the build of okularkirigami

2018-04-22 Thread Aleix Pol Gonzalez
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:1fb77446a737: Make it possible to disable the build of okularkirigami (authored by apol). REPOSITORY R223 Okular

D12250: Install okularpart with the rest of kparts

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32347. apol added a comment. There's more desktop files pointing to okularpart REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32319=32347 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250

D12250: Install okularpart with the rest of kparts

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32348. apol added a comment. And another REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32347=32348 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED FILES CMakeLists.txt

D12250: Install okularpart with the rest of kparts

2018-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32353. apol added a comment. The shell needs to know where the plugin is REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32348=32353 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED

D12299: Android: include metadata for okular kirigami

2018-04-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, mart, aacid. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Include an AndroidManifest.xml file so when it's installed it has a proper icon and name. Include appdata

D12299: Android: include metadata for okular kirigami

2018-04-18 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R223:77049d3b80c2: Android: include metadata for okular kirigami (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12299?vs=32434=32523#toc REPOSITORY R223 Okular CHANGES SINCE

D12352: Make it possible to disable the build of okularkirigami

2018-04-19 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 32616. apol added a comment. Improve description REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12352?vs=32569=32616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12352 AFFECTED FILES CMakeLists.txt

D16544: Properly find the Purpose framework

2018-10-31 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Okular, aacid. Herald added a project: Okular. Herald added a subscriber: okular-devel. apol requested review of this revision. REPOSITORY R223 Okular BRANCH findkf5purpose REVISION DETAIL https://phabricator.kde.org/D16544 AFFECTED FILES

D16544: Properly find the Purpose framework

2018-11-02 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16544 To: apol, #okular, aacid Cc: okular-devel, ngraham, aacid

D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled

2018-11-27 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R223 Okular BRANCH Applications/18.12 REVISION DETAIL https://phabricator.kde.org/D17196 To: heikobecker, #okular, apol Cc: okular-devel, ngraham, darcyshen, aacid

D16544: Properly find the Purpose framework

2019-01-07 Thread Aleix Pol Gonzalez
apol added a comment. \o/ REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16544 To: apol, #okular, aacid Cc: okular-devel, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-26 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18397 To: vkrause, apol Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D12250: Install okularpart with the rest of kparts

2019-02-11 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12250 To: apol, #okular, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R223 Okular BRANCH improve-searchfield REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham, apol Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

[Okular-devel] [okular] [Bug 363842] New: Appstream doesn't provide all supported mimetypes

2016-06-02 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363842 Bug ID: 363842 Summary: Appstream doesn't provide all supported mimetypes Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

[Okular-devel] [okular] [Bug 363842] Okular appstream data doesn't provide all supported mimetypes

2016-06-02 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363842 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Summary|Appstream doesn't provide |Okular appstrea

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

2016-02-26 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359223 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Reso

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

2016-02-26 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359223 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added CC||aleix...@kde.org --- Comm

[Okular-devel] [okular] [Bug 363842] [frameworks] Okular appstream data doesn't provide all supported mimetypes

2016-07-04 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363842 Aleix Pol <aleix...@kde.org> changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEE

[Okular-devel] [okular] [Bug 363842] [frameworks] Okular appstream data doesn't provide all supported mimetypes

2016-07-05 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363842 --- Comment #6 from Aleix Pol <aleix...@kde.org> --- They certainly claim they adhere to readmes and such. I guess splitting can make sense in the cases where it adds dependencies. If you want to maintain such freedom, then we can just add an app