https://bugs.kde.org/show_bug.cgi?id=348223
David Edmundson k...@davidedmundson.co.uk changed:
What|Removed |Added
CC||arem...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=348223
David Edmundson k...@davidedmundson.co.uk changed:
What|Removed |Added
CC||tpreg...@aol.com
https://bugs.kde.org/show_bug.cgi?id=353475
David Edmundson <k...@davidedmundson.co.uk> changed:
What|Removed |Added
Version|0.23.0
913/#comment62634>
you missed out all of this bit which does validity checks
core/utils.cpp (lines 124 - 130)
<https://git.reviewboard.kde.org/r/126913/#comment62635>
this can be replaced by QScreen too.
- David Edmundson
On Jan. 28, 2016, 3:07 a.m., Sebastian
davidedmundson added inline comments.
INLINE COMMENTS
> pagepainter.cpp:70
> QRect scaledCrop = crop.geometry( scaledWidth, scaledHeight );
> +const QRect dScaledCrop(QRectF(scaledCrop.x() * dpr, scaledCrop.y() *
> dpr, scaledCrop.width() * dpr, scaledCrop.height() *
davidedmundson added a comment.
qApp->DPR can change within the lifespan of the app; for example plugging in
a new monitor can change things.
This does mean it's very important to keep the metadata of the pixmap's dpr
with the pixmap. It ends up simpler and safer overall.
Doesn't
davidedmundson added a comment.
"Test plan" simply needs to be a list of things you've tried doing so the
maintainers can point out if there's any parts you've not thought about.
So saying if you tested annotations and what types of files you opened,
checked with zoom = 100%..that sort
davidedmundson accepted this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6268
To: hetzenecker, davidedmundson, aacid
Cc: gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid
davidedmundson added a comment.
Oh I didn't mean it like that. Your input has been really really valuable.
I was just trying to work out if we should block this and get it fixed, or
try to merge this and then work on any remaining improvements.
REPOSITORY
R223 Okular
REVISION DETAIL
davidedmundson added a comment.
> But of course I also found yet another issue: :-) When drawing in
presentation mode, the resolution of the drawing is too low. The lines look
pixelish.
Can I confirm that that's not a regression from the pre-patch status but just
something else that
davidedmundson added a comment.
From my POV (pending a reply from Sander) this is good to go.
INLINE COMMENTS
> pageviewannotator.cpp:1122
> +imageVariant = "@2x";
> +} else {
> +imageVariant = "";
that's a redundant else branch, and it won't get optimised out as
https://bugs.kde.org/show_bug.cgi?id=386110
David Edmundson <k...@davidedmundson.co.uk> changed:
What|Removed |Added
CC|
https://bugs.kde.org/show_bug.cgi?id=386111
David Edmundson <k...@davidedmundson.co.uk> changed:
What|Removed |Added
CC|
davidedmundson created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
pixelValue/pixelValue will give us a normalised value.
Normalised values shouldn't be modified by a device pixel ratio.
We want
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1a3dc7d8e05f: Fix highlight/annotation clipping with Qt
scaling (authored by davidedmundson).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8832?vs=22420=22862
davidedmundson added a comment.
Oops, I didn't read that. :/ Sorry.
cherry-picked.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8832
To: davidedmundson, rkflx
Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:804d0bd42a23: Fix rubber band selection drawing contents
misaligned with scaling (authored by davidedmundson).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
davidedmundson updated this revision to Diff 30123.
davidedmundson added a comment.
Update to fix Anthony's well spotted comment
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8980?vs=22864=30123
BRANCH
master
REVISION DETAIL
davidedmundson marked an inline comment as done.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8980
To: davidedmundson, aacid
Cc: sander, rkflx, anthonyfieroni, #okular, michaelweghorn, ngraham, aacid
https://bugs.kde.org/show_bug.cgi?id=476094
David Edmundson changed:
What|Removed |Added
Keywords|drkonqi |wayland
CC
20 matches
Mail list logo
