/document.h bac38f89
core/document.cpp 468a8a9f
ui/searchlineedit.cpp 85516efb
Diff: https://git.reviewboard.kde.org/r/129893/diff/
Testing
---
Thanks,
Elvis Angelaccio
Description
---
The `duration` argument is used as input of `QTimer::start()`, which requires
milliseconds and not seconds.
Diffs
-
core/document.h bac38f89
Diff: https://git.reviewboard.kde.org/r/129894/diff/
Testing
---
Thanks,
Elvis Angelaccio
gi?id=354133 but this patch
probably fixes it as side effect.
- Elvis Angelaccio
On Jan. 26, 2017, 11:37 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
> On Jan. 26, 2017, 11:47 p.m., Elvis Angelaccio wrote:
> > I don't understand https://bugs.kde.org/show_bug.cgi?id=354133 but this
> > patch probably fixes it as side effect.
Oh sorry, this comment was supposed to be for
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit 3b610bd86a2393fca1f04e02e2b7d899835fe635 by Elvis
Angelaccio to branch master.
Repository: okular
Description
---
The `duration` argument is used as input of `QTimer::start
with search in KWrite/Kate and
with web browsers.
Diffs (updated)
-
core/document.h 1fd86262
core/document.cpp 41b9ddfe
ui/searchlineedit.cpp baac8be0
Diff: https://git.reviewboard.kde.org/r/129893/diff/
Testing
---
Thanks,
Elvis Angelaccio
Continue
button in the messagebox.
- Elvis
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
---
On Fe
again Next and the search starts over from the beginning of the document,
without the "Continue from the beginning?" dialog.
Thanks,
Elvis Angelaccio
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
---
On Feb. 9, 2017, 10:08 p.m., Elvis Angelaccio wrote:
>
> ---
-45a5-9595-d355dac26042__after.png
Thanks,
Elvis Angelaccio
-------
On March 11, 2017, 5:41 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> --
https://bugs.kde.org/show_bug.cgi?id=334798
Elvis Angelaccio changed:
What|Removed |Added
CC||elvis.angelac...@kde.org
--
You are
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130131/#review103227
---
+1
- Elvis Angelaccio
On May 15, 2017, 8:30 p.m., Tobias
https://bugs.kde.org/show_bug.cgi?id=381328
Elvis Angelaccio changed:
What|Removed |Added
CC||elvis.angelac...@kde.org
--
You are
ready read the first 10 pages?
>
> Anyhow sure try to get someone from usability, but comparing okular to
> kate is an apples to pineapples comparison imnsho.
>
> Elvis Angelaccio wrote:
> Consider this use case: I open a pdf because I need to search something
> in t
/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png
Thanks,
Elvis Angelaccio
better visibility?
- Elvis Angelaccio
On Aug. 30, 2017, 2:47 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
elvisangelaccio created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
The KPixmapSequence constructor needs the full path of the icon, so the
current code doesn't work and generates a "Invalid pixmap specified
elvisangelaccio added a reviewer: Okular.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7996
To: elvisangelaccio, #okular
Cc: #okular, aacid
cation.
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png
Thanks,
Elvis Angelaccio
69d9a-6fbf-45a5-9595-d355dac26042__after.png
Thanks,
Elvis Angelaccio
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7996#149273, @aacid wrote:
> Whoever decided to change from iconName to fullpath deserves some
punishment for having a class constructor that has exactly signature but
behaves totally different.
>
> every single instanc
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7996#149307, @elvisangelaccio wrote:
> The weird thing is that I can't find the change with git blame. Shouldn't
we just restore the old implementation?
Ah no, we can't since KIconLoader is tier3...
REPOSITORY
R22
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1364d0e97b22: Properly create KPixmapSequence (authored
by elvisangelaccio).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7996?vs=19947&id=19958
REVISION DETAIL
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
exec() is blocking and should not be used if possible.
Currently it makes impossible to interact with a 2nd okular window
if the first window h
elvisangelaccio added a subscriber: okular-devel.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8704
To: elvisangelaccio, #okular
Cc: okular-devel, aacid
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:40afb8292690: Don't use exec() to open dialogs
(authored by elvisangelaccio).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8704?vs=22046&id=22219
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=155563
Elvis Angelaccio changed:
What|Removed |Added
CC||elvis.angelac...@kde.org
--
You are
https://bugs.kde.org/show_bug.cgi?id=404078
Elvis Angelaccio changed:
What|Removed |Added
Version|17.12.3 |unspecified
Assignee
https://bugs.kde.org/show_bug.cgi?id=406713
Bug ID: 406713
Summary: Wrong PDF rendering
Product: okular
Version: 1.7.0
Platform: Archlinux Packages
OS: Linux
Status: REPORTED
Severity: normal
Pri
https://bugs.kde.org/show_bug.cgi?id=406713
--- Comment #1 from Elvis Angelaccio ---
Created attachment 119533
--> https://bugs.kde.org/attachment.cgi?id=119533&action=edit
Okular VS Firefox
Comparison between Okular and Firefox opening the attached PDF file.
--
You are receiving th
https://bugs.kde.org/show_bug.cgi?id=406713
--- Comment #3 from Elvis Angelaccio ---
Interesting, I didn't know about stamps. Thanks for the workaround!
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=408818
Elvis Angelaccio changed:
What|Removed |Added
Product|ark |okular
Component|general
https://bugs.kde.org/show_bug.cgi?id=396137
Elvis Angelaccio changed:
What|Removed |Added
CC||elvis.angelac...@kde.org
--
You are
34 matches
Mail list logo
