[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||1.11.0 Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/b8b36ae5 ||29599da358f433fe23d7bac4dea ||79fa8 Status|CONFIRMED |RESOLVED --- Comment #6 from Nate Graham --- Git commit b8b36ae529599da358f433fe23d7bac4dea79fa8 by Nate Graham. Committed on 27/05/2020 at 13:37. Pushed by ngraham into branch 'master'. Improve the sidebar's navigation and UX Okular's sidebar vertical view chooser toolbar suffers from a few issues: * It's a nonstandard UI not used for category choosers in other pieces of KDE software, and not used in other FOSS document readers * What is shown and what is hidden is simultaneously too configurable while still not offering the desirable UI common to other programs (i.e. no visible category chooser, but a sidebar capable of displaying thumbnails, table of contents, search results, etc.) * With labels on it takes up quite a bit of horizontal space, while with labels off, the categories are less than clear * UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category to hide that category's view while keeping the view chooser visible, showing mostly disabled items) * It's made with custom painting code, which reduces maintainability and introduces bugs (e.g. https://bugs.kde.org/show_bug.cgi?id=408190) This patch removes the vertical category chooser entirely and replaces it with a tabbed view on the top of the sidebar itself. The tabs are icons-only and have large icons. A button is added on the left side of the default toolbar to quickly hide or show the sidebar. In order to make room for the new button, the Previous and Next buttons on the toolbar are removed, as previous/next buttons are already present on the Page Bar on the bottom of the window so there's no need to duplicate this functionality. This improves the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term maintainability.  Related: bug 334441, bug 344599, bug 408190, bug 335189 FIXED-IN: 1.11.0 CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space M +---doc/annotations.png M +---doc/bookmark-management.png M +8-10 doc/index.docbook M +---doc/mainwindow.png M +---doc/signatures-panel.png M +34 -34 part.cpp M +4-2part.h M +2-3part.rc M +10 -1ui/bookmarklist.cpp M +11 -1ui/layers.cpp M +11 -1ui/side_reviews.cpp M +21 -654 ui/sidebar.cpp M +1-19 ui/sidebar.h M +14 -1ui/signaturepanel.cpp M +23 -0ui/thumbnaillist.cpp M +2-3ui/thumbnaillist.h M +10 -1ui/toc.cpp https://invent.kde.org/graphics/okular/commit/b8b36ae529599da358f433fe23d7bac4dea79fa8 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 --- Comment #5 from Mayank Choudhary --- As per Syam request, I have sent a patch here: https://phabricator.kde.org/D22118 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Mayank Choudhary changed: What|Removed |Added CC||mayankch...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Okular-devel] [okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Boris Egorov ego...@linux.com changed: What|Removed |Added CC||ego...@linux.com --- Comment #4 from Boris Egorov ego...@linux.com --- I think we need an option to show/hide left panel by mouse clicking. It is pretty easy to do with keyboard (F7 or something custom) and by clicking on Settings-Show Navigation Panel. Hiding is pretty easy - we can add close icon at the bottom of left panel. But how can we show panel again if we want to? It would be nice to have some intuitive solution. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Pranab Roy proy@gmail.com changed: What|Removed |Added CC||proy@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)
https://bugs.kde.org/show_bug.cgi?id=213508 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Keywords||junior-jobs Status|UNCONFIRMED |CONFIRMED CC||aa...@kde.org Ever confirmed|0 |1 Severity|normal |wishlist --- Comment #3 from Albert Astals Cid aa...@kde.org --- Ok, i can see the point of focus going back to the main page after clicking to toggle the visibility on an item, don't think it's a bug per se though. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
