[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
   |lar/e3747ca3fd9b9926ff8c528 |lar/bedc3dbeadd450a86077030
   |79da7fca1a620fef5   |8ffc2ca5538cf42b9

--- Comment #10 from Albert Astals Cid  ---
Git commit bedc3dbeadd450a860770308ffc2ca5538cf42b9 by Albert Astals Cid, on
behalf of Julian Wolff.
Committed on 07/09/2017 at 19:49.
Pushed by aacid into branch 'Applications/17.08'.

Fix automatic reload of files saved with QSaveFile

Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct
behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on
replaced files.

Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.

Reviewers: aacid

Reviewed By: aacid

Subscribers: sander, rkflx, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7671

M  +1-0part.cpp

https://commits.kde.org/okular/bedc3dbeadd450a860770308ffc2ca5538cf42b9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Julian Wolff]

https://bugs.kde.org/show_bug.cgi?id=384185

Julian Wolff  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/oku
   ||lar/e3747ca3fd9b9926ff8c528
   ||79da7fca1a620fef5
 Status|UNCONFIRMED |RESOLVED

--- Comment #9 from Julian Wolff  ---
Git commit e3747ca3fd9b9926ff8c52879da7fca1a620fef5 by Julian Wolff.
Committed on 07/09/2017 at 11:18.
Pushed by jwolff into branch 'master'.

Fix automatic reload of files saved with QSaveFile

Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct
behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on
replaced files.

Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.

Reviewers: aacid

Reviewed By: aacid

Subscribers: sander, rkflx, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7671

M  +1-0part.cpp

https://commits.kde.org/okular/e3747ca3fd9b9926ff8c52879da7fca1a620fef5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

Albert Astals Cid  changed:

   What|Removed |Added

Version|1.3.70  |1.2.70

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #8 from Albert Astals Cid  ---
Meh, it's probably a regression in inotify since i build the old kdelibs4
version and that doesn't work anymore either. I'll try to add some more code
and ideally an autotest.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #7 from Albert Astals Cid  ---
After reading the code i agree it seems a regression in kdirwatch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #6 from Albert Astals Cid  ---
We had code for this, i guess someone broke it when porting to KF5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Julian Wolff]

https://bugs.kde.org/show_bug.cgi?id=384185

Julian Wolff  changed:

   What|Removed |Added

 CC||wo...@julianwolff.de

--- Comment #5 from Julian Wolff  ---
I can confirm this too, for both markdown and txt documents (and probably
others).

In part.cpp:1729, slotFileDirty, we check if the path of a document that got
dirty matches with the file path of the currently loaded document.
When editing a document with Kate, the .kate-swp file gets dirty, but not the
actual document.

For me this seems like a bug in either Kate or KDirWatch, not in Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #4 from Oliver Sander  ---
No, I merely looked at these patches, but never tested them.

More experimentation has revealed the following: Automatic reload does work as
expected when I 'touch' the file, or when I save it from 'vi'.  It does not
work when I save it from Kate.  How can that be?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #3 from Albert Astals Cid  ---
Yes works for me.

HAvne't you destroyed this feature locally while testing patches D7595/D7495 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=384185

--- Comment #2 from Oliver Sander  ---
Can you reproduce it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384185

Albert Astals Cid  changed:

   What|Removed |Added

   Severity|wishlist|normal
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
this is a bug not a wish, i'm kind of surprised this doens't work, nothing pdf
sepcific in the reload path

-- 
You are receiving this mail because:
You are the assignee for the bug.