[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2018-04-16 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=387424

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2017-12-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=387424

--- Comment #5 from Nate Graham  ---
Ok, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2017-12-03 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=387424

Luigi Toscano  changed:

   What|Removed |Added

 CC||luigi.tosc...@tiscali.it

--- Comment #4 from Luigi Toscano  ---
(In reply to Nate Graham from comment #3)
> Sorry, I thought the bug would get closed automatically because I added
> "BUG: 387424" to the pPhabricator revision.

The line is "Summary: BUG: 387424", and that's probably why it was not parsed.

> In general, should I always ask which branch to commit to, or always commit
> to the latest stable branch and then merge to master, or do something else?

As Albert wrote: bugfixes (no features, no string changes (but exceptions are
possible), etc) can go directly to the stable branch (and then merge to
master). Anything else to master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2017-12-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=387424

--- Comment #3 from Nate Graham  ---
Sorry, I thought the bug would get closed automatically because I added "BUG:
387424" to the pPhabricator revision.

In general, should I always ask which branch to commit to, or always commit to
the latest stable branch and then merge to master, or do something else?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2017-12-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=387424

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Albert Astals Cid  ---
And you commited your patch, only to master and forgot to close this bug.

Please pay more attention to detail when developing.

Bugfixes like this go to stable branches.

I'll close the bug manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

2017-11-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=387424

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
Patch at https://phabricator.kde.org/D9043

-- 
You are receiving this mail because:
You are the assignee for the bug.