[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 Luigi Toscano changed: What|Removed |Added CC||inkbottle...@gmail.com --- Comment #7 from Luigi Toscano --- *** Bug 398542 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 Nate Graham changed: What|Removed |Added Version Fixed In||18.08.1 CC||n...@kde.org -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/oku ||lar/0a8d2f7f85750d3852f256e ||bc8f0e8c9bad9fd84 Resolution|--- |FIXED --- Comment #6 from Albert Astals Cid --- Git commit 0a8d2f7f85750d3852f256ebc8f0e8c9bad9fd84 by Albert Astals Cid. Committed on 26/08/2018 at 23:09. Pushed by aacid into branch 'Applications/18.08'. Fix links being "lost" on save Summary: We need to regenerate the links when switching the file since we won't re-render the pages since we already have them and link generation is on page render Reviewers: tobiasdeiminger Reviewed By: tobiasdeiminger Subscribers: tobiasdeiminger, sander, okular-devel Tags: #okular Differential Revision: https://phabricator.kde.org/D14752 M +19 -0generators/poppler/generator_pdf.cpp https://commits.kde.org/okular/0a8d2f7f85750d3852f256ebc8f0e8c9bad9fd84 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 --- Comment #5 from Pastafarianist --- Original reporter here. I must say that your response time is very impressive, usually with open-source projects I have to wait for weeks or months for a fix. Great job! -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 --- Comment #4 from Tobias Deiminger --- (In reply to Albert Astals Cid from comment #3) > Tobias can you have a look at https://phabricator.kde.org/D14752 ? Wow, that was fast. Yes I'll have a look within the next two or three days. @Oliver: Will need to do a small writeup for myself to understand how Alberts diff is working. I'll share it, then you can check if it's suitable as explanation in code comment or git commit message (the later is easy to find with git blame, would also be ok for me). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de --- Comment #2 from Tobias Deiminger --- Also confirmed for Okular master. If you reload the document with F5, links work again and the bug is gone. So it's not the file itself that gets corrupted. While the bug is active, in PageView::updateCursor const Okular::ObjectRect * linkobj = pageItem->page()->objectRect( Okular::ObjectRect::Action, nX, nY, pageItem->uncroppedWidth(), pageItem->uncroppedHeight() ); is executed, but linkobj always gets assigned with nullptr. Had no time to dig deeper yet. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397373] Links no longer work after saving annotated PDF
https://bugs.kde.org/show_bug.cgi?id=397373 Oliver Sander changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC||oliver.san...@tu-dresden.de Ever confirmed|0 |1 --- Comment #1 from Oliver Sander --- Confirmed with current git master on Debian testing. -- You are receiving this mail because: You are the assignee for the bug.
