D10547: [PATCH] Recalculate forms after command form changes

[Albert Astals Cid]

aacid added a comment.


  can you add an autotest for this?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: aacid, ltoscano, michaelweghorn, ngraham

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke added a comment.


  In D10547#207085 , @ltoscano wrote:
  
  > (I can't comment on the content of the stream of the patches, but I think 
you don't need the [PATCH] in the title in any of them - they are clearly 
patches if they are defined here. And probably not even the (1/3) in the other 
patches)
  
  
  My intention with this is to make it obvious which differential is a 
standalone patch and which are parts of a series. But yes for standalone 
patches I will omit this. For a series I think it adds a bit clarity, 
especially if you exchange one patch in a series against another patch etc.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: ltoscano, michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Luigi Toscano]

ltoscano added a comment.


  (I can't comment on the content of the stream of the patches, but I think you 
don't need the [PATCH] in the title in any of them - they are clearly patches 
if they are defined here. And probably not even the (1/3) in the other patches)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: ltoscano, michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke created this revision.
aheinecke added a reviewer: Okular.
aheinecke added a project: Okular.
aheinecke requested review of this revision.

REVISION SUMMARY
  notifyFormChanged is called by documentcommands when
  Form fields are changed. E.g. by Undo / Redo.
  We need to recalculate after such changes.

TEST PLAN
  Tested with simple_calculate example.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

AFFECTED FILES
  core/document.cpp

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke added a task: T7805: Okular: Add support for JavaScript 
AFSimple_Calculate and textfield content calculation.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, simgunz, aacid