D12177: Make some frameworks optional so okular can be built on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R223:c325b342f316: Make some frameworks optional so okular can be built on Android (authored by apol, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12177?vs=32318=32334#toc

D12177: Make some frameworks optional so okular can be built on Android

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. I'll push it, i've fixed the removal of the #if 0 in scripter.cpp REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc:

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32318. apol added a comment. Oops REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32317=32318 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32317. apol added a comment. Unsure why it works on my system, adopt the same way to point to the path katepart uses REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32303=32317 BRANCH master REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32303. apol added a comment. Shouldn't comment the include... REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32302=32303 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32302. apol added a comment. Typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32296=32302 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12177: Make some frameworks optional so okular can be built on Android

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. HAVE_KWALLET is never defined REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32296. apol added a comment. Address Albert's concern REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32072=32296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

aacid added a comment. This is not ok. This change makes it so that people will be missing functionality without anyone warning them. If you really want to have this please make flags to explicitely make them optional and otherwise still make them required. REPOSITORY R223

D12177: Make some frameworks optional so okular can be built on Android

apol created this revision. apol added a reviewer: Okular. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Disables KWallet integration if there's no KWallet, KJS if there's no KJS and KDocTools. Here's a list of frameworks that don't