D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:5e622484c874: Fix problem of saving pdf switches from thumbnail view in sidebar to contents… (authored by ahmadosama, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14740?vs=39544&id=39567#toc REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14740?vs=39544&id=39567 REVISION DETAIL https://phabricator.kde.org/D14740 AFFECTED FILES autotests/parttest.cpp part.cpp ui/sidebar.h To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama added a comment. I updated the parttest.cpp, the tocreload.pdf file in the data directory reproduced this bug so I used it for the unit test. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama updated this revision to Diff 39544. ahmadosama added a comment. - Adding a unit test to check that document doesnot go back to contents view after saving REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14740?vs=39543&id=39544 BRANCH returning_to_contents_when_saving_bug (branched from master) REVISION DETAIL https://phabricator.kde.org/D14740 AFFECTED FILES autotests/parttest.cpp part.cpp ui/sidebar.h To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama updated this revision to Diff 39543. ahmadosama added a comment. - Adding a unit test to check that document doesnot go back to contents view after saving REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14740?vs=39438&id=39543 BRANCH returning_to_contents_when_saving_bug (branched from master) REVISION DETAIL https://phabricator.kde.org/D14740 AFFECTED FILES autotests/parttest.cpp part.cpp ui/sidebar.h To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
aacid added a comment. Do you think you could work on an autotest for this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: aacid, okular-devel, ngraham
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: okular-devel, ngraham, aacid
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama, #okular Cc: okular-devel, ngraham, aacid
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14740 To: ahmadosama Cc: okular-devel, ngraham, aacid
D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view
ahmadosama created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. ahmadosama requested review of this revision. REPOSITORY R223 Okular BRANCH returning_to_contents_when_saving_bug (branched from master) REVISION DETAIL https://phabricator.kde.org/D14740 AFFECTED FILES part.cpp To: ahmadosama Cc: okular-devel, ngraham, aacid
