D17194: Fix DjVu links pointing to pages with different dimensions

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:b04a2daa6bd8: Fix DjVu links pointing to pages with 
different dimensions (authored by akandaurov, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17194?vs=46330=46434#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17194?vs=46330=46434

REVISION DETAIL
  https://phabricator.kde.org/D17194

AFFECTED FILES
  generators/djvu/generator_djvu.cpp

To: akandaurov, #okular, aacid
Cc: aacid, okular-devel, ngraham, darcyshen

D17194: Fix DjVu links pointing to pages with different dimensions

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks good thanks :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17194

To: akandaurov, #okular, aacid
Cc: aacid, okular-devel, ngraham, darcyshen

D17194: Fix DjVu links pointing to pages with different dimensions

[Alexander Kandaurov]

akandaurov added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17194

To: akandaurov, #okular
Cc: okular-devel, ngraham, darcyshen, aacid

D17194: Fix DjVu links pointing to pages with different dimensions

[Alexander Kandaurov]

akandaurov created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
akandaurov requested review of this revision.

REVISION SUMMARY
  Currently the coordinates of a link rectangle in a DjVu document are computed 
with respect to the size of the page the link is pointing to. Because of that, 
links only appear in correct places if the dimensions of a target page are the 
same as of the page containing the link.
  
  The attached file demonstrating the issue contains two pages, one in portrait 
orientation and one in landscape, the first pointing to the second. The active 
zone for the link is different from where it is in other viewers.
  F6443987: misplaced-link.djvu 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17194

AFFECTED FILES
  generators/djvu/generator_djvu.cpp

To: akandaurov
Cc: okular-devel, ngraham, darcyshen, aacid