Re: Review Request 127366: Resize annotations

2017-03-19 Thread Tobias Deiminger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/ --- (Updated March 19, 2017, 10:18 p.m.) Status -- This change has been

Re: Review Request 127366: Resize annotations

2017-03-13 Thread Tobias Deiminger
> On März 11, 2017, 4:57 nachm., Albert Astals Cid wrote: > > Feature Freeze date for 17.04 is March 23, i suggest you try to > > workaround/disable the known bugs/todo since this sems a nice feature to > > get in. It can always be improved after it lands, but what lands needs to > > be

Re: Review Request 127366: Resize annotations

2017-03-13 Thread Tobias Deiminger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/ --- (Updated März 13, 2017, 11:42 nachm.) Review request for Okular.

Re: Review Request 127366: Resize annotations

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/#review102789 --- Feature Freeze date for 17.04 is March 23, i suggest you

Re: Review Request 127366: Resize annotations

2017-01-29 Thread Albert Astals Cid
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-29 Thread Tobias Deiminger
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-27 Thread Tobias Deiminger
> On April 7, 2016, 9:52 p.m., Jonathan Schultz wrote: > > Sorry I've been meaning to test this a bit more and only got to it today. > > > > I have a couple of minor comments: > > > > 1. The corner boxes do not seem to work - even though the mouse icon > > changes to indicate resizing,

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Jonathan Schultz
> On April 8, 2016, 7:52 a.m., Jonathan Schultz wrote: > > Sorry I've been meaning to test this a bit more and only got to it today. > > > > I have a couple of minor comments: > > > > 1. The corner boxes do not seem to work - even though the mouse icon > > changes to indicate resizing,

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Jonathan Schultz
> On April 8, 2016, 7:52 a.m., Jonathan Schultz wrote: > > Sorry I've been meaning to test this a bit more and only got to it today. > > > > I have a couple of minor comments: > > > > 1. The corner boxes do not seem to work - even though the mouse icon > > changes to indicate resizing,

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Albert Astals Cid
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Tobias Deiminger
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Tobias Deiminger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/ --- (Updated Jan. 26, 2017, 9:47 p.m.) Review request for Okular. Changes

Re: Review Request 127366: Resize annotations

2017-01-24 Thread Albert Astals Cid
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-24 Thread Tobias Deiminger
> On März 14, 2016, 12:46 vorm., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2017-01-23 Thread Oliver Sander
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-11-14 Thread Oliver Sander
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-11-13 Thread Tobias Deiminger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/ --- (Updated Nov. 13, 2016, 9:18 p.m.) Review request for Okular. Changes

Re: Review Request 127366: Resize annotations

2016-11-10 Thread Oliver Sander
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-10-27 Thread Jonathan Schultz
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-10-25 Thread Tobias Deiminger
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-10-25 Thread Oliver Sander
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: Review Request 127366: Resize annotations

2016-10-17 Thread Albert Astals Cid
> On Oct. 16, 2016, 8:16 p.m., Oliver Sander wrote: > > ui/pagepainter.h, line 36 > > > > > > That comma after '32' is not correct, is it? > > Tobias Deiminger wrote: > C++11 (7.2/1) and C99 (6.7.2.2) allow,

Re: Review Request 127366: Resize annotations

2016-10-17 Thread Tobias Deiminger
> On Okt. 16, 2016, 8:16 nachm., Oliver Sander wrote: > > ui/pagepainter.h, line 36 > > > > > > That comma after '32' is not correct, is it? C++11 (7.2/1) and C99 (6.7.2.2) allow, but don't require trailing

Re: Review Request 127366: Resize annotations

2016-10-16 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/#review100047 --- ui/pagepainter.h (line 36)

Re: Review Request 127366: Resize annotations

2016-10-09 Thread Carl-Daniel Hailfinger
> On März 14, 2016, 12:46 vorm., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try