Re: Review Request 129216: Support SetOCGState links

2016-11-26 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129216/
---

(Updated Nov. 26, 2016, 3:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 2868e3e5ca802dd4decfdeb1dded82394a4c34b6 by Albert Astals 
Cid to branch master.


Bugs: 368402
http://bugs.kde.org/show_bug.cgi?id=368402


Repository: okular


Description
---

Implement OCGState links in the pdf backend.

In not very convinced with the opaque action stuff, but i don't see other way 
of implementing it.

Needs the patch from https://bugs.freedesktop.org/show_bug.cgi?id=98312


Diffs
-

  cmake/modules/FindPoppler.cmake 11af41e 
  core/action.h 8a9c3c2 
  core/action.cpp 7c7b09c 
  core/document.cpp 6953b1f 
  core/generator.h 68a7f14 
  core/generator.cpp 79fc6eb 
  generators/poppler/config-okular-poppler.h.cmake c3e9b18 
  generators/poppler/generator_pdf.h 7d2c8e8 
  generators/poppler/generator_pdf.cpp a65487a 

Diff: https://git.reviewboard.kde.org/r/129216/diff/


Testing
---

The links on page 4 of the file in the linked bug work.


Thanks,

Albert Astals Cid



Review Request 129216: Support SetOCGState links

2016-10-18 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129216/
---

Review request for Okular.


Bugs: 368402
http://bugs.kde.org/show_bug.cgi?id=368402


Repository: okular


Description
---

Implement OCGState links in the pdf backend.

In not very convinced with the opaque action stuff, but i don't see other way 
of implementing it.

Needs the patch from https://bugs.freedesktop.org/show_bug.cgi?id=98312


Diffs
-

  cmake/modules/FindPoppler.cmake 11af41e 
  core/action.h 8a9c3c2 
  core/action.cpp 7c7b09c 
  core/document.cpp 6953b1f 
  core/generator.h 68a7f14 
  core/generator.cpp 79fc6eb 
  generators/poppler/config-okular-poppler.h.cmake c3e9b18 
  generators/poppler/generator_pdf.h 7d2c8e8 
  generators/poppler/generator_pdf.cpp a65487a 

Diff: https://git.reviewboard.kde.org/r/129216/diff/


Testing
---

The links on page 4 of the file in the linked bug work.


Thanks,

Albert Astals Cid