Jeremy, Very nice patch - thanks for all your work and setting up the jobs in all the calls last week - this verify job is useful. Verified that a busted helm (on purpose) patch now gets caught during the helm-verify - before merge https://gerrit.onap.org/r/#/c/63641/ -{{ tpl (.Files.Glob +{{ tplx (.Files.Glob https://jenkins.onap.org/job/oom-master-verify-helm/209/console 00:18:20 [ERROR] templates/: parse error in "pomba/charts/pomba-search-data/templates/configmap.yaml": template: pomba/charts/pomba-search-data/templates/configmap.yaml:7: function "tplx" not defined
Verified - OK Issue closed /michael -----Original Message----- From: Jeremy Phelps via RT <onap-helpd...@rt.linuxfoundation.org> Sent: Wednesday, August 29, 2018 6:31 PM To: Michael O'Brien <frank.obr...@amdocs.com> Cc: onap-discuss@lists.onap.org Subject: [ONAP Helpdesk #60323] RE: [deploy] helm verify job failing - being worked on Hi All, Here is a patch that fixes the helm verify job to checkout the gerrit patch instead of tip of master. https://gerrit.onap.org/r/63627 Jeremy On Wed Aug 29 18:07:05 2018, frank.obr...@amdocs.com wrote: > Prudence Au, Mandeep and I triaged this. > > There were 2 issues > > 1. The oom-master-verify-helm job (new) does not cherry-pick changes > – it runs directly from master prior to merges > * (note that this helm verify job is new from last week – there > have not been a lot of merge testing – so this is part of verification > testing in a way) > * The effect of this is that a helm-verify job that should fail – > does not – later the master-merge-helm job fails > * Any attempt to fix the build can only be done in the small > window before the jobbuilder (verify-helm) runs and puts a -1 on the > review > > (Mandeep did one of these for us) > > 1. The copyright symbol caused issues in the make job inside of the > helm verify job > * Removing the symbol (in this case) worked locally but required > the quick slip under the jobbuilder to get a +1 > * Copying the CR symbol from another helm chart also worked > > > > Fix required: > > TODO: The verify-helm job needs to be adjusted so that it picks up the > review instead of running only on the merged master branch > > Thanks > /Mandeep, Prudence, Michael > > From: onap-discuss@lists.onap.org <onap-discuss@lists.onap.org> On > Behalf Of Michael O'Brien > Sent: Wednesday, August 29, 2018 4:22 PM > To: onap-discuss@lists.onap.org > Subject: [onap-discuss] [deploy] helm verify job failing - being > worked on > > OOM deployers, > There is currently an issue with one of the charts – the > effect of any broken chart breaks the make for all of onap – hence the > helm verify job. > We are looking at fixing this right now – usually this > “UTF-8 octet” means windows to unix DB char issues. > > The [make all] as part of the master-merge-helm correctly identified > this broken chart – thanks Jeremy of the LF. > > So the procedure for merging after talking with Mike and Mandeep now > included waiting for the helm verify jobs – and every developer that > gets their review merged should also check the post-merge helm job to > make sure the build is OK for the next developer. > > Let the jobbuilder kick in – it runs the helm verify – then merge the > code In this case patchset 3 was committed – helm verify [master > level] ran OK > > https://gerrit.onap.org/r/#/c/61111/3 > https://jenkins.onap.org/job/oom-master-verify-helm/182/ > > 14:20:59 [pomba] > > 14:20:59 make[1]: Entering directory '/w/workspace/oom-master-verify- > helm/kubernetes' > > 14:20:59 Hang tight while we grab the latest from your chart > repositories... > > 14:20:59 ...Successfully got an update from the "local" chart > repository > > 14:21:00 ...Successfully got an update from the "stable" chart > repository > > 14:21:00 Update Complete. ⎈Happy Helming!⎈ > > 14:21:00 Saving 1 charts > > 14:21:00 Downloading common from repo > http://127.0.0.1:8879<http://127.0.0.1:8879/> > > 14:21:01 Deleting outdated charts > > 14:21:01 ==> Linting pomba > > 14:21:01 [INFO] Chart.yaml: icon is recommended > > 14:21:01 > > 14:21:01 1 chart(s) linted, no failures > > 14:21:01 Successfully packaged chart and saved it to: > /w/workspace/oom-master-verify-helm/kubernetes/dist/packages/pomba- > 2.0.0.tgz > > 14:21:01 make[1]: Leaving directory '/w/workspace/oom-master-verify- > helm/kubernetes' > > 14:21:01 > > > The merge-helm was the issue - > https://jenkins.onap.org/job/oom-master-merge-helm/29/console > > 19:18:56 make[1]: Entering directory '/w/workspace/oom-master-merge- > helm/kubernetes' > 19:18:57 Error: error unpacking pomba-search-data in pomba: error > converting YAML to JSON: yaml: invalid leading UTF-8 octet > 19:18:57 Makefile:42: recipe for target 'dep-pomba' failed > > Looks like the issue was between the runs – something went in between > 14:21 and 19:18 – where the automated merge busted one of the yamls > > /michael > This message and the information contained herein is proprietary and > confidential and subject to the Amdocs policy statement, you may > review at https://www.amdocs.com/about/email-disclaimer > > This message and the information contained herein is proprietary and > confidential and subject to the Amdocs policy statement, > > you may review at https://www.amdocs.com/about/email-disclaimer > <https://www.amdocs.com/about/email-disclaimer> This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at https://www.amdocs.com/about/email-disclaimer <https://www.amdocs.com/about/email-disclaimer> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12134): https://lists.onap.org/g/onap-discuss/message/12134 Mute This Topic: https://lists.onap.org/mt/25088931/21656 Group Owner: onap-discuss+ow...@lists.onap.org Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
