Re: svx/source/svdraw/svdfmtf.cxx

2012-05-21 Thread Andre Fischer
On 20.05.2012 13:30, Armin Le Grand wrote: Hi Pavel, Pavel Janíkpa...@janik.cz wrote: Hi, WaE = Warning as Error. or Warnings Are Errors. Gcc option -Werror: Make all warnings into errors. With this option turned on, all warnings are made into errors. Our long term goal is to make gcc

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-21 Thread Armin Le Grand
Hi, On 21.05.2012 11:34, Andre Fischer wrote: On 20.05.2012 13:30, Armin Le Grand wrote: Hi Pavel, [..] Who will check in the changes? Already did, Pavel is informed. -Andre Sincerely, Armin -- ALG

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-21 Thread Pavel Janík
On May 21, 2012, at 2:24 PM, Armin Le Grand wrote: Who will check in the changes? Already did, Pavel is informed. svx module is WaE clean now. Will continue with cui and chart2 now. -- Pavel Janík

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-21 Thread Herbert Duerr
On 21.05.2012 11:34, Andre Fischer wrote: [...] I thought that most of non-binfilter code was WaE-safe. The code base was WaE-clean only for certain compiler versions. IIRC gcc4.2 on Linux, gcc4.0 on OSX and VC2008 on Win. But improved (or any changed) compilers often provide new warnings

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-21 Thread Pavel Janík
Anyway, we should still try to keep/make our code WaE-safe. It can only improve its quality. +1, but we should avoid diminishing the code's readability too much by it. Yes. This is the reason why I'd like to see lines like default: break; commented ;-)) -- Pavel Janík

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-20 Thread Armin Le Grand
Hi Pavel, Pavel Janík pa...@janik.cz wrote: Hi, WaE = Warning as Error. or Warnings Are Errors. Gcc option -Werror: Make all warnings into errors. With this option turned on, all warnings are made into errors. Our long term goal is to make gcc silent. Ah, yes, I remember now. We

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-19 Thread Armin Le Grand
Hi Pavel, I worked on it. What do you mean with WaE? I googled, but couild not find explanations. I know there was something, but I do not want to rely on guessing. Pavel Janík pa...@janik.cz wrote: Hi, this file in the trunk has several WaE issues: http://tmp.janik.cz/AOOo/svx-WaE.diff

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-19 Thread Marcus (OOo)
Am 05/19/2012 01:22 PM, schrieb Armin Le Grand: Hi Pavel, I worked on it. What do you mean with WaE? I googled, but couild not find explanations. I know there was something, but I do not want to rely on guessing. WaE = Warning as Error. HTH Marcus Pavel Janíkpa...@janik.cz wrote: Hi,

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-19 Thread Armin Le Grand
Marcus (OOo) marcus.m...@wtnet.de wrote: Am 05/19/2012 01:22 PM, schrieb Armin Le Grand: Hi Pavel, I worked on it. What do you mean with WaE? I googled, but couild not find explanations. I know there was something, but I do not want to rely on guessing. WaE = Warning as Error. Ah, okay,

Re: svx/source/svdraw/svdfmtf.cxx

2012-05-19 Thread Pavel Janík
Hi, WaE = Warning as Error. or Warnings Are Errors. Gcc option -Werror: Make all warnings into errors. With this option turned on, all warnings are made into errors. Our long term goal is to make gcc silent. These issues are not errors per se, but e.g.: @@ -1330,6 +1331,7 @@ void