Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
Neither of those APIs should be necessary in 4.0. RexxStart will now behave the way it should always have behaved and wait for all threads started by the executed program to terminate. I hadn't realized those APIs had actually been documented. I think I'll need to add back in some stubbed replacements that just return immediately and document them as deprecated. Rick On Sun, Jan 4, 2009 at 6:13 AM, Rony G. Flatscher rony.flatsc...@wu-wien.ac.at wrote: Bonjour Jean-Louis, great that you are tackling BSF4Rexx on ooRexx 4.0 already! Under Windows, the current version of BSF4Rexx (2008-09-12) does not work with ooRexx 4.0. BSF4Rexx.dll is not loaded because it depends on these functions which are no longer exported by rexx.dll : RexxWaitForTermination RexxDidRexxTerminate I recompiled BSF4Rexx without these dependencies (is it safe to do that ?) Under pre 4.0 ooRexx it is mandatory to have these available. The reason: if ooRexx programs run multithreaded then the threads need to be able to continue, even if the main thread has finished already. Not sure how 4.0 behaves. So I would at least do a conditional include, i.e. do not include them if compiled for ooRexx 4.0, until Rick can clarify the behaviour on 4.0. An other problem occurred : call rxFuncAdd BsfLoadFuncs, BSF4Rexx, BsfLoadFuncs fails, because ooRexx 4.0 searches for BsfLoadFuncs and does not find it (it's BSFLOADFUNCS which is exported). Easy to fix, use call rxFuncAdd BsfLoadFuncs, BSF4Rexx, BSFLOADFUNCS (4.0 is more strict than 3.2, other external packages may need this kind of adjustment) Interesting. Now, infoBSF.rex and infoBSF-oo.rex works. Super! During my trials and errors, I had several times the script infoBSF.rex frozen during initialization. Maybe the problem comes from rxapi.exe. RegistrationData::findSessionReference in RegistrationManager.cpp, I think this line is missing : cookie = cookie-next Here are the changes I made to BSF.cc (all are fixes for compilation errors due to changes in rexx.h) : If you can supply a unified diff, I would apply it to the original source (license is http://www.apache.org/licenses/LICENSE-2.0). Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
Rony, I uploaded the changes to the patches tracker for BSF4Rexx. There is a new target oorexx4 in the makefile (for Window only). It defines the variable USE_OOREXX4 which is used for conditional compilation (I leave you decide if that's the good way) I use Visual C++ 2008 Express Edition, and I had to remove INITINSTANCE from BSF4Rexx.def (syntax error). No longer needed to modify the call RxFuncLoad, thanks to Rick. It's really impressive to see BSF4Rexx working like a breeze with ooRexx 4, without no change at all ! Tested with jre1.6.0_11 Jean-Louis Rony G. Flatscher rony.flatsc...@wu-wien.ac.at 04/01/2009 20:02 Please respond to Open Object Rexx Developer Mailing List oorexx-devel@lists.sourceforge.net To Open Object Rexx Developer Mailing List oorexx-devel@lists.sourceforge.net cc Subject Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ? Rick McGuire wrote: Neither of those APIs should be necessary in 4.0. RexxStart will now behave the way it should always have behaved and wait for all threads started by the executed program to terminate. I hadn't realized those APIs had actually been documented. I think I'll need to add back in some stubbed replacements that just return immediately and document them as deprecated. Thank you, just saw that you already took care of it in today's rev 3861 which is great. ---rony On Sun, Jan 4, 2009 at 6:13 AM, Rony G. Flatscher rony.flatsc...@wu-wien.ac.at wrote: Bonjour Jean-Louis, great that you are tackling BSF4Rexx on ooRexx 4.0 already! Under Windows, the current version of BSF4Rexx (2008-09-12) does not work with ooRexx 4.0. BSF4Rexx.dll is not loaded because it depends on these functions which are no longer exported by rexx.dll : RexxWaitForTermination RexxDidRexxTerminate I recompiled BSF4Rexx without these dependencies (is it safe to do that ?) Under pre 4.0 ooRexx it is mandatory to have these available. The reason: if ooRexx programs run multithreaded then the threads need to be able to continue, even if the main thread has finished already. Not sure how 4.0 behaves. So I would at least do a conditional include, i.e. do not include them if compiled for ooRexx 4.0, until Rick can clarify the behaviour on 4.0. An other problem occurred : call rxFuncAdd BsfLoadFuncs, BSF4Rexx, BsfLoadFuncs fails, because ooRexx 4.0 searches for BsfLoadFuncs and does not find it (it's BSFLOADFUNCS which is exported). Easy to fix, use call rxFuncAdd BsfLoadFuncs, BSF4Rexx, BSFLOADFUNCS (4.0 is more strict than 3.2, other external packages may need this kind of adjustment) Interesting. Now, infoBSF.rex and infoBSF-oo.rex works. Super! During my trials and errors, I had several times the script infoBSF.rex frozen during initialization. Maybe the problem comes from rxapi.exe. RegistrationData::findSessionReference in RegistrationManager.cpp, I think this line is missing : cookie = cookie-next Here are the changes I made to BSF.cc (all are fixes for compilation errors due to changes in rexx.h) : If you can supply a unified diff, I would apply it to the original source (license is http://www.apache.org/licenses/LICENSE-2.0). Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
Bonjour Jean-Louis, I uploaded the changes to the patches tracker for BSF4Rexx. Great, thank you very much! There is a new target oorexx4 in the makefile (for Window only). It defines the variable USE_OOREXX4 which is used for conditional compilation (I leave you decide if that's the good way) I use Visual C++ 2008 Express Edition, and I had to remove INITINSTANCE from BSF4Rexx.def (syntax error). Yes, that stems from the OS/2 days. No longer needed to modify the call RxFuncLoad, thanks to Rick. It's really impressive to see BSF4Rexx working like a breeze with ooRexx 4, without no change at all ! Tested with jre1.6.0_11 Great, again thank you very much for your work and information/feedback! --- Did you by any chance try a BSF4Rexx.dll which was compiled against ooRexx 3.2, i.e. the one from the distribution that can be found at http://wi.wu-wien.ac.at/rgf/rexx/bsf4rexx/current/? (Just curious, whether it would work with the latest drop of ooRexx 4.0 too.) Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
Roni, I confirm that the current distribution built with ooRexx 3.2 works well with ooRexx 4, after the changes made by Rick today. All the scripts in samples run without problem, from rexx or from java. Only Snippet108.rex is not running, I suppose I don't have SWT. Even not a little bug to shake out :-) or maybe a potential one, not in relation with BSF : in RegistrationManager.cpp, RegistrationData::removeSessionReference : when the cookie is found in the loop, then it's deleted twice. Jean-Louis Rony G. Flatscher rony.flatsc...@wu-wien.ac.at 04/01/2009 23:21 Please respond to Open Object Rexx Developer Mailing List oorexx-devel@lists.sourceforge.net To Open Object Rexx Developer Mailing List oorexx-devel@lists.sourceforge.net cc Subject Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ? Bonjour Jean-Louis, I uploaded the changes to the patches tracker for BSF4Rexx. Great, thank you very much! There is a new target oorexx4 in the makefile (for Window only). It defines the variable USE_OOREXX4 which is used for conditional compilation (I leave you decide if that's the good way) I use Visual C++ 2008 Express Edition, and I had to remove INITINSTANCE from BSF4Rexx.def (syntax error). Yes, that stems from the OS/2 days. No longer needed to modify the call RxFuncLoad, thanks to Rick. It's really impressive to see BSF4Rexx working like a breeze with ooRexx 4, without no change at all ! Tested with jre1.6.0_11 Great, again thank you very much for your work and information/feedback! --- Did you by any chance try a BSF4Rexx.dll which was compiled against ooRexx 3.2, i.e. the one from the distribution that can be found at http://wi.wu-wien.ac.at/rgf/rexx/bsf4rexx/current/? (Just curious, whether it would work with the latest drop of ooRexx 4.0 too.) Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
Bonjour Jean-Louis, I confirm that the current distribution built with ooRexx 3.2 works well with ooRexx 4, after the changes made by Rick today. All the scripts in samples run without problem, from rexx or from java. That's really great news! Only Snippet108.rex is not running, I suppose I don't have SWT. Yes, you would need to get it from http://www.eclipse.org/swt/. After that, all of Eclipse's swt-gadgets are available to you (and transcribing the Java snippets to ooRexx using BSF4Rexx is quite straight-forward) ... Even not a little bug to shake out :-) :-) Nevertheless, your work on making BSF4Rexx compile with ooRexx 4.0 is highly appreciated as it will get incorporated (after the ski-seminar which starts this week, our winter term goes on until the end of January over here), before starting one long-outstanding/planned enhancement to BSF4Rexx which is only possible with ooRexx 4.0, which will allow for call backs. [For that I will have to study the addressing of specific running ooRexx interpreter instances as well as ooRexx threads and addressing ooRexx objects therein.] Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] BSF4Rexx and ooRexx 4.0 : (tiny) adjustments needed - and a bug in rxapi.exe ?
On Sun, Jan 4, 2009 at 6:33 PM, Rony G. Flatscher rony.flatsc...@wu-wien.ac.at wrote: Bonjour Jean-Louis, I confirm that the current distribution built with ooRexx 3.2 works well with ooRexx 4, after the changes made by Rick today. All the scripts in samples run without problem, from rexx or from java. That's really great news! Only Snippet108.rex is not running, I suppose I don't have SWT. Yes, you would need to get it from http://www.eclipse.org/swt/. After that, all of Eclipse's swt-gadgets are available to you (and transcribing the Java snippets to ooRexx using BSF4Rexx is quite straight-forward) ... Even not a little bug to shake out :-) :-) Nevertheless, your work on making BSF4Rexx compile with ooRexx 4.0 is highly appreciated as it will get incorporated (after the ski-seminar which starts this week, our winter term goes on until the end of January over here), before starting one long-outstanding/planned enhancement to BSF4Rexx which is only possible with ooRexx 4.0, which will allow for call backs. [For that I will have to study the addressing of specific running ooRexx interpreter instances as well as ooRexx threads and addressing ooRexx objects therein.] And all questions about this can be asked here. Rick Regards, ---rony -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel -- ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
