Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Enrico Sorichetti via Oorexx-devel
As a temporary workaround for what I feel is a overly complicated repository setup Subversion_WC_INFO(${PROJECT_SOURCE_DIR} ORX IGNORE_SVN_FAILURE ) Enrico > On 17 Sep 2019, at 13:44, Rick McGuire wrote: > > I'm open to other suggestions. I at least solves part of the problem, but is >

Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Rick McGuire
I'm open to other suggestions. I at least solves part of the problem, but is perhaps incomplete. Do you have another other suggestions on how to test for this? Rick On Tue, Sep 17, 2019 at 6:51 AM Erich Steinböck wrote: > > if( EXISTS ${CMAKE_SOURCE_DIR}/.svn ) > I don't think this is a good

Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Erich Steinböck
> if( EXISTS ${CMAKE_SOURCE_DIR}/.svn ) I don't think this is a good solution, as it depends on how you check out sources. If you check out main/trunk, main/trunk/.svn will exist But if you check out main, no main/trunk/.svn will exist (only main/.svn)

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel
Hi René Use if( EXISTS ${CMAKE_SOURCE_DIR}/.svn ) find_package(Subversion) if(SUBVERSION_FOUND) set(ORX_WC_REVISION 0) Subversion_WC_INFO(${PROJECT_SOURCE_DIR} ORX) set(ORX_BLD_LVL ${ORX_WC_REVISION}) endif() message(STATUS "SVN Revision Number is

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread René Jansen
Hi Enrico, can you make it so that cmake does not choke on an absent svn? Working revisions on git is a bonus but I don’t really need that - and they are uuids. I’m all for git, in fact this is one of the last svn instances I pull from. But I don’t want to start that discussion, I just want to

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel
The test are coming out pretty well Buillt from a SVN repo Open Object Rexx Version 5.0.0 r11911 Svn[11911+] Build date: Sep 13 2019 Addressing mode: 64 Copyright (c) 1995, 2004 IBM Corporation. All rights reserved. Copyright (c) 2005-2019 Rexx Language Association. All rights reserved. The “+”

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Rick McGuire
Yes, I object to the removal. Including the revision number information is a helpful tool for problem determination. I much prefer Enrico's suggestion to enhance this to obtain the revision number from other sources as well. Rick On Fri, Sep 13, 2019 at 12:18 AM René Jansen wrote: > I am

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel
If You want I can provide the code to extract the revision information from git and mercurial repositories also The current bug is that the cmakelists does not check for the presence of the .svn hidden directory Best regards Enrico > On 13 Sep 2019, at 06:17, René Jansen wrote: > > I am