Re: [OPEN-ILS-DEV] Functions for updating the call number label or owning_lib associated with a copy

2011-04-14 Thread Ben Ostrowsky
On Wed, Apr 13, 2011 at 7:46 PM, Thomas Berezansky tsb...@mvlc.org wrote: Hopefully without the HTML wrapping? ;) Oh, for heaven's sake... yes. The Google netbook is pretty awesome, but leads to some wacky workarounds. -- Two functions for updating copy information (call number label and

Re: [OPEN-ILS-DEV] Functions for updating the call number label or owning_lib associated with a copy

2011-04-14 Thread Galen Charlton
Hi, On Apr 14, 2011, at 9:36 AM, Dan Scott wrote: I would probably just bash out something like: UPDATE asset.call_number SET label = 'MYS ' || label WHERE id IN ( SELECT acn.id FROM asset.call_number acn INNER JOIN asset.copy ac ON ac.call_number = acn.id INNER

Re: [OPEN-ILS-DEV] OpenSRF - C Unit Testing

2011-04-14 Thread Bill Erickson
Kevin, This is great stuff. I'm not (yet) familiar with Check, but the approach looks sane and I like the unit tests. (I'd say the fact that 95% of the patch is actually unit test code is a really good sign). I hope to apply the patch soon and take it for a spin. kbeswick++ -b On Mon, Apr

[OPEN-ILS-DEV] opensrf.js Unit Tests and Fix

2011-04-14 Thread Kevin Beswick
Hello, Attached are two patches. The first one contains some unit tests for the first half of opensrf.js. These make use of the DOH (Dojo Objective Harness) framework that Dan Scott had put into place in this commit: http://svn.open-ils.org/trac/OpenSRF/changeset/2217/ The second patch contains

Re: [OPEN-ILS-DEV] Functions for updating the call number label or owning_lib associated with a copy

2011-04-14 Thread Galen Charlton
Hi, On Apr 14, 2011, at 2:54 PM, Dan Scott wrote: You snipped out the concerns I expressed about testing and maintaining these functions. Say what you will about the state of testing of the existing database functions, at least there's a chance that they will be exercised and deficiencies

Re: [OPEN-ILS-DEV] Functions for updating the call number label or owning_lib associated with a copy

2011-04-14 Thread Galen Charlton
Hi, On Apr 14, 2011, at 4:07 PM, Galen Charlton wrote: The routines in question are being actively used now, and would not stop being used just because they get added to core. In fact, if they're sufficiently useful, they'll be tested more. Even absent a formal test plan, it beats the