On Wed, Nov 11, 2009 at 10:48 PM, Dan Scott d...@coffeecode.net wrote:
On Wed, 2009-11-11 at 22:00 -0500, Warren Layton wrote:
I don't know what you think of this patch.
I think it's a great patch.
Thanks!
In my opinion, the only thing that we would want is a DCO.
Darn - I _always_
On Thu, Nov 12, 2009 at 12:21 AM, Jason Etheridge ja...@esilibrary.comwrote:
There was talk recently of using natural keys for some tables like
permission.perm_list. It has my vote.
Incidentally, the reason why we're so concerned about consistent key
values is for oils_i18n_gettext, which
On Thu, 2009-11-12 at 11:51 -0500, Warren Layton wrote:
On Thu, Nov 12, 2009 at 11:17 AM, Joe Atzberger
jatzber...@esilibrary.com wrote:
On Thu, Nov 12, 2009 at 12:21 AM, Jason Etheridge ja...@esilibrary.com
wrote:
Incidentally, the reason why we're so concerned about consistent key
On Thu, 2009-11-12 at 07:40 -0500, Warren Layton wrote:
On Wed, Nov 11, 2009 at 10:48 PM, Dan Scott d...@coffeecode.net wrote:
On Wed, 2009-11-11 at 22:00 -0500, Warren Layton wrote:
I don't know what you think of this patch.
I think it's a great patch.
Thanks!
In my opinion,
I don't know what you think of this patch. I wrote it up after
noticing the following comment in the
Open-ILS/src/sql/Pg/950.data.seed-values.sql file:
-- XXX Incomplete base permission setup. A patch would be appreciated.
Now, I have no idea what the base permission setup should look like
On Wed, 2009-11-11 at 22:00 -0500, Warren Layton wrote:
I don't know what you think of this patch.
I think it's a great patch.
I wrote it up after
noticing the following comment in the
Open-ILS/src/sql/Pg/950.data.seed-values.sql file:
-- XXX Incomplete base permission setup. A patch
Subquerying is the way I initially approached such problems also, but the DB
updates are clearly built around explicitly trying to keep the ids the same
between installations. To solve the problem that users might add their own
values, the counter for the next id in almost all tables is set to
That is to say, if you added a new permission, you would almost certainly
take 351 too,
and necessarily have a conflict with my new patch, whereas the chance that
you would
select HOLD_LOCAL_AVAIL_OVERRIDE for the key is minimal.
There was talk recently of using natural keys for some
There was talk recently of using natural keys for some tables like
permission.perm_list. It has my vote.
Incidentally, the reason why we're so concerned about consistent key
values is for oils_i18n_gettext, which needs pinned values to
associate with translations.
--
Jason Etheridge
| VP,
