Re: [OPEN-ILS-DEV] Integrating automated code analysis tools into regular practice?

2007-11-26 Thread Bill Erickson
Scott McKellar wrote: --- Dan Scott [EMAIL PROTECTED] wrote: snip I just ran PMD (a code copy paste detector from http://pmd.sourceforge.net/) against OpenSRF trunk and it found some large chunks of duplicated code that we could probably refactor into a single shared block of code -

[OPEN-ILS-DEV] OpenSRF Makefile, source, bourne shell, bash, dash

2007-11-26 Thread Jason Etheridge
This came up before (http://list.georgialibraries.org/pipermail/open-ils-dev/2007-July/001451.html), but I was installing OpenSRF on Kubuntu and got this error: CFLAGS=-D_LARGEFILE64_SOURCE make verbose source install.conf make -C src all /bin/sh: source: not found make: *** [verbose] Error 127

Re: [OPEN-ILS-DEV] OpenSRF Makefile, source, bourne shell, bash, dash

2007-11-26 Thread Bill Erickson
Jason Etheridge wrote: This came up before (http://list.georgialibraries.org/pipermail/open-ils-dev/2007-July/001451.html), but I was installing OpenSRF on Kubuntu and got this error: CFLAGS=-D_LARGEFILE64_SOURCE make verbose source install.conf make -C src all /bin/sh: source: not found make:

Re: [OPEN-ILS-DEV] PATCH: osrf_app_session.[ch] (misc. cleanup)

2007-11-26 Thread Mike Rylander
On Nov 23, 2007 4:40 PM, Scott McKellar [EMAIL PROTECTED] wrote: These patches are a motley collection of cleanups. Summary: Applied. Cleanup++ -- Mike Rylander | VP, Research and Design | Equinox Software, Inc. / The Evergreen Experts | phone: 1-877-OPEN-ILS (673-6457) | email:

Re: [OPEN-ILS-DEV] PATCH: oils_auth.c (misc. cleanup)

2007-11-26 Thread Mike Rylander
On Nov 25, 2007 6:15 PM, Scott McKellar [EMAIL PROTECTED] wrote: This patch includes miscellaneous cleanups. Summary: Applied. -- Mike Rylander | VP, Research and Design | Equinox Software, Inc. / The Evergreen Experts | phone: 1-877-OPEN-ILS (673-6457) | email: [EMAIL PROTECTED] |