Re: [OPEN-ILS-DEV] PATCH: osrf_json_object.c (tweaks)

2007-12-09 Thread Mike Rylander
On Dec 8, 2007 1:52 PM, Scott McKellar [EMAIL PROTECTED] wrote: These patches tidy up a few things and introduce a modest performance boost. Summary: Applied. As an aside, I think Bill's design inside the parser was to model a SAX parser, which would allow for construction of differently

Re: [OPEN-ILS-DEV] PATCH: osrf_json_object.c (tweaks)

2007-12-09 Thread Bill Erickson
Scott McKellar wrote: I've never used a SAX-style parser, but as I understand it, the idea is to parse the data stream incrementally, and respond to syntactic features as you encounter them. The alternative DOM-style approach is to load the whole thing into memory at once in some kind of data

[OPEN-ILS-DEV] PATCH: utils.c (faster buffer_add_char)

2007-12-09 Thread Scott McKellar
This patch provides a faster implementation of buffer_add_char(). It also replaces malloc() with calloc() in safe_calloc(), and removes the memset(). The behavior should be identical, but there is a chance that calloc() will be trivially more efficient, depending on how the standard library is

Re: [OPEN-ILS-DEV] PATCH: utils.c (faster buffer_add_char)

2007-12-09 Thread Mike Rylander
On Dec 9, 2007 7:04 PM, Scott McKellar [EMAIL PROTECTED] wrote: This patch provides a faster implementation of buffer_add_char(). Applied. [snip] I have three further suggestions for the handling of growing_buffers. I didn't want to make these changes on my own without discussion. 1.