Re: [OPEN-ILS-DEV] Dubious code in mod_xmlbuilder.c

2008-01-15 Thread Bill Erickson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Scott McKellar wrote: In mod_xmlbuilder.c, xmlBuilderStartElement() contains the following fragment of code (condensed here for brevity): char* href = strdup(xmlSaxAttr( atts, href )); if(href) { ...snip... }

Re: [OPEN-ILS-DEV] component.c -- compile error

2008-01-15 Thread Bill Erickson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Scott McKellar wrote: I'd submit a patch, but I'm not sure what was intended. It is old, unused, out of date test code. I'll remove from the repository. Thanks Scott, - -bill - -- Bill Erickson | VP, Software Development Integration |

[OPEN-ILS-DEV] PATCH: osrf_json_gateway.c (memory leaks)

2008-01-15 Thread Scott McKellar
This patch plugs a few more memory leaks, and replaces some deprecated identifiers with their camel-case equivalents. 1. In osrf_json_gateway_child_init(): we were leaking allowedServices. 2. In osrf_json_gateway_method_handler(): we were leaking the jsonObject arr. 3. Also in