Re: [OPEN-ILS-DEV] PATCH: apachetools.c (performance)

2008-05-15 Thread Bill Erickson
On Tuesday 13 May 2008 11:54 Scott McKellar wrote:
 This patch is mostly a performance tweak, but also tidies up a few
 things.

Applied.  Thanks for the cleanup!

-bill

-- 
Bill Erickson
| VP, Software Development  Integration
| Equinox Software, Inc. / The Evergreen Experts
| phone: 877-OPEN-ILS (673-6457)
| email: [EMAIL PROTECTED]
| web: http://esilibrary.com


Re: [OPEN-ILS-DEV] SPAM: autoconf support for openSRF

2008-05-15 Thread Kevin Beswick
I am planning on it now!

On Wed, May 14, 2008 at 1:15 PM, Mike Rylander [EMAIL PROTECTED] wrote:
 On Wed, May 14, 2008 at 11:53 AM, Kevin Beswick
 [EMAIL PROTECTED] wrote:
 This is an initial patch supporting the effort of porting OpenSRF to
  the GNU autotools.

 AWESOME! Great work Kevin.

 Quick question for the future ... are you planning {foo}-config
 support?  That will allow us to ask the system where the libs and
 headers are installed to override the default without having to
 specify the location of the header files for the dependencies that
 support that mechanism.  For instance, postgres has pg_config that
 will spit out things like INCLUDEDIR, and libxml2 has xml2_config the
 does something similar.

 Again, great work.



  The goal of this patch is to enable someone to generate a configure
  script using autoconf, allow someone to choose various install options
  through the generated configure script, and to remove the need for the
  install.conf file.


 /me adds another step to the release process...

  The configure script makes various checks based on the dependencies of
  openSRF, allows users to customize the install directories, and select
  various install options (whether or not to install python modules,
  java libraries, legacy json headers). It outputs the results of these
  custom checks/settings at the end of the default configure script
  output.

  The automake Makefile.am's are not included as of yet, instead only
  Makefile.in's are included so that configure can generate appropriate
  Makefiles based on the already existing ones.

  To test:
  automake -a
  autoconf
  ./configure [--option]
  make
  make install

  Options included in configure script:

  --enable-install-java#enable building and installing the java libraries
  --disable-legacy-json#disable the legacy json headers and .so file
  for backwards compatibility
  --disable-install-python  #disable building and installing python modules
  --with-tmp_dir=path  #location for the tmp dir for openSRF
  (/tmp/ilstemp by default)
  --with-apxs_dir=path #location of apxs2 (default is 
 /usr/bin/apxs2)
  --with-apache_headers=path   #location of the apache2 headers
  (default is /usr/include/apache2)
  --with-apr_headers=path   #location of the apr headers
  (default is /usr/include/apr-1.0/)
  --with-libxml_headers=path #location of the libxml headers
  (default is /usr/include/libxml2/)




 --
 Mike Rylander
  | VP, Research and Design
  | Equinox Software, Inc. / The Evergreen Experts
  | phone: 1-877-OPEN-ILS (673-6457)
  | email: [EMAIL PROTECTED]
  | web: http://www.esilibrary.com



Re: [OPEN-ILS-DEV] PATCH: osrf_hash[ch] (new implementation)

2008-05-15 Thread Bill Erickson
On Sunday 06 April 2008 8:16 Scott McKellar wrote:


 If you prefer, I can wait till you apply yesterday's patches and
 create new patches then.  Or I can send you entire files instead of
 patches.  Whatever is least troublesome for you.


Scott, would it be possible to get an updated set of osrf_hash_c and 
osrf_hash_h patches?  There's now enough matching code between the patches 
and the version in the repository to break things good.  

Thanks, Scott.

-bill

-- 
Bill Erickson
| VP, Software Development  Integration
| Equinox Software, Inc. / The Evergreen Experts
| phone: 877-OPEN-ILS (673-6457)
| email: [EMAIL PROTECTED]
| web: http://esilibrary.com


Re: [OPEN-ILS-DEV] PATCH: osrf_legacy_json.c (miscellaneous)

2008-05-15 Thread Bill Erickson
On Sunday 13 April 2008 12:20 Scott McKellar wrote:
 This patch tweaks a few things.

 1. In json_parse_json_string() we declare a character array buff[],
 fill it with nuls, and never refer to it again.  I eliminated it.

 2. A few lines below that, we use memset() to clear a three-character
 buffer.  I replaced the memset() with an initializer clause.

 3. in json_handle_error() we were relying on the osrf_clearbuf macro
 to add a terminal nul.  However the plan is for this macro to become
 a no-op someday.  I added the nul manually.

Also applied.  

-bill

-- 
Bill Erickson
| VP, Software Development  Integration
| Equinox Software, Inc. / The Evergreen Experts
| phone: 877-OPEN-ILS (673-6457)
| email: [EMAIL PROTECTED]
| web: http://esilibrary.com