Re: [OPEN-ILS-DEV] PATCH: osrf_json.c (rewrite of jsonObjectToJSON[Raw])

2008-11-18 Thread Bill Erickson
On Mon, 17 Nov 2008 23:32:21 -0500, Scott McKellar [EMAIL PROTECTED] wrote: This patch is a rewrite of the jsonObjectToJSON and jsonObjectToJSONRaw functions. It is dependent on my previous patch to utils.c and utils.h, adding the new buffer_append_uescape function. One purpose is to

Re: [OPEN-ILS-DEV] PATCH: osrf_json.c (rewrite of jsonObjectToJSON[Raw])

2008-11-18 Thread Scott McKellar
--- On Tue, 11/18/08, Bill Erickson [EMAIL PROTECTED] wrote: From: Bill Erickson [EMAIL PROTECTED] snip I've run into one issue with these last 2 patches, in particular, there seems to be a subtle difference in uescape() and buffer_append_uescape(). The majority of the JSON parsing

Re: [OPEN-ILS-DEV] PATCH: osrf_json.c (rewrite of jsonObjectToJSON[Raw])

2008-11-18 Thread Scott McKellar
--- On Tue, 11/18/08, Bill Erickson [EMAIL PROTECTED] wrote: OK, I tracked down 2 problems, the first makes sense, the second, not so much. The first problem was the result of attempting to escape quotes () and backslashes (\) in the final if/else block of buffer_append_uescape().

[OPEN-ILS-DEV] PATCH: osrf_json.c (rewrite of jsonObjectToJSON[Raw])

2008-11-17 Thread Scott McKellar
This patch is a rewrite of the jsonObjectToJSON and jsonObjectToJSONRaw functions. It is dependent on my previous patch to utils.c and utils.h, adding the new buffer_append_uescape function. One purpose is to replace a call to the uescape function with a call to the faster buffer_append_uescape