>>> "Eddie Wai" schrieb am 11.11.2010 um 00:04 in
Nachricht <1289430297-30221-12-git-send-email-eddie@broadcom.com>:
[...]
> diff --git a/drivers/scsi/bnx2i/bnx2i.h b/drivers/scsi/bnx2i/bnx2i.h
> index d153607..72feb6c 100644
> --- a/drivers/scsi/bnx2i/bnx2i.h
> +++ b/drivers/scsi/bnx2i/bn
The stop path has been augmented to wait a max of 10s for all in
progress offload and destroy activities to complete before proceeding
to terminate all active connections (via iscsid or forcefully).
Note that any new offload and destroy requests are now blocked and
return to the caller immediately
In the situation where the connect completion response arrives after
the connect request has already timed out, the connection was not being
aborted but only the resource was being freed. This creates a problem
for 5771X (10g) as the chip flags this with an assertion.
This change will properly ab
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/bnx2i_init.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 131ef80..99ca605 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/b
The patch fixes the following situations where NOP-Out pkt is called for:
- local unsolicited NOP-Out requests (requesting no NOP-In response)
- local NOP-Out responses to unsolicited NOP-In requests
kernel panic is observed due to double session spin_lock requests; one in the
bnx2i_process_nopin_
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/57xx_iscsi_constants.h |3 ++-
drivers/scsi/bnx2i/57xx_iscsi_hsi.h |3 ++-
drivers/scsi/bnx2i/bnx2i.h|3 ++-
drivers/scsi/bnx2i/bnx2i_hwi.c|3 ++-
drivers/scsi/bnx2i/bnx2i_init.c |3 ++-
Added the handling for cases when a chip request is made to the
CNIC module but the hardware is not ready to accept. This would
lead to many unnecessary wait timeouts.
This code adds check in the connect establishment and destruction
path.
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/bnx2i.h
Added net_dev mutex lock protection before accessing the csk
parameters.
Signed-off-by: Eddie Wai
Reviewed-by: Benjamin Li
---
drivers/scsi/bnx2i/bnx2i_iscsi.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/sc
In the case the chip is undergoing different invasive operation
which requires a chip reset, all NOPOUT request during this period
must be silently dropped from queuing to the hardware. This patch
will respond to libiscsi immediately with sent success. Since the
request was not actually sent, the
The code no longer needs to dynamically register and unregister
the CNIC device. The CNIC device will be kept registered until
module unload.
Signed-off-by: Eddie Wai
Reviewed-by: Michael Chan
---
drivers/scsi/bnx2i/bnx2i.h |3 -
drivers/scsi/bnx2i/bnx2i_init.c | 82 --
Added a be32_to_cpu call for the TMF LUN wqe.
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/bnx2i_hwi.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 32cf930..c9a3c0f 100644
--- a/drivers/scsi
Modified the handling of the remote TCP RST code so the chip can now
flush the tx pipe accordingly upon a remote TCP RST reception.
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/bnx2i_hwi.c | 11 ---
drivers/scsi/bnx2i/bnx2i_iscsi.c |8 +++-
2 files changed, 11 insertions(+
This is the case when iscsid gets re-launched due to features like
iSCSI boot which requires the daemon to re-launch due to
pivot root. If the code detected the connection had an existing
endpoint, the old endpoint must get cleaned up.
Signed-off-by: Eddie Wai
Acked-by: Anil Veerabhadrappa
---
Various error conditions inside ep_connect and ep_disconnect were
either not being handled or not being handled correctly. This patch
fixes all those issues.
Signed-off-by: Eddie Wai
Acked-by: Anil Veerabhadrappa
---
drivers/scsi/bnx2i/bnx2i_iscsi.c | 67 ++---
The NETDEV_GOING_DOWN handling will no longer request to put all
active sessions into recovery mode until the NETDEV_DOWN event.
This will eliminate the unnecessary recovery request to iscsid in the
NETDEV_GOING_DOWN->NETDEV_UNREGISTER path which will remove the host
anyway.
Signed-off-by: Eddie W
A cid leak issue was found when the connect destroy request exceeded
the driver's disconnection timeout. This will lead to a cid resource
leak issue.
The fix is to allow the cid cleanup even when this happens.
Signed-off-by: Eddie Wai
Acked-by: Anil Veerabhadrappa
Reviewed-by: Michael Chan
---
Hello,
This patch set contains various bug fixes as categorized in the following:
- scsi command handling (nop-ins, tmfs)
- various connection clean up bug fixes
Your comments are grealy appreciated. Please review, thanks.
Eddie
Eddie Wai (16):
BNX2I: Fixed bugs in the handling of unsolicite
Unsolicited NOP-Ins are placed in the receive queue of the hardware
which requires to be read out regardless if the receive pipe is suspended
or not. This patch adds the disposal of this RQ element under this
condition.
Also fixed the bug in the unsolicited NOP-In handling routine which
checks for
18 matches
Mail list logo
