Antw: [patch] iscsiadm cli help update

2011-08-03 Thread Ulrich Windl
Hi! The idea is good, but I'd use a different implementation, trying to put most text into one data structure, and then select the correct text. Roughly like struct help { const char *option; const char *explanation; }; struct help the_help[] = { {p, Portal in ip:port format. If only ip

Re: [patch] iscsiadm cli help update

2011-08-03 Thread Vivek S
I can do as you say, but whats the advantage ? On Wed, Aug 3, 2011 at 11:39 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: Hi! The idea is good, but I'd use a different implementation, trying to put most text into one data structure, and then select the correct text. Roughly

Re: TODO list- userspace2.

2011-08-03 Thread rahul gupta
On Thu, Jul 28, 2011 at 7:03 PM, Mike Christie micha...@cs.wisc.edu wrote: On 07/26/2011 01:43 PM, rahul gupta wrote: Hi Mike, Hey, I have taken care of points you mentioned in last mail. Following is git diff with my comments (for patch without comments please refer

Re: [PATCH] Replace iscsi_get_next_target_id with IDA

2011-08-03 Thread Mike Christie
On 08/02/2011 09:23 PM, John Soni Jose wrote: Replaced the iscsi_get_next_target_id with IDA to make target-id allocation efficient for iscsi offload drivers This patch should be applied after Jonathen Cameron Patch ida : simplified functions for id allocation Signed-off-by: John Soni

Re: [patch] iscsiadm cli help update

2011-08-03 Thread Mike Christie
Hey Vivek, Sorry for not commenting sooner. I thought I did. First, here is some useful git commands to make and send patches. The patch that made it to the list got its formatting mangled by your mailer. To make a patch for sending to the list that is already merged in your copy of the tree