[PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Anish Bhatt
Currently, the iface.ipaddress field is required in iface files for offload iscsi. This is not generated by `iscsiadm -m iface` , requiring manual editing of the files. However, some transports (like Chelsio) can work without needing the ipaddress to be explicitly defined in the iface files. This

Re: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Mike Christie
On 10/25/2011 01:58 PM, Anish Bhatt wrote: Currently, the iface.ipaddress field is required in iface files for offload iscsi. This is not generated by `iscsiadm –m iface` , requiring manual editing of the files. However, some transports (like Chelsio) can work without needing the ipaddress to

RE: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Anish Bhatt
-Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Tuesday, October 25, 2011 3:45 PM To: open-iscsi@googlegroups.com Cc: Anish Bhatt Subject: Re: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi On 10/25/2011 01:58 PM,

RE: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Karen Xie
Hi, Mike, The patch is taking care of the cases where the ip address is already set by other tools. And if the ip address is not present in the iface file, the ip of the netdev/ethX is used. Thanks, Karen -Original Message- From: open-iscsi@googlegroups.com

Re: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Mike Christie
On 10/25/2011 06:20 PM, Anish Bhatt wrote: Update patch attached. Left .set_host_ip = 0 untouched though. Added some comments. Why is that? If you are going to change it you should clean it all up. -- You received this message because you are subscribed to the Google Groups open-iscsi

Re: TODO list- userspace2.

2011-10-25 Thread Mike Christie
On 10/11/2011 10:59 AM, rahul gupta wrote: Hi Mike/all, I am working on a part of user space 1 of TODO list, which precisely says- No comments still. I guess logging is not fun :) the functions that were run (FUNCTION) the iSCSI packets that were sent/receieved (PDUS) print out

RE: [PATCH] make if.ipaddress optional in iface configuration files for offload iscsi

2011-10-25 Thread Anish Bhatt
Wasn't sure why set_host_ip for qla4xx was explicitly set to default value; thought in hindsight should have removed that. v3 attached, hopefully this is the final patch :) -Anish One socket to bind them all. -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: