Re: [RFC_V5 PATCH 1/3] scsi_transport_iscsi: Add flash node mgmt support

2013-05-28 Thread Eddie Wai
Hello Mike, Vikas, and all, Thanks for the great work in creating the flash node mechanism! To extend the conversation we had to add support for software and other offload solutions that requires iscsid/iscsiadm to create the sessions, the following needs to be further discussed: 1. Flash node c

Re: [PATCH v4 2/3] ISCSID: Added the extraction of the session boot info

2013-05-28 Thread Mike Christie
On 05/28/2013 12:07 PM, Eddie Wai wrote: > > On Tue, 2013-05-28 at 04:05 -0500, Mike Christie wrote: >> On 04/12/2013 12:41 PM, Eddie Wai wrote: >>> This patch does the work to extract the corresponding >>> ->ethernetN net params as specified from the kernel >>> session boot_nic sysfs entry based

Re: [PATCH v4 2/3] ISCSID: Added the extraction of the session boot info

2013-05-28 Thread Eddie Wai
On Tue, 2013-05-28 at 04:05 -0500, Mike Christie wrote: > On 04/12/2013 12:41 PM, Eddie Wai wrote: > > This patch does the work to extract the corresponding > > ->ethernetN net params as specified from the kernel > > session boot_nic sysfs entry based on the transport param > > use_boot_info. > >

Re: [PATCH v4 2/3] ISCSID: Added the extraction of the session boot info

2013-05-28 Thread Mike Christie
On 04/12/2013 12:41 PM, Eddie Wai wrote: > This patch does the work to extract the corresponding > ->ethernetN net params as specified from the kernel > session boot_nic sysfs entry based on the transport param > use_boot_info. > > This is only populated for iscsi_tcp and bnx2i. > > Signed-off-by

Antw: Re: [PATCH 1/2] iscsiadm: Correct the comparison for invalid hostno in host mode

2013-05-28 Thread Ulrich Windl
>>> I wrote a moment ago: [...] > I away wonder whether 0x is "(unsigned) -1". I would avoid concrete "away" was meant to read "always": Isn't it interesting how a tired mind works? ;-) Sorry for the bad typing! > bits as much as possible... [...] -- You received this message because

Antw: Re: [PATCH 1/2] iscsiadm: Correct the comparison for invalid hostno in host mode

2013-05-28 Thread Ulrich Windl
>>> Mike Christie schrieb am 28.05.2013 um 10:34 in Nachricht <51a46c13.3030...@cs.wisc.edu>: > On 05/28/2013 03:27 AM, Mike Christie wrote: >> On 04/05/2013 06:34 AM, vikas.chaudh...@qlogic.com wrote: >>> From: Adheer Chandravanshi >>> >>> Signed-off-by: Adheer Chandravanshi >>> Signed-off-by:

Re: Antw: Re: [PATCH 0/3] open-iscsi patchset to add iscsiuio

2013-05-28 Thread Mike Christie
On 05/28/2013 03:24 AM, Ulrich Windl wrote: Mike Christie schrieb am 28.05.2013 um 10:19 in > Nachricht <51a4689b.1040...@cs.wisc.edu>: >> On 02/15/2013 06:58 PM, Eddie Wai wrote: >>> This patchset can be applied on top of the open-iscsi package >>> to enable Broadcom's iSCSI offload user spa

Re: [PATCH 1/2] iscsiadm: Correct the comparison for invalid hostno in host mode

2013-05-28 Thread Mike Christie
On 05/28/2013 03:27 AM, Mike Christie wrote: > On 04/05/2013 06:34 AM, vikas.chaudh...@qlogic.com wrote: >> From: Adheer Chandravanshi >> >> Signed-off-by: Adheer Chandravanshi >> Signed-off-by: Vikas Chaudhary >> --- >> usr/iscsiadm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH 1/2] iscsiadm: Correct the comparison for invalid hostno in host mode

2013-05-28 Thread Mike Christie
On 04/05/2013 06:34 AM, vikas.chaudh...@qlogic.com wrote: > From: Adheer Chandravanshi > > Signed-off-by: Adheer Chandravanshi > Signed-off-by: Vikas Chaudhary > --- > usr/iscsiadm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/usr/iscsiadm.c b/usr/iscsiadm.c >

Antw: Re: [PATCH 0/3] open-iscsi patchset to add iscsiuio

2013-05-28 Thread Ulrich Windl
>>> Mike Christie schrieb am 28.05.2013 um 10:19 in Nachricht <51a4689b.1040...@cs.wisc.edu>: > On 02/15/2013 06:58 PM, Eddie Wai wrote: >> This patchset can be applied on top of the open-iscsi package >> to enable Broadcom's iSCSI offload user space tool 'iscsiuio'. >> >> This user space tool is

Re: [PATCH 1/1] iscsiadm: bind ifaces to portals found using isns

2013-05-28 Thread Mike Christie
On 04/23/2013 06:55 PM, Mike Christie wrote: > Sorry. I forgot to merge this patch. It even happens to patches I send > myself :) When I get home this weekend I will merge it up and all the > other outstanding patches that I have reviewed. I will also review the > iscsi boot ones from Eddie. > >

Re: [PATCHv2 0/3] SUSE Patch that should be upstream

2013-05-28 Thread Mike Christie
On 03/08/2013 01:11 PM, Lee Duncan wrote: > Here are 3 patches. The first one is a bug I found in how > nice() return value is being checked, and the other two are > patches that we have been carrying in the SUSE version of > open-iscsi that I wanted to pass upstream. > > Lee Duncan: > [PA

Re: PATCH 1 of 1] correctly check return value of nice()

2013-05-28 Thread Mike Christie
On 05/21/2013 04:16 PM, Lee Duncan wrote: > The nice() call can return a negative value, since > it returns the previous nice value. > > Signed-off-by: Lee Duncan > --- > usr/iscsi_util.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/usr/iscsi_util.c b/usr/iscsi_

Re: [PATCH 0/3] iscsiadm: Patches for iSCSI flash node mgmt support

2013-05-28 Thread Mike Christie
On 03/22/2013 06:35 AM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > Mike, > > Following patches allows iscsiadm to manage iSCSI target information > stored on adapter flash on per host basis and and perform various > operations like add, delete, login, logout, and update the ta

Re: [PATCH 0/3] open-iscsi patchset to add iscsiuio

2013-05-28 Thread Mike Christie
On 02/15/2013 06:58 PM, Eddie Wai wrote: > This patchset can be applied on top of the open-iscsi package > to enable Broadcom's iSCSI offload user space tool 'iscsiuio'. > > This user space tool is used in conjunction with the following > Broadcom Network Controllers to enable iSCSI offload functi