Should we use autotools (or something like it) for build system?

2022-08-04 Thread The Lee-Man
Hi! I'm considering updating the build system to use autoconf/automake, or maybe something newer like meson? See the discussion at: https://github.com/open-iscsi/open-iscsi/issues/359 -- Lee Duncan -- You received this message because you are subscribed to the Google Groups "open-iscsi"

Re: [PATCH] scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

2022-08-04 Thread kernel test robot
Hi Li, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next linus/master v5.19 next-20220728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

RE: [PATCH] scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

2022-08-04 Thread 'lijinlin (A)' via open-iscsi
So sorry, this patch has problem, please ignore. Thanks Li Jinlin -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To

Re: [PATCH] scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

2022-08-04 Thread kernel test robot
Hi Li, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next linus/master v5.19 next-20220728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH] scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

2022-08-04 Thread 'Li Jinlin' via open-iscsi
I got a kernel NULL pointer derference report as below: BUG: kernel NULL pointer dereference, address: 0038 CPU: 4 PID: 1050 Comm: cat Not tainted 5.19.0 #38 RIP: 0010:kernel_getpeername+0xf/0x30 Call Trace: ? iscsi_sw_tcp_conn_get_param+0x11f/0x17f

Re: [PATCH] scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

2022-08-04 Thread 'Li Jinlin' via open-iscsi
On 8/3/2022 12:25 AM, Mike Christie wrote: > On 8/2/22 6:23 AM, lijinlin (A) wrote: >> So sorry, this patch has problem, please ignore. >> > > Was the issue the fget use? >> I know I gave the suggestion to do the get, but seeing it now makes > me think I was wrong and it's getting too messy. >