Re: [PATCH 06/11] iscsi: set netns for tcp and iser hosts

2023-05-06 Thread kernel test robot
Hi Chris, kernel test robot noticed the following build warnings: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next horms-ipvs/master linus/master v6.3 next-20230505] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 06/11] iscsi: set netns for tcp and iser hosts

2023-05-06 Thread kernel test robot
Hi Chris, kernel test robot noticed the following build warnings: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next horms-ipvs/master linus/master v6.3 next-20230505] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH 11/11] iscsi: force destroy sesions when a network namespace exits

2023-05-06 Thread Chris Leech
The namespace is gone, so there is no userspace to clean up. Force close all the sessions. This should be enough for software transports, there's no implementation of migrating physical iSCSI hosts between network namespaces currently. Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech

[PATCH 09/11] iscsi: filter flashnode sysfs by net namespace

2023-05-06 Thread Chris Leech
From: Lee Duncan This finishes the net namespace support for flashnode sysfs devices. Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 34 + include/scsi/scsi_transport_iscsi.h | 4

[PATCH 08/11] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

2023-05-06 Thread Chris Leech
From: Lee Duncan These are cleanups after the bus to class conversion for flashnode devices. Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech --- drivers/scsi/qla4xxx/ql4_os.c | 52 +++--- drivers/scsi/scsi_transport_iscsi.c | 102

[PATCH 04/11] iscsi: make all iSCSI netlink multicast namespace aware

2023-05-06 Thread Chris Leech
From: Lee Duncan Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Lee Duncan Reviewed-by: Hannes

[PATCH 05/11] iscsi: check net namespace for all iscsi lookup

2023-05-06 Thread Chris Leech
From: Lee Duncan All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +-

[PATCH 07/11] iscsi: convert flashnode devices from bus to class

2023-05-06 Thread Chris Leech
From: Lee Duncan The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Lee

[PATCH 10/11] iscsi: make session and connection lists per-net

2023-05-06 Thread Chris Leech
Eliminate the comparisions on list lookups, and it will make it easier to shut down session on net namespace exit in the next patch. Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 104 1 file changed, 61

[PATCH 01/11] iscsi: create per-net iscsi netlink kernel sockets

2023-05-06 Thread Chris Leech
From: Lee Duncan Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 73 + 1 file changed, 63 insertions(+), 10 deletions(-) diff

[PATCH 02/11] iscsi: associate endpoints with a host

2023-05-06 Thread Chris Leech
Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created, when possible. iSER creates endpoints before hosts and

[PATCH 06/11] iscsi: set netns for tcp and iser hosts

2023-05-06 Thread Chris Leech
This lets iscsi_tcp and ib_iser operate in multiple namespaces. The logic to store the network namespace during virtual host creation (due to the way transport-class object setup callbacks function) is in libiscsi, and shared between iscsi_tcp and ib_iser. There are a few changes to do so: *

[PATCH v2 00/11] Make iscsid-kernel communications namespace-aware

2023-05-06 Thread Chris Leech
This set of patches modifies the kernel iSCSI initiator communications so that they are namespace-aware. The goal is to allow multiple iSCSI daemon (iscsid) to run at once as long as they are in separate namespaces, and so that iscsid can run in containers. Container runtime environments seem to

[PATCH 03/11] iscsi: sysfs filtering by network namespace

2023-05-06 Thread Chris Leech
This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Lee Duncan