Re: [PATCH v1 2/2] scsi: iscsi: Add strlen check in iscsi_if_set_{host}_param

2023-07-25 Thread Martin K. Petersen
Lin, > The function iscsi_if_set_param and iscsi_if_set_host_param converts > nlattr payload to type char* and then call C string handling functions > like sscanf and kstrdup. Applied to 6.6/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this

Re: [PATCH v2 1/2] scsi: iscsi: Add length check for nlattr payload

2023-07-25 Thread Martin K. Petersen
Lin, > The current NETLINK_ISCSI netlink parsing loop checks every nlmsg to > make sure the length is bigger than the sizeof(struct iscsi_uevent) > and then calls iscsi_if_recv_msg(...). Applied to 6.6/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You

Re: [PATCH -next] scsi: iscsi: Remove unused extern declaration iscsi_lookup_iface()

2023-07-25 Thread Martin K. Petersen
YueHaibing, > This is not used anymore, so can be removed. Applied to 6.6/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop

Re: [PATCH -next] scsi: iscsi: Remove unused extern declaration iscsi_lookup_iface()

2023-07-25 Thread Chris Leech
On Tue, Jul 25, 2023 at 10:15:31PM +0800, YueHaibing wrote: > This is not used anymore, so can be removed. > > Signed-off-by: YueHaibing Thanks, Reviewed-by: Chris Leech -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from

Re: [PATCH v1 2/2] scsi: iscsi: Add strlen check in iscsi_if_set_{host}_param

2023-07-25 Thread Chris Leech
On Tue, Jul 25, 2023 at 10:45:45AM +0800, Lin Ma wrote: > The function iscsi_if_set_param and iscsi_if_set_host_param converts > nlattr payload to type char* and then call C string handling functions > like sscanf and kstrdup. > > char *data = (char*)ev + sizeof(*ev); > ... > sscanf(data,

Re: [PATCH v2 1/2] scsi: iscsi: Add length check for nlattr payload

2023-07-25 Thread Chris Leech
On Tue, Jul 25, 2023 at 10:45:29AM +0800, Lin Ma wrote: > The current NETLINK_ISCSI netlink parsing loop checks every nlmsg to > make sure the length is bigger than the sizeof(struct iscsi_uevent) and > then calls iscsi_if_recv_msg(...). > > nlh = nlmsg_hdr(skb); > if (nlh->nlmsg_len <

[PATCH -next] scsi: iscsi: Remove unused extern declaration iscsi_lookup_iface()

2023-07-25 Thread 'YueHaibing' via open-iscsi
This is not used anymore, so can be removed. Signed-off-by: YueHaibing --- include/scsi/scsi_transport_iscsi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h index 34c03707fb6e..fb3399e4cd29 100644 ---