On Tue, Mar 26, 2024 at 06:30:45PM +0900, Takashi Sakamoto wrote:
> > drivers/firewire/sbp2.c | 7 ---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
>
> I'm not good at any kind of storage protocol, thus execute me not to
> review it. My concern is which subsystem provides the change
On Mon, Mar 25, 2024 at 04:38:43PM +0900, Damien Le Moal wrote:
> > + if (hostt->device_configure)
> > + ret = hostt->device_configure(sdev, );
> > + else if (hostt->slave_configure)
> > + ret = hostt->slave_configure(sdev);
> > +
> > + ret2 =
On Mon, Mar 25, 2024 at 01:35:08PM -0700, Bart Van Assche wrote:
> There are two methods with names that are politically charged:
> slave_configure() and slave_alloc(). Shouldn't both be renamed?
Probably. This series howerver doesn't actually renames anything,
it just adds a new method that
On Mon, Mar 25, 2024 at 04:26:55PM +0900, Damien Le Moal wrote:
> On 3/25/24 08:54, Christoph Hellwig wrote:
> > While we really should be killing the block layer bounce buffering ASAP,
> > I even more urgently need to stop the drivers to fiddle with the limits
> > from ->slave_configure. Add a