Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-21 Thread Martin K. Petersen
On Tue, 7 Jun 2022 16:19:53 +0300, Dmitry Bogdanov wrote: > In function iscsi_data_xmit (TX worker) there is walking through the > queue of new SCSI commands that is replenished in parallell. And only > after that queue got emptied the function will start sending pending > DataOut PDUs. That lead

Antw: [EXT] Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-16 Thread Ulrich Windl
>>> Adam Hutchinson schrieb am 15.06.2022 um 20:57 in Nachricht : > Is there any reason not to use time as an indicator that pending R2Ts > need to be processed? Could R2Ts be tagged with a timestamp when > received and only given priority over new commands if the age of the > R2T at the head

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-15 Thread Adam Hutchinson
Is there any reason not to use time as an indicator that pending R2Ts need to be processed? Could R2Ts be tagged with a timestamp when received and only given priority over new commands if the age of the R2T at the head exceeds some configurable limit? This would guarantee R2T will eventually be

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-15 Thread Mike Christie
On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: > In function iscsi_data_xmit (TX worker) there is walking through the > queue of new SCSI commands that is replenished in parallell. And only > after that queue got emptied the function will start sending pending > DataOut PDUs. That lead to DataOut timer

RE: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-10 Thread Dmitriy Bogdanov
Hi Mike, On 6/8/22 9:16 AM, Dmitriy Bogdanov wrote: > On 6/7/22 10:55 AM, Mike Christie wrote: >> On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: >>> In function iscsi_data_xmit (TX worker) there is walking through the >>> queue of new SCSI commands that is replenished in

RE: Antw: [EXT] Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-10 Thread Dmitriy Bogdanov
Hi Ulrich, > In my primitive point of view iSCSI is just "another type of cable", making > me wonder: > Is iSCSI allowed to reorder the requests at all? Shouldn't the block layer or > initiator do > so, or the target doing out-of order processing (tagged queueing)? iSCSI RFC does not require

Antw: [EXT] Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-10 Thread Ulrich Windl
Hi! In my primitive point of view iSCSI is just "another type of cable", making me wonder: Is iSCSI allowed to reorder the requests at all? Shouldn't the block layer or initiator do so, or the target doing out-of order processing (tagged queueing)? I mean: If there is a problem that occurs

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-09 Thread Mike Christie
On 6/9/22 4:02 AM, Dmitriy Bogdanov wrote: > Hi Mike, > >>> On 6/8/22 9:16 AM, Dmitriy Bogdanov wrote: On 6/7/22 10:55 AM, Mike Christie wrote: > On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: >> In function iscsi_data_xmit (TX worker) there is walking through the >> queue of new SCSI

RE: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-09 Thread Dmitriy Bogdanov
Hi Mike, >>On 6/8/22 9:16 AM, Dmitriy Bogdanov wrote: >>> On 6/7/22 10:55 AM, Mike Christie wrote: On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: > In function iscsi_data_xmit (TX worker) there is walking through the > queue of new SCSI commands that is replenished in parallell. And only

RE: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-09 Thread Dmitriy Bogdanov
Hi Mike, >On 6/7/22 10:55 AM, Mike Christie wrote: >> On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: >>> In function iscsi_data_xmit (TX worker) there is walking through the >>> queue of new SCSI commands that is replenished in parallell. And only >>> after that queue got emptied the function will

[PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-09 Thread Dmitry Bogdanov
In function iscsi_data_xmit (TX worker) there is walking through the queue of new SCSI commands that is replenished in parallell. And only after that queue got emptied the function will start sending pending DataOut PDUs. That lead to DataOut timer time out on target side and to connection

Antw: [EXT] Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-09 Thread Ulrich Windl
>>> Mike Christie schrieb am 08.06.2022 um 17:36 >>> in Nachricht <48af6f5f-c3b6-ac65-836d-518153ab2...@oracle.com>: > On 6/8/22 9:16 AM, Dmitriy Bogdanov wrote: >> Hi Mike, >> >>> On 6/7/22 10:55 AM, Mike Christie wrote: On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: > In function

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-08 Thread Mike Christie
On 6/8/22 9:16 AM, Dmitriy Bogdanov wrote: > Hi Mike, > >> On 6/7/22 10:55 AM, Mike Christie wrote: >>> On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: In function iscsi_data_xmit (TX worker) there is walking through the queue of new SCSI commands that is replenished in parallell. And only

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-07 Thread Mike Christie
On 6/7/22 10:55 AM, Mike Christie wrote: > On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: >> In function iscsi_data_xmit (TX worker) there is walking through the >> queue of new SCSI commands that is replenished in parallell. And only >> after that queue got emptied the function will start sending

Re: [PATCH] scsi: iscsi: prefer xmit of DataOut before new cmd

2022-06-07 Thread Mike Christie
On 6/7/22 8:19 AM, Dmitry Bogdanov wrote: > In function iscsi_data_xmit (TX worker) there is walking through the > queue of new SCSI commands that is replenished in parallell. And only > after that queue got emptied the function will start sending pending > DataOut PDUs. That lead to DataOut timer