On Mon, Nov 13, 2017 at 04:35:00PM -0800, The Lee-Man wrote:
> I will review these patches individually (it might take an extra day), but
> I have an initial question: will this change the sysfs interface for iscsi.
> But I'm pretty sure the answer is yes. Which would mean we could
> break other th
On Tue, 2017-11-07 at 10:01 -0800, Chris Leech wrote:
> Hello,
>
> I have this set of changes to the iSCSI control interfaces pending
> review, but seeing as it's sysfs and netlink changes there's not a
> lot of feedback from linux-scsi.
Well, it's a bit unlikely that they understand network name
I have reviewed all the patches to the best of my ability.
Other than the comments I made, please add my reviewed-by
tag to all of them.
I was surprised as how pervasive the single-namespace assumption
was buried in the code, as evidenced by how much you had to
change.
I assume you've tested th
I will review these patches individually (it might take an extra day), but
I have an initial question: will this change the sysfs interface for iscsi.
But I'm pretty sure the answer is yes. Which would mean we could
break other things. If this is true, perhaps we should bump the
major version numbe
On Tue, Nov 07, 2017 at 12:45:26PM -0800, James Bottomley wrote:
> On Tue, 2017-11-07 at 10:01 -0800, Chris Leech wrote:
> > Hello,
> >
> > I have this set of changes to the iSCSI control interfaces pending
> > review, but seeing as it's sysfs and netlink changes there's not a
> > lot of feedback
On Tue, Nov 07, 2017 at 10:01:56AM -0800, Chris Leech wrote:
> Hello,
>
> I have this set of changes to the iSCSI control interfaces pending
> review, but seeing as it's sysfs and netlink changes there's not a lot
> of feedback from linux-scsi.
>
> I was hoping I could get a brief review on the a
Hello,
I have this set of changes to the iSCSI control interfaces pending
review, but seeing as it's sysfs and netlink changes there's not a lot
of feedback from linux-scsi.
I was hoping I could get a brief review on the adding of network
namespace support here.
Thank you,
Chris
On Tue, Oct 31,
Anyone have comments or criticisms? Lee?
Suggestions on anyone else I should be pinging for feedback?
These changes are in the iSCSI code, but are all netlink and sysfs
related namespace issues so I get that it's not a typical SCSI review.
- Chris
On Tue, Oct 31, 2017 at 03:40:55PM -0700, Chris
This series of changes makes the iSCSI netlink and sysfs control
interfaces filtered by network namespace. This is required to run
iscsid in any network namespace other than the initial default one.
Currently the netlink communication will fail if iscsid is started in a
non-default network namesp
